unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel <emacs-devel@gnu.org>, Theodor Thornhill <theo@thornhill.no>
Subject: Re: emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142)
Date: Mon, 6 Feb 2023 18:52:35 -0800	[thread overview]
Message-ID: <DCE1F90D-A39B-4A00-9C6D-0CC1B85A6CA3@gmail.com> (raw)
In-Reply-To: <8b6025df-e6e9-af42-cc89-7f0f1bc5fcdc@yandex.ru>



> On Feb 6, 2023, at 2:15 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
> 
> Hi Theodor,
> 
> On 06/02/2023 08:45, Theodor Thornhill via Mailing list for Emacs changes wrote:
>> +           (equal (treesit-node-type node) c-ts-common-if-statement-regexp)
>> +           (equal (treesit-node-type (treesit-node-parent node))
>> +                  c-ts-common-if-statement-regexp)
> 
> If the variable is called -regexp, I suppose these should use string-match-p.
> 

I partly am to blame. I made some changes to c-ts-common but didn’t push it, so Theo had to patch on my convoluted code. I’ve pushed my changes and updated java-ts-mode to use the new interface. This new interface is hopefully easier to use and understand.

Yuan


      reply	other threads:[~2023-02-07  2:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <167566591126.8500.18117950634798405754@vcs2.savannah.gnu.org>
     [not found] ` <20230206064515.5AA2CC0060F@vcs2.savannah.gnu.org>
2023-02-06 22:15   ` emacs-29 5a6dfab1e4 2/2: Use c-ts-common-statement-offset in java-ts-mode (bug#61142) Dmitry Gutov
2023-02-07  2:52     ` Yuan Fu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DCE1F90D-A39B-4A00-9C6D-0CC1B85A6CA3@gmail.com \
    --to=casouri@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).