From: Theodor Thornhill <theo@thornhill.no>
To: Stefan Kangas <stefankangas@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, mardani29@yahoo.es, raman@google.com,
casouri@gmail.com, tsdh@gnu.org
Subject: Re: Rename Tree-sitter major modes from "ts" to "treesit" (was Re: tree-sitter version?)
Date: Sat, 26 Nov 2022 07:45:05 +0100 [thread overview]
Message-ID: <DC3C207E-DD79-4286-B064-00AA08A9D782@thornhill.no> (raw)
In-Reply-To: <CADwFkm=4tA5CEfXWg5btxEPLM_poMkjEtX604D-BezffRYi_Hg@mail.gmail.com>
On 26 November 2022 02:04:49 CET, Stefan Kangas <stefankangas@gmail.com> wrote:
>Theodor Thornhill via "Emacs development discussions."
><emacs-devel@gnu.org> writes:
>
>> Feel free to commit this, Eli. I've only done a rename.
>
>Thanks.
>
>However, note that it's better to rename the file in a separate commit,
>containing no other changes. That way, "git blame" provides stronger
>guarantees for providing correct attribution. (BTW, "git log" does too,
>but it needs a --follow flag.)
>
>So I did the rename separately, in your name, applied your patch on top,
>and pushed the result to master (commit 374f4e38c1). I also adjusted
>the commit message slightly to reflect this:
>
> Rename ts-mode to typescript-ts-mode
>
> * lisp/progmodes/typescript-ts-mode.el: Rename from 'ts-mode' to
> 'typescript-ts-mode'. Rename all symbols to match new prefix.
> * etc/NEWS: Mention the new mode name.
> Ref: https://lists.gnu.org/r/emacs-devel/2022-11/msg01587.html
Ah ok - thanks for the tip! And for applying :)
Theo
next prev parent reply other threads:[~2022-11-26 6:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 1:54 tree-sitter version? T.V Raman
2022-11-24 3:27 ` Yuan Fu
2022-11-24 4:57 ` T.V Raman
2022-11-24 5:02 ` Yuan Fu
2022-11-24 5:54 ` Tassilo Horn
2022-11-25 9:43 ` Yuan Fu
2022-11-25 11:52 ` Eli Zaretskii
2022-11-25 15:08 ` T.V Raman
2022-11-25 16:25 ` Rename Tree-sitter major modes from "ts" to "treesit" (was Re: tree-sitter version?) Daniel Martín
2022-11-25 16:33 ` Eli Zaretskii
2022-11-25 16:38 ` Theodor Thornhill
2022-11-25 17:50 ` Elliott Shugerman
2022-11-25 23:41 ` Rudolf Adamkovič
2022-11-25 19:40 ` Eli Zaretskii
2022-11-25 19:58 ` Theodor Thornhill
2022-11-25 20:13 ` Theodor Thornhill via Emacs development discussions.
2022-11-26 1:04 ` Stefan Kangas
2022-11-26 6:45 ` Theodor Thornhill [this message]
2022-11-26 8:20 ` Yuan Fu
2022-11-26 8:22 ` Theodor Thornhill
2022-11-26 8:31 ` Eli Zaretskii
2022-11-26 9:06 ` Theodor Thornhill
2022-11-28 21:36 ` tree-sitter version? Richard Stallman
2022-11-29 3:28 ` Eli Zaretskii
2022-12-04 23:13 ` Richard Stallman
2022-12-05 3:27 ` Eli Zaretskii
2022-12-06 22:35 ` Richard Stallman
2022-12-07 3:31 ` Eli Zaretskii
2022-11-25 15:06 ` T.V Raman
-- strict thread matches above, loose matches on Subject: below --
2022-11-26 3:22 Rename Tree-sitter major modes from "ts" to "treesit" (was Re: tree-sitter version?) daanturo
2022-11-26 7:43 ` Yuri Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC3C207E-DD79-4286-B064-00AA08A9D782@thornhill.no \
--to=theo@thornhill.no \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mardani29@yahoo.es \
--cc=raman@google.com \
--cc=stefankangas@gmail.com \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).