From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Steven Tamm Newsgroups: gmane.emacs.devel Subject: Re: Patch for Mac OS X Text Drawing Date: Mon, 24 Jan 2005 10:00:38 -0800 Message-ID: References: <0F0CEC8B-6757-11D9-9ECE-000D93B67DC4@mac.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1106590717 14437 80.91.229.6 (24 Jan 2005 18:18:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 Jan 2005 18:18:37 +0000 (UTC) Cc: "Kim F. Storm" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 24 19:18:26 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Ct8nB-0004GA-00 for ; Mon, 24 Jan 2005 19:18:25 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ct8zO-0002oQ-VK for ged-emacs-devel@m.gmane.org; Mon, 24 Jan 2005 13:31:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ct8vX-0000vq-9V for emacs-devel@gnu.org; Mon, 24 Jan 2005 13:27:04 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ct8vJ-0000ot-Ne for emacs-devel@gnu.org; Mon, 24 Jan 2005 13:26:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ct8vJ-0000ke-0f for emacs-devel@gnu.org; Mon, 24 Jan 2005 13:26:49 -0500 Original-Received: from [17.250.248.87] (helo=smtpout.mac.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ct8WC-0005OZ-N0 for emacs-devel@gnu.org; Mon, 24 Jan 2005 13:00:53 -0500 Original-Received: from mac.com (smtpin02-en2 [10.13.10.147]) by smtpout.mac.com (Xserve/MantshX 2.0) with ESMTP id j0OI0mls011560; Mon, 24 Jan 2005 10:00:49 -0800 (PST) Original-Received: from [10.0.1.201] (c-24-4-203-197.client.comcast.net [24.4.203.197]) (authenticated bits=0) by mac.com (Xserve/smtpin02/MantshX 4.0) with ESMTP id j0OI0jEw021375; Mon, 24 Jan 2005 10:00:47 -0800 (PST) In-Reply-To: Original-To: YAMAMOTO Mitsuharu X-Mailer: Apple Mail (2.619) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:32533 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:32533 I checked this in. Although I think it may make sense to grant CVS access to Mr. Yamamoto, as the patches are now going outside the domain of just Mac/Carbon and into the whole realm of display rendering on all platforms. -Steven On Jan 24, 2005, at 3:15 AM, YAMAMOTO Mitsuharu wrote: >>>>>> On Mon, 24 Jan 2005 11:08:02 +0100, storm@cua.dk (Kim F. Storm) >>>>>> said: > >>> Here is a revised patch including a fix for the above bug. > >> Very good, thanks! Please install it. > > Thanks for checking. I'd like to leave it to Steven because the whole > patch (attached below) includes some changes for Mac. Actually, I > cannot do it by myself at the moment. > > YAMAMOTO Mitsuharu > mituharu@math.s.chiba-u.ac.jp > > 2005-01-24 YAMAMOTO Mitsuharu > > * dispextern.h (struct glyph_string): New members clip_head and > clip_tail. > > * xdisp.c (get_glyph_string_clip_rect): Restrict horizontal clip > region to the area between clip_head and clip_tail. > (draw_glyphs): Record the area that need to be actually redrawn to > the new variables clip_head and clip_tail when there are > overhangs. Set values of these variables to the corresponding > members in struct glyph_string. Refine x coordinates for > notice_overwritten_cursor using clip_head and clip_tail. > > * macgui.h (STORE_XCHARSETSTRUCT): New macro. > > * macterm.c (mac_compute_glyph_string_overhangs): Implement with > QDTextBounds. > (x_draw_glyph_string): Don't fill the background of the successor > of a glyph with a right overhang if the successor will draw a > cursor. > (XLoadQueryFont): Obtain font metrics using QDTextBounds. > (x_redisplay_interface): Add entry for > compute_glyph_string_overhangs. > > _______________________________________________ > Emacs-devel mailing list > Emacs-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-devel