unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 6eeab90632: Don't accept whitespace or hex floats in rgbi: colour specs
Date: Mon, 7 Mar 2022 14:36:17 +0100	[thread overview]
Message-ID: <DA2F303B-6685-44E7-A00C-EE42E87DC0AB@acm.org> (raw)
In-Reply-To: <87zgm2m5lv.fsf@yahoo.com>

7 mars 2022 kl. 11.16 skrev Po Lu <luangruo@yahoo.com>:

> See my reply to Mattias, that's not the RGBi specification I'm talking
> about.

Actually it is the spec that we are implementing. Let's recap the pertinent history, very roughly:

1. Emacs gets X11 support, and uses XParseColor.
2. XCMS is added to X11, so Emacs now understands rgbi:0/0.5/1 in addition to #fcb8a9 and SlimeGreen, but hardly anyone uses it.
3. Emacs is ported to Windows. For compatibility, the backend parses the rgbi: syntax just in case.
4. Emacs is ported to NextStep (etc), but the backend omits the rgbi: syntax. Nobody complains.
5. The colour spec parsing from all backends is consolidated to a single implementation and naturally it includes rgbi:.

Not only is the rgbi: syntax very little used, until recently it wasn't even available on all platforms.

Thus this doesn't matter much at all, and it's been fixed now because it was reported as a bug, and it was clearly my mistake to mend. I wouldn't mind dropping the support for rgbi: completely if that is all right with the maintainers.





  reply	other threads:[~2022-03-07 13:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164657208058.1597.5057681041192670917@vcs2.savannah.gnu.org>
     [not found] ` <20220306130800.EE0F9C01681@vcs2.savannah.gnu.org>
2022-03-06 13:46   ` master 6eeab90632: Don't accept whitespace or hex floats in rgbi: colour specs Po Lu
2022-03-06 13:56     ` Mattias Engdegård
2022-03-06 16:49       ` [External] : " Drew Adams
2022-03-07  0:34       ` Po Lu
2022-03-07  9:26         ` Philip Kaludercic
2022-03-07 10:16           ` Po Lu
2022-03-07 15:16             ` Philip Kaludercic
2022-03-07  9:31         ` Mattias Engdegård
2022-03-07 10:14           ` Po Lu
2022-03-07 13:36             ` Mattias Engdegård [this message]
2022-03-07 13:52               ` Po Lu
2022-03-07 16:06             ` [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DA2F303B-6685-44E7-A00C-EE42E87DC0AB@acm.org \
    --to=mattiase@acm.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).