Space between toolbar and window (Carbon?)

Space between toolbar and window (Carbon?)

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Can anyone give me a hint as to whether I can easily remove the extra  
space between the toolbar and the window (see screenshot)? It varies  
in size with frame height and line height and I'd like to get rid of  
it. Where in the code would I have to look? Is this Carbon specific?


[-- Attachment #2: pastedGraphic.png --]
[-- Type: image/png, Size: 7629 bytes --]

[-- Attachment #3: Type: text/plain, Size: 3 bytes --]





[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Space between toolbar and window (Carbon?)

[Kim F. Storm]

David Reitter <david.reitter@gmail.com> writes:

> Can anyone give me a hint as to whether I can easily remove the extra
> space between the toolbar and the window (see screenshot)? It varies
> in size with frame height and line height and I'd like to get rid of
> it. Where in the code would I have to look? Is this Carbon specific?

You cannot remove it ... it is added to make the toolbar area height
to be a multiple of the "nominal" display line height.

The reason for this is buried deeply in the redisplay engine.

I plan to fix this after the release.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Space between toolbar and window (Carbon?)

[Chong Yidong]

David Reitter <david.reitter@gmail.com> writes:

> Can anyone give me a hint as to whether I can easily remove the extra
> space between the toolbar and the window (see screenshot)? It varies
> in size with frame height and line height and I'd like to get rid of
> it. Where in the code would I have to look? Is this Carbon specific?

The non-toolkit X version has it; the GTK one doesn't.

Re: Space between toolbar and window (Carbon?)

[YAMAMOTO Mitsuharu]

>>>>> On Tue, 21 Feb 2006 23:45:24 +0100, storm@cua.dk (Kim F. Storm) said:

> David Reitter <david.reitter@gmail.com> writes:
>> Can anyone give me a hint as to whether I can easily remove the
>> extra space between the toolbar and the window (see screenshot)? It
>> varies in size with frame height and line height and I'd like to
>> get rid of it. Where in the code would I have to look? Is this
>> Carbon specific?

> You cannot remove it ... it is added to make the toolbar area height
> to be a multiple of the "nominal" display line height.

This part is redrawn on every redisplay even when it is not needed.
Could you take a look at and comment on the patch in the following
message?

  http://lists.gnu.org/archive/html/emacs-devel/2005-11/msg00570.html

I've been using this for 3 months and don't find any problems so far.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Space between toolbar and window (Carbon?)

[Kim F. Storm]

Chong Yidong <cyd@stupidchicken.com> writes:

> David Reitter <david.reitter@gmail.com> writes:
>
>> Can anyone give me a hint as to whether I can easily remove the extra
>> space between the toolbar and the window (see screenshot)? It varies
>> in size with frame height and line height and I'd like to get rid of
>> it. Where in the code would I have to look? Is this Carbon specific?
>
> The non-toolkit X version has it; the GTK one doesn't.

Right!

In the non-toolkit version, the toolbar is "just another emacs
window", and currently the height, width and position of all windows
must be a multiple of the nominal frame line height (because the
corner positions of a window is measured in lines and columns rather
than pixels).

In the GTK version, the toolbar is a separate X window, so it's height is
not constrained by this.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Space between toolbar and window (Carbon?)

[Kim F. Storm]

YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:

> This part is redrawn on every redisplay even when it is not needed.
> Could you take a look at and comment on the patch in the following
> message?
>
>   http://lists.gnu.org/archive/html/emacs-devel/2005-11/msg00570.html
>
> I've been using this for 3 months and don't find any problems so far.

The patch looks ok to me.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Space between toolbar and window (Carbon?)

[David Reitter]

On 22 Feb 2006, at 09:01, Kim F. Storm wrote:
>
> In the non-toolkit version, the toolbar is "just another emacs
> window", and currently the height, width and position of all windows
> must be a multiple of the nominal frame line height (because the
> corner positions of a window is measured in lines and columns rather
> than pixels).
>
> In the GTK version, the toolbar is a separate X window, so it's  
> height is
> not constrained by this.

Thanks, Kim.
Is there a face that defines the color of this space? It might look  
better if it was in the background color of the frame.

I thought about :margin for the toolbar icon images, however, one  
would have to redefine the toolbar every time the frame line height  
changes.

Re: Space between toolbar and window (Carbon?)

[YAMAMOTO Mitsuharu]

>>>>> On Wed, 22 Feb 2006 13:24:00 +0100, storm@cua.dk (Kim F. Storm) said:

> YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
>> This part is redrawn on every redisplay even when it is not needed.
>> Could you take a look at and comment on the patch in the following
>> message?
>> 
>> http://lists.gnu.org/archive/html/emacs-devel/2005-11/msg00570.html
>> 
>> I've been using this for 3 months and don't find any problems so
>> far.

> The patch looks ok to me.

Thanks.   I installed the change.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Space between toolbar and window (Carbon?)

[Kim F. Storm]

storm@cua.dk (Kim F. Storm) writes:

> David Reitter <david.reitter@gmail.com> writes:
>
>> Can anyone give me a hint as to whether I can easily remove the extra
>> space between the toolbar and the window (see screenshot)? It varies
>> in size with frame height and line height and I'd like to get rid of
>> it. Where in the code would I have to look? Is this Carbon specific?
>
> You cannot remove it ... it is added to make the toolbar area height
> to be a multiple of the "nominal" display line height.
>
> The reason for this is buried deeply in the redisplay engine.
>
> I plan to fix this after the release.

I have installed some (less radical) changes to visually eliminate the
extra space between the tool-bar and text window for non-toolkit
builds (notably on X).

Actually, the limitations of the redisplay engine still exists, so to
eliminate the extra space the height of the tool-bar line(s) is now adjusted
to fill out the screen area allocated for the tool-bar.

However, I found that a little space (in the default background color)
is actually nice to have, so I've made a new variable tool-bar-border
so you can fine-tune it.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Space between toolbar and window (Carbon?)

[Chong Yidong]

storm@cua.dk (Kim F. Storm) writes:

> I have installed some (less radical) changes to visually eliminate the
> extra space between the tool-bar and text window for non-toolkit
> builds (notably on X).
>
> Actually, the limitations of the redisplay engine still exists, so to
> eliminate the extra space the height of the tool-bar line(s) is now adjusted
> to fill out the screen area allocated for the tool-bar.

The changes look very nice!  Thanks very much!

Re: Space between toolbar and window (Carbon?)

[David Reitter]

On 4 Mar 2006, at 22:35, Kim F. Storm wrote:

> Actually, the limitations of the redisplay engine still exists, so to
> eliminate the extra space the height of the tool-bar line(s) is now  
> adjusted
> to fill out the screen area allocated for the tool-bar.
>
> However, I found that a little space (in the default background color)
> is actually nice to have, so I've made a new variable tool-bar-border
> so you can fine-tune it.

Thanks very much - looks excellent now.