From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Raeburn Newsgroups: gmane.emacs.devel Subject: Re: Issue in src/xfns.c Date: Wed, 15 Jun 2016 00:16:33 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1465964251 30762 80.91.229.3 (15 Jun 2016 04:17:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jun 2016 04:17:31 +0000 (UTC) Cc: Emacs development discussions To: Christian Lynbech , John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 15 06:17:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bD2GV-0008DN-50 for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 06:17:19 +0200 Original-Received: from localhost ([::1]:39566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD2GT-00039U-Uf for ged-emacs-devel@m.gmane.org; Wed, 15 Jun 2016 00:17:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD2Fu-00039J-Vv for emacs-devel@gnu.org; Wed, 15 Jun 2016 00:16:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bD2Fp-0002dG-Tb for emacs-devel@gnu.org; Wed, 15 Jun 2016 00:16:41 -0400 Original-Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:36815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bD2Fp-0002dC-O3 for emacs-devel@gnu.org; Wed, 15 Jun 2016 00:16:37 -0400 Original-Received: by mail-qk0-x243.google.com with SMTP id l81so1224609qke.3 for ; Tue, 14 Jun 2016 21:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raeburn-org.20150623.gappssmtp.com; s=20150623; h=subject:mime-version:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=i+NPdTvTgxVc7cUYfU1exa5FZ1o6g/q4DKoXyuCynOw=; b=H1Jkfowhqk+RRup4jWTKCJpAehWLXjQ8WOB6DLDPUYoqcLbIcoN3yAHLaNAH3if6nI Sp2DP2O5CbuzqE+hLW45lPERXzkz0sRdBfnELjQWBJcarbc/T65rif8LiqEYWM0MvdJ1 OP9FxxNgZYVOH9t9Vz6Z3TgQHNoYHhK4RwgSTrYH/iyePZqZpMNJNyqtciFKLPewDrrX QGktmNG2DNYvuqxCUX0im5ncQntTVx0NG7EIcBsi5oThuO3O7Y85P7MmW6TQ09Fpog0Q PcpzVY1uVTjSy9wxCFUpkn4qlPzsGyCssU/+dElUQA86DSQsOgy4bH8nz6bd2XLdDyTB T4Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=i+NPdTvTgxVc7cUYfU1exa5FZ1o6g/q4DKoXyuCynOw=; b=Z9CbimzASY9/HX9tDtzlI27wSD3VIGDyy83+H2GhoH8lMOzbfthVavgdG2ecjoy56o QDBF5IXSqy3ZT2rombQI/w4+5Wkqb/kVhCt7RH1FDlYb6ThUdW1Qy3wYy0aWoM+NsvEM 91Zci4AhVN+4hxF6gPoJRUxy76sYwobVKHH/veKVU1+zmw0J593VUwbpKoqpFKUR4awO Xpmwaf2RfkRjzYmis1w2Wv8PiHGJIOuEYwou8OqvQDyoPDu1Qeg5bzPL0ZaexrdeM1he 4HHQPurjmsHEM6loTHZTnb4gSQCx/Fyy70dOnIUxO4uqucyG3K9RSwF9WSBGYEmbXdRL I5kw== X-Gm-Message-State: ALyK8tL/90lXR46iSoAvtwJtYFMrBLxp97yt/9uvCs9cLr93OeEeYsvzdQOHIrFAMGv5Ng== X-Received: by 10.55.204.3 with SMTP id r3mr24488488qki.45.1465964195799; Tue, 14 Jun 2016 21:16:35 -0700 (PDT) Original-Received: from [192.168.17.112] (c-73-149-21-156.hsd1.ma.comcast.net. [73.149.21.156]) by smtp.gmail.com with ESMTPSA id 207sm3901964qhq.26.2016.06.14.21.16.34 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Jun 2016 21:16:35 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204370 Archived-At: > On Jun 14, 2016, at 14:02, Christian Lynbech = wrote: >=20 >=20 > I am not entirely sure what the intention was, but I think there is a > small issue in xfns.c in relation to the RANDR13_LIBRARY macro. >=20 > It is used in two places, one where it uses #if and another that uses > #ifdef, the latter of which I think should have been a #if. At least = it > failed to compile for me on a rather old linux system with a setup I > know onbly a little about. The define that introduces RANDR13_LIBRARY = is > a boolean expression so RANDR13_LIBRARY is always defined. >=20 > As far as I can see this is still present in the git repository on the > master branch. An attempt of a patch is given below. Yes, this is a silly bug in my patch from March, present in both master = and emacs-25. Unfortunately the user=E2=80=99s environment that I made = the patch for had older xrandr support in the server but newer libraries = (on different machines, if I recall correctly), so it slipped through = testing. :-( Christian=E2=80=99s patch is straightforward and looks correct to me. It = should take a system with an older (pre-1.3) xrandr library to cause = compilation to fail, and I don=E2=80=99t have such a system to test on. John, you=E2=80=99re steering the ship again now, right? (I hope you had = a great vacation!) Most modern X installations shouldn=E2=80=99t be = affected by this, but as Christian shows, there=E2=80=99ll probably be a = few outdated ones that=E2=80=99ll be affected. Okay to commit this fix = for emacs-25? Ken=