From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Date: Sun, 3 Aug 2008 12:41:22 -0400 Message-ID: References: <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu> <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu> <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v926) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1217781716 5379 80.91.229.12 (3 Aug 2008 16:41:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Aug 2008 16:41:56 +0000 (UTC) Cc: Emanuele Giaquinta , Emacs Development To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 03 18:42:46 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KPgfM-0001Xh-F9 for ged-emacs-devel@m.gmane.org; Sun, 03 Aug 2008 18:42:44 +0200 Original-Received: from localhost ([127.0.0.1]:32915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPgeR-00026h-E3 for ged-emacs-devel@m.gmane.org; Sun, 03 Aug 2008 12:41:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPgeN-00026c-Bu for emacs-devel@gnu.org; Sun, 03 Aug 2008 12:41:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPgeK-00026M-KF for emacs-devel@gnu.org; Sun, 03 Aug 2008 12:41:42 -0400 Original-Received: from [199.232.76.173] (port=33953 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPgeK-00026J-Gk for emacs-devel@gnu.org; Sun, 03 Aug 2008 12:41:40 -0400 Original-Received: from wx-out-0506.google.com ([66.249.82.228]:4011) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KPgeJ-00048I-TE for emacs-devel@gnu.org; Sun, 03 Aug 2008 12:41:40 -0400 Original-Received: by wx-out-0506.google.com with SMTP id h28so512781wxd.24 for ; Sun, 03 Aug 2008 09:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-mailer; bh=QoUytA0sq7oIarCyAV2wOC9CQ2RQhMc9UA6lfJN4wU8=; b=hfGLgPzfQFPnODKHXI+0d3FAA86VkxI7DXMeWGcBsaht1zkWH97wKH8AnlEGfBOsRe r+fra0VF6pkypO6ebSG5KHLPHNif+q6Lgjtq1KgVp94FcqohYTWkXmIX6mPQoX7gnqso cCqwE5jtrSyAthPOtby1GkHoaG9RIn8jeBS7s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-mailer; b=YZr5jwlLE1C2L9xnwKVzv7LmxJzbBS4RzFN6G7NBEuFEnai/kOGKN52SwMUxr0/h2h q064J+gCI16KqewZN0iawUCXYBhFRFr21k5kJwGJYVfVA3WqXR/XhGUzU4eM+B0cOuyg iniMoEZVxbVCqArg2bAqehCMjbeffUkuDrLTs= Original-Received: by 10.70.18.11 with SMTP id 11mr16523143wxr.73.1217781699217; Sun, 03 Aug 2008 09:41:39 -0700 (PDT) Original-Received: from ?10.0.1.200? ( [97.73.30.9]) by mx.google.com with ESMTPS id h20sm13600849wxd.22.2008.08.03.09.41.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 03 Aug 2008 09:41:38 -0700 (PDT) In-Reply-To: <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu> X-Mailer: Apple Mail (2.926) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:101998 Archived-At: On Aug 3, 2008, at 11:59 AM, Dan Nicolaescu wrote: > This code in emacs.c is not right: > > #if defined (NS_IMPL_COCOA) > if (!initialized) > unexec_init_emacs_zone (); > #endif > > it should be done on all MacOSX configs. I've been looking at this, and made a diff of before and after remove- carbon to see what else might have been affected, since I never realized that the undef MAC_OSX wasn't working. > While at it, can you please get rid of -DMAC_OSX from src/s/darwin.h? After some discussion with other developers, I think there will need to be some kind of #define there, analogous to WINDOWSNT in s/ms- w32.h, GNU_LINUX in s/gnu-linux.h, etc.. MAC_OSX is wrong because it could be a non-OS X Darwin system. DARWIN is wrong because that is apparently defined by the system includes and/or compiler on non-OS X Darwin (see below). I don't think just the BSD4_2 that's in darwin.h is specific enough. I am thinking something like DARWIN_BASED_OS? > And also the -Dtemacs ? (AFAICT just using #ifdef emacs instead > #ifdef temacs has exactly the same effect) It looks like the entire C_SWITCH_SYSTEM_TEMACS is unused, but LD_SWITCH_SYSTEM_TEMACS *is* used, so perhaps it is kept around for completeness? I'll get rid of the line in darwin.h. > And please add documentation to admin/CPP-DEFINES for the DARWIN > macro. This is not defined anywhere in emacs, but there was this section in an earlier version of darwin.h: #if 0 /* Don't define DARWIN on Mac OS X because CoreFoundation.h uses it to distinguish Mac OS X from bare Darwin. */ #ifndef DARWIN #define DARWIN 1 #endif #endif Does anyone know where this IS defined? Also, I've been unable to find a version of CoreFoundation.h that makes the check referred to.