From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: master 44fcd37a486 08/11: Add more c-ts-mode indent tests Date: Fri, 6 Dec 2024 17:04:42 -0800 Message-ID: References: <173310542049.252624.8341603519407599366@vcs3.savannah.gnu.org> <20241202021023.5060A521787@vcs3.savannah.gnu.org> <87plm7zwqx.fsf@gmx.de> <87jzce7f6y.fsf@gmx.de> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30400"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel , Andrea Corallo To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 07 02:05:42 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tJjGP-0007mQ-Tv for ged-emacs-devel@m.gmane-mx.org; Sat, 07 Dec 2024 02:05:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJjFk-0004AI-Ar; Fri, 06 Dec 2024 20:05:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJjFi-00049h-BY for emacs-devel@gnu.org; Fri, 06 Dec 2024 20:04:58 -0500 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tJjFg-0000pt-Md; Fri, 06 Dec 2024 20:04:57 -0500 Original-Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-725abf74334so2295878b3a.3; Fri, 06 Dec 2024 17:04:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733533495; x=1734138295; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SAQrRdXgokEpd+Wq/nvZ7O2coAt4+nwKKspf20jibYQ=; b=GWYni4fw1as1HDEn8eiE40qSxxc9PA3gegNy74wLuAMKZFninjIafRUWj5ytxafZB+ EuQpSUx2Lmdo2/YvxH2k+N5bAjhmzjFemJc/Zkf/SsHBj71/gUcMFaL1gqzb2G80NJYf v3N9vRoMGExpvtVbCfRD9Xi06UFw4hVpO6wR5/vN2ETiDuW/kyKWdSA/gduiYs1uRKD4 HR5EiAvBDoSDZgtBb7tZKdmlOcKjqE6HjBJSwXsTInyEqo1LTW1GIgiN/txRzNXGIrW6 Hm2AiJVH6abGNpz2EycAotGRyyUHLk+pXGFAhd1F0ieYMR+kv5GId1LWitsWW8J8ZCG6 jHKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733533495; x=1734138295; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SAQrRdXgokEpd+Wq/nvZ7O2coAt4+nwKKspf20jibYQ=; b=s+vMAegFweNwZR1Gno0LjRB4btK6toUMWsS959UUm2ynA3XLVu1Ikx2NNriOlcpgA8 LBCJmVyvnCZ2Hb57yT0fv0Nnv10IMWzYRTS5CImSNNKwjPSD9qflNETyoa/mewyVIAJ7 jsKme6n6jREM4DZBkhFO1xNUydCQXtggR63Ga0U2WU3v36Ens/5RwLw2TffkujW8cErq uAVGP684z4i54DcJmdKjP6x+32Sdb3u/k5ufRddto4od0z4I90Rv50wfGeBVztHOaWOA PjvFnQv/i1hfIQVzeHDSf6CIHVz8TNyd+f7dRWfyPFjZydMPIJo/fq7OA14EsyNpdJh4 zRgw== X-Forwarded-Encrypted: i=1; AJvYcCW9gptQEeKScyf9+7kHIH90kGVaX6Mn3SkDn3DvfihpDuCSOHBiwQyiuY86QlMMOUEDxX8vrTf14g==@gnu.org X-Gm-Message-State: AOJu0YzPlNMLIkZfciWUmDm3hgfSHwo/ohXvBE1r+oWyO9QgP8it8erk /WxJ5Zaw53bFA4q6U2WesozDSyQB3qRcL8TBWNp1fHXeFeYp425ZwH0OpA== X-Gm-Gg: ASbGnctUihkMd7cfjDHjImTIDmdsbM/XebmEY/rmumgwmtDe3Uy3Z+YqHMwXmlUV1KG IYk0PfrnHm8J9QCSN0fiGKctLTPgbGQdQGzkactX4MjT8gs8NESbkX7vchcMxfZrI426G0I2HVW dQdfqc8zdYRffCfsDojJLsXw5UhNF62vaEhNO9koK+P5pq6wpVUvGmMsdfi6A6chLUJCvB2U08n K8j7iPa/PKZgHj/BFdG2/BbCoJSUUMIAvMDk3elCfjfJIMNQDohscbuSi3eicPFf28yB7bwQg== X-Google-Smtp-Source: AGHT+IEsFlrBNg2ElLYHxhLfZ+qmtaTP7+pElUomFoqxWoW1xMQRj5cqPbkeh3onH8IA/edSbbpiQg== X-Received: by 2002:a05:6a00:460e:b0:71e:7cb2:57e7 with SMTP id d2e1a72fcca58-725b811c65bmr7413720b3a.10.1733533494504; Fri, 06 Dec 2024 17:04:54 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:d59e:a328:96f3:f483]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725a29e9003sm3521459b3a.44.2024.12.06.17.04.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Dec 2024 17:04:53 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3776.700.51) Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=casouri@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326149 Archived-At: > On Dec 5, 2024, at 11:30=E2=80=AFPM, Yuan Fu = wrote: >=20 >=20 >=20 >> On Dec 4, 2024, at 11:37=E2=80=AFPM, Michael Albinus = wrote: >>=20 >> Yuan Fu writes: >>=20 >> Hi Yuan, >>=20 >>> This is baffling. I assume the pipeline build the latest >>> tree-sitter-c/cpp grammar right? I just updated my grammar and >>> tree-sitter lib to the latest and the tests still pass on my >>> machine. Is tree-sitter version also the latest? >>=20 >> See test/infra/Dockerfile.emba. The emacs-tree-sitter container image = is >> created prior every run, the treesitter grammars mentioned there are >> installed. >=20 > Ah, so the image uses Debian bookworm, which AFAIK is the current = stable release, so it probably doesn=E2=80=99t have the latest = tree-sitter library. Let me try to run the pipeline with tree-sitter = built from upstream. >=20 > Yuan I didn=E2=80=99t run the pipeline built from upstream, but I tried = running the tests locally with the tree-sitter library used in the = pipeline. The pipeline uses tree-sitter provided by bookworm, which is = v0.20.7, a pretty old version. And indeed, with that version of = tree-sitter I can see the test failure. Andrea, which version of tree-sitter do you have on your test bench? Since tree-sitter is still relatively unstable, maybe we want to use = upstream tree-sitter for the test suite? Yuan