From: Yuan Fu <casouri@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Emacs Devel <emacs-devel@gnu.org>, Andrea Corallo <acorallo@gnu.org>
Subject: Re: master 44fcd37a486 08/11: Add more c-ts-mode indent tests
Date: Fri, 6 Dec 2024 17:04:42 -0800 [thread overview]
Message-ID: <D4A9F039-580B-4DF4-8EDE-D2F7FBB6CB9A@gmail.com> (raw)
In-Reply-To: <F982D706-8371-440C-B679-6A52C35E0D5F@gmail.com>
> On Dec 5, 2024, at 11:30 PM, Yuan Fu <casouri@gmail.com> wrote:
>
>
>
>> On Dec 4, 2024, at 11:37 PM, Michael Albinus <michael.albinus@gmx.de> wrote:
>>
>> Yuan Fu <casouri@gmail.com> writes:
>>
>> Hi Yuan,
>>
>>> This is baffling. I assume the pipeline build the latest
>>> tree-sitter-c/cpp grammar right? I just updated my grammar and
>>> tree-sitter lib to the latest and the tests still pass on my
>>> machine. Is tree-sitter version also the latest?
>>
>> See test/infra/Dockerfile.emba. The emacs-tree-sitter container image is
>> created prior every run, the treesitter grammars mentioned there are
>> installed.
>
> Ah, so the image uses Debian bookworm, which AFAIK is the current stable release, so it probably doesn’t have the latest tree-sitter library. Let me try to run the pipeline with tree-sitter built from upstream.
>
> Yuan
I didn’t run the pipeline built from upstream, but I tried running the tests locally with the tree-sitter library used in the pipeline. The pipeline uses tree-sitter provided by bookworm, which is v0.20.7, a pretty old version. And indeed, with that version of tree-sitter I can see the test failure.
Andrea, which version of tree-sitter do you have on your test bench?
Since tree-sitter is still relatively unstable, maybe we want to use upstream tree-sitter for the test suite?
Yuan
next prev parent reply other threads:[~2024-12-07 1:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <173310542049.252624.8341603519407599366@vcs3.savannah.gnu.org>
[not found] ` <20241202021023.2C8B8521785@vcs3.savannah.gnu.org>
2024-12-02 21:02 ` master 63d69bd1549 07/11: Use new baseline indent rule in c-ts-mode Andrea Corallo
2024-12-03 0:38 ` Yuan Fu
2024-12-03 8:05 ` Andrea Corallo
[not found] ` <20241202021023.5060A521787@vcs3.savannah.gnu.org>
2024-12-04 8:19 ` master 44fcd37a486 08/11: Add more c-ts-mode indent tests Michael Albinus
2024-12-05 6:50 ` Yuan Fu
2024-12-05 7:37 ` Michael Albinus
2024-12-06 7:30 ` Yuan Fu
2024-12-07 1:04 ` Yuan Fu [this message]
2024-12-07 7:49 ` Eli Zaretskii
2024-12-11 6:15 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D4A9F039-580B-4DF4-8EDE-D2F7FBB6CB9A@gmail.com \
--to=casouri@gmail.com \
--cc=acorallo@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).