From: Steve Purcell <steve@sanityinc.com>
To: Julien Danjou <julien@danjou.info>
Cc: "David De La Harpe Golden" <david@harpegolden.net>,
emacs-devel <emacs-devel@gnu.org>,
"Bozhidar Batsov" <bozhidar@batsov.com>,
"Stephen J. Turnbull" <stephen@xemacs.org>,
"Jan Djärv" <jan.h.d@swipnet.se>, "Eli Zaretskii" <eliz@gnu.org>
Subject: Re: sRGB color support in NS port [PATCH]
Date: Thu, 26 Dec 2013 12:12:58 +0000 [thread overview]
Message-ID: <D335BB0E-0AD8-4FD9-850B-9838BE5DDD44@sanityinc.com> (raw)
In-Reply-To: <m2y538ymhe.fsf@danjou.info>
On 26 Dec 2013, at 09:45, Julien Danjou <julien@danjou.info> wrote:
> On Tue, Dec 24 2013, Steve Purcell wrote:
>
>> Agreed. So can we please enable the new sRGB option on NS by default, then?
>>
>> Colours won’t match between platforms with it disabled anyway, so there’s
>> nothing to lose in enabling it, and it would also help pave the way for
>> standardisation on sRGB across platforms.
>
> I also think it's a good idea. If you have a patch I can review and
> commit I'd be glad to do so, Steve.
Thanks to Jan’s work, it's just a matter of setting ns-use-srgb-colorspace to YES instead of NO in src/nsterm.m. Corresponding patch is below:
83c87170d77b1b8db17eb6a7c1f18d5e33d62e17 HEAD master
Author: Steve Purcell <steve@sanityinc.com>
Date: Thu Dec 26 12:08:20 2013 +0000
Enable ns-use-srgb-colorspace by default
https://lists.gnu.org/archive/html/emacs-devel/2013-12/msg00706.html
2 files changed, 2 insertions(+), 2 deletions(-)
etc/NEWS | 2 +-
src/nsterm.m | 2 +-
Modified etc/NEWS
diff --git a/etc/NEWS b/etc/NEWS
index 5aedab6..03ea2e4 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1248,7 +1248,7 @@ Customize `ns-use-native-fullscreen' to change style. For >= 10.7
native is the default.
** OSX >= 10.7 can use sRGB colorspace.
-Customize `ns-use-srgb-colorspace' to change style. nil is the default.
+Customize `ns-use-srgb-colorspace' to change style. t is the default.
Note: This does not apply to images.
\f
Modified src/nsterm.m
diff --git a/src/nsterm.m b/src/nsterm.m
index f2aef42..07f52c0 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -7648,7 +7648,7 @@ Default is t for OSX >= 10.7, nil otherwise. */);
doc: /*Non-nil means to use sRGB colorspace on OSX >= 10.7.
Note that this does not apply to images.
This variable is ignored on OSX < 10.7 and GNUStep. Default is nil. */);
- ns_use_srgb_colorspace = NO;
+ ns_use_srgb_colorspace = YES;
/* TODO: move to common code */
DEFVAR_LISP ("x-toolkit-scroll-bars", Vx_toolkit_scroll_bars,
next prev parent reply other threads:[~2013-12-26 12:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 17:41 sRGB color support in NS port Bozhidar Batsov
2013-12-20 18:04 ` Steve Purcell
2013-12-20 18:13 ` Eli Zaretskii
2013-12-20 18:55 ` Jan Djärv
2013-12-20 20:19 ` Bozhidar Batsov
2013-12-21 14:10 ` sRGB color support in NS port [PATCH] Steve Purcell
2013-12-21 14:59 ` Bozhidar Batsov
2013-12-21 16:16 ` Jan Djärv
2013-12-21 17:37 ` Steve Purcell
2013-12-21 18:10 ` Jan Djärv
2013-12-21 19:59 ` Steve Purcell
2013-12-21 20:26 ` David De La Harpe Golden
2013-12-21 21:11 ` Steve Purcell
2013-12-22 0:31 ` Stephen J. Turnbull
2013-12-22 13:55 ` Steve Purcell
2013-12-22 21:20 ` David De La Harpe Golden
2013-12-22 21:32 ` Jan Djärv
2013-12-22 22:41 ` David De La Harpe Golden
2013-12-22 23:52 ` Jan Djärv
2013-12-23 12:42 ` Stephen J. Turnbull
2013-12-24 10:56 ` Steve Purcell
2013-12-26 9:45 ` Julien Danjou
2013-12-26 12:12 ` Steve Purcell [this message]
2013-12-26 18:07 ` Steve Purcell
2013-12-20 20:21 ` sRGB color support in NS port Steve Purcell
2013-12-20 18:12 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D335BB0E-0AD8-4FD9-850B-9838BE5DDD44@sanityinc.com \
--to=steve@sanityinc.com \
--cc=bozhidar@batsov.com \
--cc=david@harpegolden.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=julien@danjou.info \
--cc=stephen@xemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).