From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: Pretest next week Date: Thu, 22 Jan 2009 16:23:40 +0200 Message-ID: References: <87y6x4ue2u.fsf@cyd.mit.edu> <87mydjv4bd.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1232634298 23569 80.91.229.12 (22 Jan 2009 14:24:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Jan 2009 14:24:58 +0000 (UTC) Cc: YAMAMOTO Mitsuharu , emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 22 15:26:11 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LQ0VU-000375-Nn for ged-emacs-devel@m.gmane.org; Thu, 22 Jan 2009 15:26:08 +0100 Original-Received: from localhost ([127.0.0.1]:52758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQ0UD-0001ou-0l for ged-emacs-devel@m.gmane.org; Thu, 22 Jan 2009 09:24:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LQ0TE-0001OU-Qv for emacs-devel@gnu.org; Thu, 22 Jan 2009 09:23:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LQ0T9-0001KZ-Tn for emacs-devel@gnu.org; Thu, 22 Jan 2009 09:23:48 -0500 Original-Received: from [199.232.76.173] (port=51811 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LQ0T9-0001KO-Gz for emacs-devel@gnu.org; Thu, 22 Jan 2009 09:23:43 -0500 Original-Received: from nf-out-0910.google.com ([64.233.182.190]:25641) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LQ0T8-0001OE-Nl for emacs-devel@gnu.org; Thu, 22 Jan 2009 09:23:43 -0500 Original-Received: by nf-out-0910.google.com with SMTP id c7so702519nfi.26 for ; Thu, 22 Jan 2009 06:23:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:in-reply-to:references :mime-version:content-type:message-id:cc:content-transfer-encoding :from:subject:date:to:x-mailer; bh=HeoPdSkghd/tnkkOO7ABX82YpLmC7kSxKc0kI7rgRRI=; b=kspCp3YRePaunhnuTQAexforgXu0LgI8YqbFuXfPOV2ShtYcLsUoO50jm/YGK8rmAb XR+3NfkpnCGiUcAPt6fL3yck26hnLhpjwvCcV1pJMpTuTrtE2uWpuhwodxjwFz1BHAqg dfK8NufZq5mjc8CSTZnt/Knn7cIMIWZ070OeE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=in-reply-to:references:mime-version:content-type:message-id:cc :content-transfer-encoding:from:subject:date:to:x-mailer; b=S7A3BArrYeKM1JRwdN6jKHMaxmIy5XUAhJcaHHyETMy4ApMalZx96FnEdW3SZ0ReNc 5a7w4F+r8VYJbCxnMhFOgz9q7U+BgCOVHo0Ku6bnDjjM9hLm2wyBhTahVppf62fc5KD+ 6LyMWYRh/e+JggltJT+sKcGxSZT+8LHbv8H38= Original-Received: by 10.210.34.19 with SMTP id h19mr11629421ebh.132.1232634221188; Thu, 22 Jan 2009 06:23:41 -0800 (PST) Original-Received: from ?192.168.1.101? (h054023.gprs.dnafinland.fi [87.93.54.23]) by mx.google.com with ESMTPS id h6sm25430647nfh.64.2009.01.22.06.23.36 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 22 Jan 2009 06:23:39 -0800 (PST) In-Reply-To: <87mydjv4bd.fsf@cyd.mit.edu> X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:108087 Archived-At: On Jan 22, 2009, at 3:49 PM, Chong Yidong wrote: > YAMAMOTO Mitsuharu writes: > >> Still the Cocoa/GNUstep port doesn't handle C-g properly. I think >> this issue should be addressed before the pretest because it is >> expected to require nontrivial changes in its event handling part. > > Adrian, could you comment? Thanks. Sure. I don't think "nontrivial changes" would be required. As I outlined earlier (http://thread.gmane.org/gmane.emacs.devel/105688/ focus=105694): 1) Complete removal of all Feval() calls in bad places as discussed earlier on this list. A quick check reveals four places, relating to: emacs termination, deadkey input handling, toolbar toggle, and preferences-help. - Mostly straightforward (but taking some time) by using custom 'nonascii-keystroke' events, except for the case of input-method handling when in isearch mode, where passing such an event breaks out of the isearch entry; I could use some help on this. 2) Go through the code comparing nsterm and macterm input handling to make sure all ctrl-g related processing is similar - I did this at one point, but it should be re-checked if problems remain after (1) and (3). 3) Make sure some kind of interrupt mechanism is in place to pick up ctrl-g events when emacs core is busy processing and does not itself make passes through the NS code event loop (colored spinning disk shown in gui). - I did some experimentation for (3) using a signal handler a while ago but something didn't seem to work, and some investigation is needed. I don't think major changes to the port event-handling would be needed since the issue is interrupts during emacs core processing, not inside the Cocoa processing. It should just come down to getting whichever interrupt mechanism worked in the Carbon port on OS X during emacs-core processing to be active in the Cocoa port. I would welcome help on this. Recently I've been spending the time I've had for the port on fixing the bugs reported by users (http://emacsbugs.donarmstrong.com/cgi-bin/ pkgreport.cgi?package=ns), so I haven't made any progress on these yet.