From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls Date: Tue, 05 Dec 2017 07:33:15 +0200 Message-ID: References: <20171129233237.27462.23351@vcs0.savannah.gnu.org> <20171129233238.504B5204F1@vcs0.savannah.gnu.org> <5d668ce5-1482-a3d4-c01b-7d996a532567@yandex.ru> <20171130214621.GA22157@ACM> <27985594-3bb4-ce88-8928-2ccfeac13eae@yandex.ru> <20171201154913.GB3840@ACM> <1e542021-e389-cca4-6acd-349efddb2652@yandex.ru> <20171201223529.GG3840@ACM> <4a94ec5c-efdd-50f1-ff4d-277f5f45c2df@yandex.ru> <83lgil1qme.fsf@gnu.org> <83d13x1j2s.fsf@gnu.org> <34abea95-c7f7-e8fa-8407-8c2fd2a4cfe1@yandex.ru> <83y3mkzw1n.fsf@gnu.org> <83mv2zzv7z.fsf@gnu.org> <83r2saxyj1.fsf@gnu.org> <83efoaxv0c.fsf@gnu.org> <57382399-5efa-655f-e374-fbe1ef9d89aa@yandex.ru> <27732BB8-B3B7-4489-963E-A09333026A8E@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1512452016 14372 195.159.176.226 (5 Dec 2017 05:33:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 5 Dec 2017 05:33:36 +0000 (UTC) User-Agent: K-9 Mail for Android To: emacs-devel@gnu.org, Dmitry Gutov , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 05 06:33:30 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eM5rD-0003KY-Bf for ged-emacs-devel@m.gmane.org; Tue, 05 Dec 2017 06:33:28 +0100 Original-Received: from localhost ([::1]:46539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM5rK-0003ej-5k for ged-emacs-devel@m.gmane.org; Tue, 05 Dec 2017 00:33:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM5r9-0003eb-Lf for emacs-devel@gnu.org; Tue, 05 Dec 2017 00:33:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eM5r6-0000XF-DO for emacs-devel@gnu.org; Tue, 05 Dec 2017 00:33:23 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eM5r6-0000XB-9o; Tue, 05 Dec 2017 00:33:20 -0500 Original-Received: from [176.13.229.231] (port=15802 helo=[10.133.154.105]) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eM5r5-0004Dl-LP; Tue, 05 Dec 2017 00:33:20 -0500 In-Reply-To: <27732BB8-B3B7-4489-963E-A09333026A8E@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220732 Archived-At: On December 5, 2017 7:08:14 AM GMT+02:00, Eli Zaretskii wr= ote: > On December 4, 2017 11:52:26 PM GMT+02:00, Dmitry Gutov > wrote: > > On 12/4/17 7:28 PM, Eli Zaretskii wrote: > >=20 > > >> The widening is done in indent-according-to-mode and brings into > > view > > >> the whole multi-mode buffer, indeed=2E Then MMM's > > indent-line-function is > > >> called, which narrows the buffer to the relevant chunk and then > > calls > > >> the submode's indent-line-function which hence only sees the part > > of the > > >> buffer it needs=2E > > >=20 > > > Ah, so this assumes that MMM is active in the buffer? If so, can > we > > > widen only if MMM is indeed active? Doing so will I believe > > minimize > > > (or even eliminate) the effects on existing behaviors when MMM is > > not > > > used=2E > >=20 > > That widening is for correctness when working during an interactive=20 > > narrowing=2E MMM mode being enabled or not is irrelevant (it's not the >=20 > > beneficiary)=2E >=20 > I understand that you and Stefan think so, but doing that > unconditionally > means these changes cannot be committed to emacs-26=2E I was > trying to find a way of squeezing them into the release branch, but if > you think there's no way, it's fine with me to have this on master=2E And btw, I'm not really convinced the unconditional widening is a good ide= a in general, even on master=2E I could probably agree that in most cases = it is TRT, but why would we _force_ all modes to indent with restrictions l= ifted? No exceptions? Not even a fire escape for some specialized mode wi= th weird needs and requirements? I'm not sure=2E It certainly should be d= iscussed, regardless of the MMM issues=2E