From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration in python.el Date: Fri, 7 Oct 2022 01:25:27 -0700 Message-ID: References: <3A68545C-2E40-4BB4-8563-8041A5452634@gmail.com> <87y1twlr0v.fsf@gmail.com> <83czb8ycpo.fsf@gnu.org> <87tu4klfcw.fsf@gmail.com> <87ill0le20.fsf@gmail.com> <87y1ttfmj8.fsf@gmail.com> <19950F30-F4DB-4CE4-9257-24DA39594669@gmail.com> <87czb47jya.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32874"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Matthias Meulien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 07 10:32:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogimd-0008Rq-9I for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Oct 2022 10:32:39 +0200 Original-Received: from localhost ([::1]:40164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogimb-0003G2-VT for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Oct 2022 04:32:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogifl-0007nB-Ia for emacs-devel@gnu.org; Fri, 07 Oct 2022 04:25:36 -0400 Original-Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:35449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogifj-000862-Rc; Fri, 07 Oct 2022 04:25:33 -0400 Original-Received: by mail-pl1-x636.google.com with SMTP id h10so3946710plb.2; Fri, 07 Oct 2022 01:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DIwKmsdwgomNdXEqJrHOeR98N9vZ3+t5VXzyg3fzBNE=; b=P8ig1pHQezk/I4X9QnYCyoZVCl15MAYyVMLUbB+xI294paJb3S9kVuXoH9Wv9KmCke PjTjg41AsTwppyyEd80qUkgTCuCxKA4wIBvLp7Mn375p47Ab5AAdub7vggpty+JcVa8j dFuh123+J0Bb2bORlg89cj9kobATog195ygfhfOkbdLW+dMhR4NZYpfk1Sp3Hj2PvTyJ Zv5m9L9Fx6BYVxWVOrzBRDa5VAf7sBeI+hE2XZMqGhXwf+lqPDUtzErezx0WGevBKHNL OmLbgdB9S3ecNHa8Z4tFXFC5qYnFaS0r8HBwoNw5IGEdwDqJj7kgh8Tg15qu2rZTRyZG /ySQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DIwKmsdwgomNdXEqJrHOeR98N9vZ3+t5VXzyg3fzBNE=; b=wIvzcTRrSk2wqIHxHZRHIP+FF/+k20+H36M2ReokbdxKFqd8XoNCbkGxUwTesRVkSD pgT2ypQu+rZ+h85K9/dEUfDTHnqnIxtRa4yq6Ft0oUU7Kj4q1PJDxzAiaNNpO3saA1aP XudFkbiOU7EmIZ8AVio9KH2nT3Yh6r9YLhb5dGQ31y1coVTfi3PA3zo0lDJ+y+/OYQgG D6Cu2oJEdzcqPAgWwkJct2BogQBPpK0GrLADsw4VvtHXgBJAxVkBecMDdhFynhJ4VGxV JmyKIiGbWgrjgeceT4PxqpIt9JUkAekbRfUMqTWulAipzqjP7E8DcYAihpmyjfdxgMMF pctQ== X-Gm-Message-State: ACrzQf2EywrPHwqlqTx7O0CHXCKWQdtN2YUw0w27FJ656GcJNJmJ6fkR ww00itxHqpPODX7SKSra4xE= X-Google-Smtp-Source: AMsMyM6x/Z/T6rr7hwN12u8ReyCpHEpojfCAYUl4GnWGSd6lCzl78ppPir1sahTNjnSTWALCQTDWzQ== X-Received: by 2002:a17:902:e88d:b0:17f:42f0:8d60 with SMTP id w13-20020a170902e88d00b0017f42f08d60mr3626738plg.169.1665131129490; Fri, 07 Oct 2022 01:25:29 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id w18-20020a170902c79200b00174be817124sm918186pla.221.2022.10.07.01.25.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2022 01:25:29 -0700 (PDT) In-Reply-To: <87czb47jya.fsf@gmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=casouri@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297141 Archived-At: > On Oct 6, 2022, at 1:53 PM, Matthias Meulien = wrote: >=20 > Yuan Fu writes: >=20 >> (...) Oops, I merged the master again and ran git clean -xf followed >> by make bootstrap, which compiled successfully. Something in the >> tree-sitter branch requires a git clean to build after merging = master, >> it seems. >=20 > Thank you, compilation is fixed. >=20 > I confirm that you also fixed the fontification problems I saw! >=20 > Would the integration of tree-sitter help to implement an option to = have > all types fontified? Now that it's becoming more popular to uses type > hints in Python code, it may improve code readability to have all = types > fontified. > --=20 > Matthias Yeah, with tree-sitter, fortifying types is trivial. In fact all types = should be fortified already. (I tested with some simple examples.) = Should we provide some variables to toggle fontification for different = things? Like python-fontify-type/f-string/assignment/built-in/etc.=20 Yuan=