From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?=C3=AC=C2=A1=C2=B0=C3=AC=C2=84=C2=B1=C3=AB=C2=B9=C2=88_via_=22E?= =?UTF-8?Q?macs_development_discussions=2E?= Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Mon, 6 Apr 2020 03:55:56 +0900 Message-ID: References: <83tv4mrn9i.fsf@gnu.org> Reply-To: =?UTF-8?Q?Reply-to=3A_=C3=AC=C2=A1=C2=B0=C3=AC=C2=84=C2=B1=C3=AB=C2=B9?= =?UTF-8?Q?=C2=88_=3Cpcr910303=40icloud=2Ecom=3E=0A?= Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="64767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , "emacs-devel@gnu.org" To: Jesse Medeiros Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 05 20:57:11 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jLASE-000Gk6-TG for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 20:57:10 +0200 Original-Received: from localhost ([::1]:50934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLASD-0000dZ-U7 for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Apr 2020 14:57:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36252) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLARB-00081E-3l for emacs-devel@gnu.org; Sun, 05 Apr 2020 14:56:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLARA-0008Da-4n for emacs-devel@gnu.org; Sun, 05 Apr 2020 14:56:05 -0400 Original-Received: from pv50p00im-hyfv10011601.me.com ([17.58.6.43]:50122) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLARA-0008CC-08 for emacs-devel@gnu.org; Sun, 05 Apr 2020 14:56:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1586112961; bh=urTRdUvujNDX8uCV1aNeYOk/B+iVZtFzEv9EPchFU7Y=; h=Content-Type:Subject:From:Date:Message-Id:To; b=DX3lXzVr/ScJBmDrGBJOJoj/dkNEgUir9OwwKCQarQ4xoUen2ovt+lP0JCQhFxaqq Av//YevAiKFhgAUwLCS27kuvVQdQ24EnJUirDKgG7Rc8megLPRcbXU9+99Zyzd4wKE E9fCTh42ZPjtVp94DSUbx0mD9jEqQ8WDCb1H0s0tJgD0d9ofguBoFcvLSsfT7REBhi VSebAD65Hbvw/QSgHgyyMYZuIrZnYlNQNxs1/XOY4d9G4BWGsRMs2Qp62Aq/bWlbM9 tLnjHmcjxclAAIQuEHSKiM7BIXCpqknqhb1f4dtLgEFUhhMyaWu7z+fk4NhxyjvD9C EAAUkvejFr0qA== Original-Received: from [192.168.0.2] (unknown [1.230.108.64]) by pv50p00im-hyfv10011601.me.com (Postfix) with ESMTPSA id 4BBFC380342; Sun, 5 Apr 2020 18:56:00 +0000 (UTC) In-Reply-To: X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2020-04-05_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=954 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-2004050173 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 17.58.6.43 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246480 Archived-At: Jesse Medeiros =EC=9E=91=EC=84=B1: > How can offer a copyright assignment? I give permission to do whatever = =20 > you want with this patch. I don't claim any copyright over it. Ping :-) May I ask whether you have signed the assignment? > On Jan 23 2020, at 5:22 pm, Eli Zaretskii wrote: > From: =EC=A1=B0=EC=84=B1=EB=B9=88 > Date: Fri, 24 Jan 2020 01:32:21 +0900 > Cc: jessenzr@gmail.com > > From 1302c040a23837b80a53416421914f3fe8ba1926 Mon Sep 17 00:00:00 2001 > From: Sungbin Jo > Date: Fri, 24 Jan 2020 00:56:38 +0900 > Subject: [PATCH] Add new variable for centering lines vertically. > > Co-authored-by: Jesse Nazario > > Most of the patch was written by Jesse, and we don't have a copyright > assignment for Jesse on file. We need that to accept this > contribution. > > + if (NILP (BVAR (XBUFFER (it->w->contents), > + line_spacing_vertical_center))) > > No need to use BVAR here, since the buffer whose window is being > displayed is always the current buffer when the display code runs. > > Thanks.