From: Serghei <egrep@protonmail.ch>
To: GNU Emacs Developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Elpa's GNUmakefile: process_archive
Date: Mon, 02 Mar 2020 18:09:56 +0000 [thread overview]
Message-ID: <CbcUQM8c5Bh5-7yspWdB7Ba4bKarn61MPs0R7S8V0CuaFOmq1qS0QA0Pf4G9PoQ6s34bQodwFfNvZQPOCqsVUcTk_mLa7iKdkSCMziO4Evc=@protonmail.ch> (raw)
In-Reply-To: <57f49954-976e-d4d9-786a-03945c6cc0c4@protonmail.ch>
Anyone?
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Sunday, March 1, 2020 7:49 PM, Serghei Iakovlev <egrep@protonmail.ch> wrote:
> Hello,
>
> I've noticed a bug in Elpa's GNUmakefile file. `process_archive' target contains incorrect code to exclude files from a package. There are positional options (`--exclude-vcs' and `-X') which used
> in an obviously erroneous way.
>
> Let's me show you the problem:
>
> % tar -chf bnf-mode.tar bnf-mode \
> --exclude-vcs -X bnf-mode/.elpaignore
>
> tar: The following options were used after any non-optional
> arguments in archive create or update mode. These options are
> positional and affect only arguments that follow them. Please,
> rearrange them properly.
> tar: --exclude-vcs has no effect
> tar: --exclude-from ‘bnf-mode/.elpaignore’ has no effect
> tar: Exiting with failure status due to previous errors
>
> I've attached the patch that fixes this issue. For more see [1].
>
> [1]:
> https://www.gnu.org/software/tar/manual/html_node/Position_002dSensitive-Options.html
>
> --
> Serghei
--
Serghei
next prev parent reply other threads:[~2020-03-02 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-01 17:49 [PATCH] Elpa's GNUmakefile: process_archive Serghei Iakovlev
2020-03-02 18:09 ` Serghei [this message]
2020-03-02 19:50 ` Stefan Monnier
2020-03-03 18:00 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CbcUQM8c5Bh5-7yspWdB7Ba4bKarn61MPs0R7S8V0CuaFOmq1qS0QA0Pf4G9PoQ6s34bQodwFfNvZQPOCqsVUcTk_mLa7iKdkSCMziO4Evc=@protonmail.ch' \
--to=egrep@protonmail.ch \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).