From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [External] : Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Fri, 2 Jun 2023 13:36:22 +0000 Message-ID: References: <875y8nks9t.fsf@localhost> <87fs7c10cq.fsf@web.de> <87v8g79zoe.fsf@localhost> <87sfbasr8m.fsf@web.de> <87y1l244hz.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15222"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Ihor Radchenko , Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 02 15:37:29 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q54y8-0003oP-9O for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Jun 2023 15:37:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q54xF-0000QT-1A; Fri, 02 Jun 2023 09:36:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q54xB-0000Q6-Qk for emacs-devel@gnu.org; Fri, 02 Jun 2023 09:36:29 -0400 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q54x9-0004Wf-3v for emacs-devel@gnu.org; Fri, 02 Jun 2023 09:36:29 -0400 Original-Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 352CYqx6005791; Fri, 2 Jun 2023 13:36:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=vJPehRvPqMWktHAgLdRuXcU2dXGgdpiEzKXmzT7FDEE=; b=Sn+gqPCnskK4ENX0SpS5Fhc8gWfOhLXVx0kZpSARCXd5CoFlPvwEBmaTx58f9/q4r7Rq CoJsn0/cjs0QO2X+Sq5ZNeEE2MRj7NdN1HJNOzkykQtU2f2d+/PY9ns47c90bRie8C80 sE3XSVLaQ5chDOcRfP28MX4o9tTHF3Z9+eFW4FTX2WYgg1YKiUzNmhYXevXg0FZ9FfBf Osbbn8sqhnIc6swl7yu8XeAwB5Ajr9jHClz1etrS2fR79PhRHzFRpUHGu6zLJaDmfq5C /CXcdttSXINnhAAK+5dje/ei9BcKBTUXDpCDwuDF4rkSogmtbCsifjUWQP76C3RpW5PX dw== Original-Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3qvhj52y1n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 02 Jun 2023 13:36:24 +0000 Original-Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 352CMGfa031794; Fri, 2 Jun 2023 13:36:24 GMT Original-Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2105.outbound.protection.outlook.com [104.47.70.105]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3qu8qd5117-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 02 Jun 2023 13:36:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RfBj4Y7rLZ5KisGPYnW8bMJ90LttjINlfQvmBuWzN+0oHOOeOXDnI9i2E89M18P61fNbqa6D71rwSdeARPYZ7CYKTwzEGMQFbvQJakw7qbTum2t0aoXtdI1WnprVymAVL6TJ97JpghMEHUrD6JPRs2Q7ZMYqVnHkZzxODWTe0bFcuDdpJODIaU81x1VDMqX8WHOnAACDHCwhLT4cqfyCEXs140hFTP8mw+wP6gkX9GWiXU54ig7cdUl8Fp4V6iDKZ0kxNsq5nO2h33C9dESCyhzD549aQ0EaEtBFxrHmqiWmg/LZBvS9dLldhW0flqxaEn1a21uoddCgPib2EchtXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vJPehRvPqMWktHAgLdRuXcU2dXGgdpiEzKXmzT7FDEE=; b=gPB5K1VJB2qNtBRadIP4yZzKtBSTSK4Mn/QR/BlXNSd3/n5GNYxukEffxzxgBJKgxx8qJIYr5ZKUjdylScG/r5aTg679wpDO+4ha/e95g05+BS1oBD8LQVKWYOsF0OIn9eX3iHwSO7RSJvHLj2XbOyYfxjGBncRbtYbgUpdIdnN0TGLv8/ZoXDdZRMQ6oy59OxmhkQE/vRmFjARZ3ab4cs6k4FtoizfPuUCJpBxDXpgTVftFtoNzJVfIxNODJ3A/VT/SZ7GmRuPY6r88x1wMTLOMqu0hdRM1WiJj3m3d0hJvcNbL0+y5Hr0NOPeB2D4iC6dOKwMqGvCS7axSLF/SdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vJPehRvPqMWktHAgLdRuXcU2dXGgdpiEzKXmzT7FDEE=; b=sCvoLfi/zL0LR4leQvZ8AjKFRlIIxbyng7khxANU0QubFQ62kPIOrHzbF9mhnFmCGh4CeQz1Xcy+lb5l7dZbEhe2flK+46Rblhrt2hk+PlsgQ7RvkaQ8fZ8uTYb5YK8jD4O2Mo7VIq7Fth62Iin/CSRmP69akwSkhAv483Yx3/s= Original-Received: from CO6PR10MB5473.namprd10.prod.outlook.com (2603:10b6:5:355::21) by CO1PR10MB4675.namprd10.prod.outlook.com (2603:10b6:303:93::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.24; Fri, 2 Jun 2023 13:36:22 +0000 Original-Received: from CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::ff66:212b:c121:642b]) by CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::ff66:212b:c121:642b%5]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 13:36:22 +0000 Thread-Topic: [External] : Re: Is it valid to call isearch-filter-predicate outside isearch? Thread-Index: AQHZlTEdbwW3pPv+Q0Gn2PEf37ZYjK93gz5w In-Reply-To: <87y1l244hz.fsf@localhost> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR10MB5473:EE_|CO1PR10MB4675:EE_ x-ms-office365-filtering-correlation-id: 6a772e4e-6417-40f7-614e-08db636e5b01 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J1a2w7Xmk1jhfcrUpI6pk5nSXi0m8rqy2vySNs9Rb8lx2PDKG0meRKh7SuBQNlz0GbhIOs83vok9rpTLsl9Eyw9W+srX8Nj+Pc3cvJtFcmvx5YfNTH6aTZ/0Z7RXg8KXOrypo7Sxcyf5gPxHxgpZVzvuBanu/LgDY1Jb1rZubvi7DjzUwaUhmXmiWMtt+V3yalswpeZoXrDlW12ga9XVjdixjw4h6ckw6KXx/EGTyFo8jjYqt219xtzuxLnjL06ymOD94SuAjlGf/PIx7hne9G12ogsi28M9xi6GxDn5sy711ecJv8OXmXTNX6JVh9DQZvyWWHkp/nYAqQ8Cuo42+l9Ct7mMSC3lAoTo4xjralR+LYaWKLvNWV4dRv4+ay1vKjKK04kVcB/ip9Cgj8qFKVGWkaF0xJQJURTH16llO6aoNxJNU8pbyDroO+M6hpRSc8g4RAu47+AxZWgD+mQv2tUaggOWnzqdWWdQUrLoUD69mdw4izAd8vV7UhSqbZLnDotOAMy2zz06fRbMLq9M0+JWNsOnCs4Ml1jIxd4HYgsplDmUTJhUwAYUv3bjpgep+96JO5NhYVd0SO4wN53vTJ/HL0H6tzSFuUUncNsgBgBVZlWdtnv9w5/+uodC4s4s x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR10MB5473.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(346002)(366004)(376002)(136003)(39860400002)(451199021)(8936002)(44832011)(316002)(5660300002)(41300700001)(52536014)(8676002)(110136005)(4744005)(2906002)(478600001)(76116006)(66476007)(4326008)(66556008)(64756008)(66946007)(66446008)(71200400001)(7696005)(122000001)(33656002)(55016003)(186003)(6506007)(26005)(9686003)(86362001)(38070700005)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?27z0j2ykfsIISdOvdfNaNzatS/rM4o+Wuk/gxym5I6Cdwz8mGjE7b/KMu/hw?= =?us-ascii?Q?5azPASgSfrteEPVSG18TcLGaiVNsrcPIu8JZWSOopFpOoDjRTU1QjLBjd0b9?= =?us-ascii?Q?XTbVzhWivP/yPzL7y/G50acSHvpf5QkhgbarA12Mtw7juiPR8rah7doJDSSe?= =?us-ascii?Q?1D4SjNDKB2fx6TFCMg8Lq/RxkwmnhwZ9nnmUET+xHsmLbHxAeOLHvpp5U8OM?= =?us-ascii?Q?vG46VmOmn/3dwsY6M1+ENz0gt78IdHmsvJXXoNYQzoNbnN8u/6K5MVuQYxdH?= =?us-ascii?Q?VOQWbJDC4dPNBrc/ecVI6vMGJxp+2h167x/0h3etit5nBd2EmFbmtMl63br2?= =?us-ascii?Q?dWpX1g47Rzy74+oNcNEheFE7YFNitDkVQKuPOmxqVuMNN4b/Qk3d1ENZywKn?= =?us-ascii?Q?DyhBFH4wallknaBqnB7FY1vvKZfNgy5l3cSnIONHhydJ6soRqJYqLSx2YHs6?= =?us-ascii?Q?8onAr7WX+J3Dy5Z0TrcVXhMXG8K1VpSUtxd02VYXj04gc/+9KO9ZBfOYAAHQ?= =?us-ascii?Q?tfPiHxasziIeVaCQD3m+7Yo90m8kxn00gPtuPLGQ1jnEs8+Dxud1YGYd0XpW?= =?us-ascii?Q?EM18xAL2vRN6oCInmpgBLbfFkfCvRb3ututTO6LksvQm104JLkZKOaTEVnco?= =?us-ascii?Q?0A X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gCnHf3QgqaEAuOMRK6cq8c7ii2MruLLQdyQNewKDiLzqE7qE1E+EfHdOr4dQnDiLtRBhto7E/ErbGWibsJsE0hJw6Y+or7VuMwhcTzJbUz7fUp9Iyu21/CvVFERp0EnWxBJSlKBoiTL7w0eZ630mJB8gTy3xuMfzcKgfFTgH0YO9m7xEK14j8IVDDzHp9lHdxmOj0WrTOrIhm+ygOouTFAPuDH9sTewk8uUpehuq2+s9SMYnBSFTUYUL58Lq47763V6p0CzCraqYiU/4Obe2Um3zdx04Zl5Z6VUXaO0AHvkdfVIHW+cjbWMDYgUG+M9pBuVv+Mds9gYCDk8hi8SWoIHNC1fISoGgl19J67JzuUkhJ8kwKg/K7NI9/ZKcfQynaqpzO5ct64fCLaYFuIxJPmOYt/B35XMCOp395oVN92LRmBJ/kyqrrbW9e4SbflszCUuUVECsL5aZvUVRj3JYF/m4JwizTf22QWBFLy/CreaTmgvZJxVmtFNgt2fR3xvCXeEx8t2yXkaYwR/5Hmf9mWKLZ5AAYMnp626PT98myXIpv1JQYOkaXVTPzIOyFvhukqt31Uo1JKo638Tdxs95pfE/rz/n5peaXhKMrzZTij+Bd4IIddr6HOghnzceq21mp8ehXWExQI+McEd7KqIsTewj/qKdnIMaSf2aDcNPDHuhx7+C+ghooS9ECWnTnqkv6N8qTsvfh1b93x/62i2lvTOaE1jM+U1UCOJhXyLxxZcAUq ow6y9QHfTySQp0KwaU96dPUCSgL5TJV2y/1/g0HhqL1fLTNF0z0qvXbzA+/fI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5473.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a772e4e-6417-40f7-614e-08db636e5b01 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 13:36:22.6911 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hix6pUeJsN+8ooeO/HAsYyfPNG6nD5yOUrWK5MXPZaVPfvSPlDExcM2RXsovaHbgkBvZ5P7tNYKNXCR78zZdLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4675 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-02_10,2023-06-02_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 mlxlogscore=737 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306020102 X-Proofpoint-GUID: EXkGBGGprwjFkAZEAOGWZ6ApcG8O9XZ7 X-Proofpoint-ORIG-GUID: EXkGBGGprwjFkAZEAOGWZ6ApcG8O9XZ7 Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306555 Archived-At: > Do you refer to > (add-function :before > (local 'isearch-filter-predicate) > #'foo)? >=20 > Two reasons: > 1. I only vaguely understand how this works > 2. It feels against the interface. If advising this predicate is > expected, why not convert it into an abnormal hook? Caveat: Not really following this thread. Might be misunderstanding you he= re. Wrt #2: A hook doesn't provide the same flexibility as advice, e.g., before= , after, around. (Wrt #1: Yes, advice is trickier than hooks.)