From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [External] : Warn about comparing quoted lists (etc) using `eq` Date: Wed, 14 Dec 2022 18:57:05 +0000 Message-ID: References: <8D624413-5A6C-46D7-A4EB-53C23F7CC4D3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8137"; mail-complaints-to="usenet@ciao.gmane.io" To: =?iso-8859-1?Q?Mattias_Engdeg=E5rd?= , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 19:57:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Wwt-0001uI-Hw for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 19:57:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5WwQ-0006vP-KR; Wed, 14 Dec 2022 13:57:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5WwM-0006vA-A6 for emacs-devel@gnu.org; Wed, 14 Dec 2022 13:57:14 -0500 Original-Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5WwK-0002XG-Rn for emacs-devel@gnu.org; Wed, 14 Dec 2022 13:57:14 -0500 Original-Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BEHE4Al019573; Wed, 14 Dec 2022 18:57:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=CJbfrSFWOnIryCqCtX/WdUzi9MwQHxPmcjCDCNm1FRQ=; b=vFPdkTjARyK9D9+PEEEMr1ht/ib81F7ePT6U9u5CbY/AqqmQ7Fk2RjFLpGgoY8TyAKXl IMvM5eL07bIES7FAV2U3qwvoZxySpzBCSNoEDUHNO/gl2E0bOWzbYLmomMglootrYwVH 1ETcWqBBGLZtl0FH6yjTzfKoZHVZ0SFBBPss0BrmFEGAw6LCMWIyi8+UwlwBZt+BKePr ttmQmUEyxfLi+QMxdqUB6D7OWZrLkgG7/qbB9zpOamNTMhWydU6XPa/WOCdIPr5VNbmk NWsXYmeq5gPsG1GnRlqQNZbpuygIOlU1Uka8IWy+fk0TPW9UGTJnWvTZlnLXCbw8ULkT 6g== Original-Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3meyeru30c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Dec 2022 18:57:08 +0000 Original-Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BEHNf5F007161; Wed, 14 Dec 2022 18:57:08 GMT Original-Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2101.outbound.protection.outlook.com [104.47.70.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3meyeq940k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Dec 2022 18:57:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ni61tu3kM9Txwa1WQHXIPPA9NZi1xeALEjdRdZlCS2xC03WWsNDwWLb1JiNIHRw384V25TNgv8Tlrk1AexgIp2ax8flp7LdeH7uqfDnbYxJvGmrgz3QcnjUaawk01w2Z9WNY+3UGX5MERyH9Tl9rcUZ+PnxrrlIifEbhV6l9vRaO0JKih6wjyVJ1o1ZJWiS4lNaNN/t5N9I6anlDp7x9nKxJJaaBXCGqCUt4ZWRJySf1OgB69aDVYrGwIW5jbEVYUJaUgk2NF7XmSccRc5ItaW+E+lVAEfHevzekuHTMna/hrNjm+mvf13pMDLINFdKixZHEgI7ksO8+I+cCZsOpaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJbfrSFWOnIryCqCtX/WdUzi9MwQHxPmcjCDCNm1FRQ=; b=G0JULIcyvG+Lmv4DGPop8TY2q43bhIJ6y/xIgFgmMz//cqkT5nsLv3UPLx5bv/G7mUzMFoEZgL7wCDAXHURyWPjkc3Z3feZj2SG7KgHrNlRS/LbdeWKFHzGrv2xUUozb90aoWkQi8hZ04razwgCE9r2vsGSh0rd4bvuS31UmaBNBTw9cQbuH8wTNTb4nSCMYSMkhHQ+AmyVQwK6ndBsT+1bKvLRjiPfDGW1JA4eZtW4vpLqTzxWzl5Fg/fGcdOqeaueAULTLOmNiCyC8+Caw/qKvFU/tMc3SojnINO7TZtj4SGGV/aaxX62lDm87PYy7n1HCWZiiloDYTPJMiPKdeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJbfrSFWOnIryCqCtX/WdUzi9MwQHxPmcjCDCNm1FRQ=; b=OH8JQ+qUhltz/THYbVacsyORr5y2vhg69vfPEtDe+mBLPW0CLw3SDL39WwFjiZKwMhd/pfN9F15NWbSl1/3Y1qNlSJXbLcPGmMYEyrHq3M4V/rN4IHlJY23Q6aZNOtkkZlCJx8Sjz+SZVhebqiZwnowfs/M6jQCrpjLEFbenhEc= Original-Received: from CO6PR10MB5473.namprd10.prod.outlook.com (2603:10b6:5:355::21) by DS0PR10MB6152.namprd10.prod.outlook.com (2603:10b6:8:c4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 18:57:06 +0000 Original-Received: from CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::59af:ade8:1aa1:3ec0]) by CO6PR10MB5473.namprd10.prod.outlook.com ([fe80::59af:ade8:1aa1:3ec0%7]) with mapi id 15.20.5924.011; Wed, 14 Dec 2022 18:57:06 +0000 Thread-Topic: [External] : Warn about comparing quoted lists (etc) using `eq` Thread-Index: AQHZD+mDud9aLiVR8kK41PXIcYrXQq5tu2wg In-Reply-To: <8D624413-5A6C-46D7-A4EB-53C23F7CC4D3@gmail.com> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR10MB5473:EE_|DS0PR10MB6152:EE_ x-ms-office365-filtering-correlation-id: 38cf0d0f-e54e-4e8f-5a09-08dade04feb1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PrUeCwUuzoxvOekhJ+s+rVC0SyERgUkMoDWTrqYN4v+j41v64CtE9rsvfR6kpKue/s8rbqKUu5s5/FsLuztN7aBm4ETAp/8zZGJHjTrgOtvgrfEKgr2BpPGuSdiHfJuA0IGEA7hCiP4HlojPZnRRUJg03YLfNzhaghu0Hz2RswQaXp8svQ+2A8tDahr2k7VPBOaCGXj6dojtkY8UW17civQO3CJQPk2Mvjs4GUpKGXd9Kmabkge7OLmeb3w568Yzx5vaBiDUhv0CcDDSnB0Dk493FdPBy1MYpQInoqOO53Vl66kmDVRoZ8NLDAnJ1g1qjOxc+e6TtfWd53s7VQWG8ky0k/T1/YCeqF3PNRgwozde0pJkhY9K2F20uL5j09ftsqw01QNCPpzTX1XFWUzk3NrbI1z2DELjPKkrEQeyMsVOmPEHPwuR1Z4ui0gXtyv+t6wlEG/bJ49jZSbwLQP4bdf1W3218eVlOJY2SfKfOO3dyidETD7dac+L4mwU1HVxUPqzWfReHwMJkuOUX7BRmWlUWLWNS1Lbe2S+mklP8oQIoX7JtdbPSSEvuMJKI9XOvcnxXVheQRZGRQSJefda84U7bROFaYNeesKcodJMCrk/ELDgPIzDYndB+2AqxIH2QYMR1odmvjX+TdxqtnpOj56kEWqoWDyMWtpEbRfJLOMFmTjG8QWN8CCNEx1dVoUhHeIze837rCXzoJOk6GQ+SwKbvMucocvxiWdvKmGLC1Y= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR10MB5473.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(136003)(396003)(376002)(39860400002)(346002)(451199015)(8676002)(66946007)(66446008)(64756008)(66556008)(9686003)(76116006)(66476007)(5660300002)(41300700001)(83380400001)(6506007)(38070700005)(8936002)(52536014)(33656002)(478600001)(186003)(71200400001)(110136005)(26005)(86362001)(7696005)(316002)(44832011)(2906002)(122000001)(4744005)(55016003)(38100700002)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SV6ZSxnt1WzVO6QUbZehvE/5F+QO3ONj9F/SSTF+y7HXkTlVUyZV9r7Wf5?= =?iso-8859-1?Q?HpPP5GBtqvXKcrUSo/ZfxjFHrbD27rHmRONcU12Z2Wee7h1tFpooeVveb1?= =?iso-8859-1?Q?2COtgK2XL85l9PGc4+TrtuCwQ5coSy72izIhuHWnmFg2FTL5FkEX5XlBTp?= =?iso-8859-1?Q?flyeKfmCMLLzT3lYAyGkQ8n0tsq986apPvp1NCkFFi9UcCYsxpGtkaiSg0?= =?iso-8859-1?Q?1sET8Cr0dWSWYK1rsy6E4aQVv5lyH3HRUVhX97//28RTcmke/HJwOL2gug?= =?iso-8859-1?Q?hI5KoGZbdxqOr8OCen14QNvhjmmsNmx+j9ZipiN9gHyYZMjvi6dLR8UIHi?= =?iso-8859-1?Q?UFwPaOzkn1LgI6UpSfehX5KW2J5IuOEJ/pNJCj+Z8EJI1PduMyGo/7orhO?= =?iso-8859-1?Q?Um8FNYMfzud9Kr5SlGT/xfmRsKFRZVolyhnMm2+gLQPQlPZ9NYtor87Rk+?= =?iso-8859-1?Q?cIXNUd8EhPOC9CWYa4OIopvsWQbSeHwD7dSRIAJ1PNKdG/mnYw8jbbAwW2?= =?iso-8859-1?Q?CGqsTXVo39NVLeXHJhKAss66bYrFUyrkVYu/38l2FBsUgIZpQP7vSUus58?= =?iso-8859-1?Q?GQHf1QAmiE9FW5lQ1iSEgDwS9j6WlRcbnKZgaSb0+L7ylyGJB5YALmUGnw?= =?iso-8859-1?Q? X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5473.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38cf0d0f-e54e-4e8f-5a09-08dade04feb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2022 18:57:05.9992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3miMXPFzm0UkIHh5L+dctXRu8jzL7rf6ZCiBNXAdxEejjkvqcmvcSa8OGr2GIoG449tsQrmOuxGCWDtGkpq0gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6152 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-14_09,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxscore=0 mlxlogscore=791 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212140154 X-Proofpoint-ORIG-GUID: EbNqeQvxs6Md7rZtA16T8uDCpHdAxC_e X-Proofpoint-GUID: EbNqeQvxs6Md7rZtA16T8uDCpHdAxC_e Received-SPF: pass client-ip=205.220.177.32; envelope-from=drew.adams@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301405 Archived-At: > I'm about to push a new byte-compiler warning that finds mistakes like >=20 > (eq x '(ho hum)) >=20 > Ie, attempts to compare, by identity, literals that may not match > anything at all: quoted lists, strings, floats etc. The warning could perhaps remind users of `equal'. It's likely that in at least some cases what they really meant was (equal x '(ho hum)). And `equal' takes care of all types (strings etc.).