unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Pip Cet <pipcet@protonmail.com>
To: Fejfighter <fejfighter@gmail.com>
Cc: "Po Lu" <luangruo@yahoo.com>,
	emacs-devel@gnu.org, "Gerd Möllmann" <gerd.moellmann@gmail.com>,
	"Eli Zaretskii" <eliz@gnu.org>
Subject: Re: scratch/igc 7057c3562ff: * src/pgtkterm.c (mark_pgtkterm): Exclude from MPS builds.
Date: Tue, 23 Jul 2024 05:34:06 +0000	[thread overview]
Message-ID: <CLEWgX-FtNQmfe_fhmoptkPZCpBPgK1CCqF1dP0I1TTbdn95rDY0P5DmqI-Zf_7nx3vNYjiNi2QUikzGBZkugbqglV5SsayMKvgruyv9EN0=@protonmail.com> (raw)
In-Reply-To: <CALohuRDSiYhwg4E5ok5qtGK2mE1o8vDhnOwc0oRE6h6L644+BA@mail.gmail.com>

On Tuesday, July 23rd, 2024 at 05:12, Fejfighter <fejfighter@gmail.com> wrote:
> Comparing to xterm.c and scanning other parts of the pgtk specific code I only found this as the only allocation unique to PGTK as much of the things xterm needs to worry about is managed by gtk.

Thanks!

> Could someone apply this patch to the scratch/igc branch please?

Will do.

> I also ran the benchmark suite with the latest changes and it's the first time that it has not crashed emacs/oom'd out or otherwise destabilized my machine,
> It is starting to appear to be more stable for my use cases

That's great to hear! Running the benchmark suite should, of course, work. However, performance can be improved a lot by playing with the relevant parameters, so the result might not be great yet :-)

Also, there is a stability issue caused by signal handlers, which is fixable. All the crashes I'm aware of that I haven't found another reason for are due to that...

Pip



      parent reply	other threads:[~2024-07-23  5:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171946868539.21672.18232144356511203768@vcs2.savannah.gnu.org>
     [not found] ` <20240627061127.3F4BCC1FB5B@vcs2.savannah.gnu.org>
2024-06-27  6:17   ` scratch/igc 7057c3562ff: * src/pgtkterm.c (mark_pgtkterm): Exclude from MPS builds Po Lu
2024-06-27  6:51     ` Fejfighter
2024-07-23  5:12       ` Fejfighter
2024-07-23  5:34         ` Gerd Möllmann
2024-07-23  5:34         ` Pip Cet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CLEWgX-FtNQmfe_fhmoptkPZCpBPgK1CCqF1dP0I1TTbdn95rDY0P5DmqI-Zf_7nx3vNYjiNi2QUikzGBZkugbqglV5SsayMKvgruyv9EN0=@protonmail.com' \
    --to=pipcet@protonmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=fejfighter@gmail.com \
    --cc=gerd.moellmann@gmail.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).