From: Vince Salvino <salvino@coderedcorp.com>
To: "rms@gnu.org" <rms@gnu.org>, Po Lu <luangruo@yahoo.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: Dark mode on Windows
Date: Wed, 27 Oct 2021 16:28:31 +0000 [thread overview]
Message-ID: <CH2PR12MB4231329B8473A48CCED9573AA5859@CH2PR12MB4231.namprd12.prod.outlook.com> (raw)
In-Reply-To: <E1mfk2U-0002ea-Km@fencepost.gnu.org>
> For instance, Emacs could define a system-independent way to specify "dark mode". Perhaps using an environment variable. I'd expect that to work on all systems. If a system has a conventional way to specify this. then Emacs should recognize it.
I agree this would be a fun feature, so that users could then customize their own configuration around the system variable. However this particular patch does not add any new features, it is simply making the GUI on MS-Windows more consistent with the other supported window managers. Users of free operating systems already enjoy this feature :) For example, in Emacs 27.2:
* GTK: Changing the GTK theme (e.g. adwaita to adwaita-dark): the title bar of Emacs GUI is now dark, following the GTK theme (controlled by window manager).
* macOS: changing the system preference from light to dark: the title bar of Emacs GUI is now dark, following the macOS system preference (controlled by window manager).
* MS-Windows: changing the system preference from light to dark: the title bar of Emacs GUI remains white, even though the system theme is dark (the window manager requires opt-in from the program to respect the system preference). This patch fixes that behavior by providing the necessary opt-in to respect the system setting.
I will try to make a second patch following your advice, independent of this patch, which exposes the system light/dark preference to Emacs, via a variable, so that the user can read or write it at their pleasure. This is going to require knowledge of all the various window managers supported by Emacs, so help will be appreciated!
Vince Salvino
next prev parent reply other threads:[~2021-10-27 16:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 22:27 Dark mode on Windows Vince Salvino
2021-10-25 1:17 ` Po Lu
2021-10-25 1:22 ` Po Lu
2021-10-25 3:25 ` Óscar Fuentes
2021-10-25 4:32 ` Po Lu
2021-10-25 12:31 ` Óscar Fuentes
2021-10-26 5:02 ` Po Lu
2021-10-25 4:14 ` Vince Salvino
2021-10-25 4:27 ` Po Lu
2021-10-25 5:20 ` Vince Salvino
2021-10-25 6:25 ` Po Lu
2021-10-25 12:37 ` Eli Zaretskii
2021-10-25 15:44 ` Vince Salvino
2021-10-25 16:34 ` Eli Zaretskii
2021-10-25 12:15 ` Eli Zaretskii
2021-10-25 13:17 ` Eric S Fraga
2021-10-25 9:59 ` Alan Third
2021-10-25 11:55 ` Eli Zaretskii
2021-10-25 12:22 ` Stefan Monnier
2021-10-25 12:52 ` Eli Zaretskii
2021-10-25 16:52 ` Michael Albinus
2021-10-26 2:04 ` Po Lu
2021-10-26 12:10 ` Eli Zaretskii
2021-10-26 13:35 ` Po Lu
2021-10-26 14:11 ` Eli Zaretskii
2021-10-25 13:02 ` Óscar Fuentes
2021-10-25 13:28 ` Stefan Monnier
2021-10-25 13:56 ` Óscar Fuentes
2021-10-25 17:20 ` Stefan Monnier
2021-10-26 0:56 ` Po Lu
2021-10-26 1:08 ` Óscar Fuentes
2021-10-26 2:02 ` Po Lu
2021-10-26 12:09 ` Eli Zaretskii
2021-10-27 0:36 ` Po Lu
2021-10-27 12:02 ` Eli Zaretskii
2021-10-26 12:08 ` Eli Zaretskii
2021-10-27 0:37 ` Po Lu
2021-10-27 14:36 ` Richard Stallman
2021-10-27 16:28 ` Vince Salvino [this message]
2021-10-27 19:49 ` Óscar Fuentes
2021-10-28 6:19 ` Eli Zaretskii
2021-10-25 12:42 ` Óscar Fuentes
2021-10-25 15:45 ` Vince Salvino
2021-10-26 4:29 ` Vince Salvino
2021-10-26 7:32 ` Po Lu
2021-10-26 14:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR12MB4231329B8473A48CCED9573AA5859@CH2PR12MB4231.namprd12.prod.outlook.com \
--to=salvino@coderedcorp.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).