From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Newsgroups: gmane.emacs.devel Subject: Re: Some minor suggestions to Tab Bar Date: Wed, 24 Mar 2021 21:47:23 -0300 Message-ID: References: <87mtustidk.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 25 02:03:16 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPEP5-0007pT-9Z for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Mar 2021 02:03:15 +0100 Original-Received: from localhost ([::1]:57092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPEP4-0008Rq-8U for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Mar 2021 21:03:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPEOR-000802-80 for emacs-devel@gnu.org; Wed, 24 Mar 2021 21:02:35 -0400 Original-Received: from mail-oln040092003101.outbound.protection.outlook.com ([40.92.3.101]:50278 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPEOP-0001R0-Lv for emacs-devel@gnu.org; Wed, 24 Mar 2021 21:02:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJFJvD/esGSqO8OAB6zW+mOVCymXWZapvElAqs5CigYeSRPBCG9T49BEdOl0SZCS4Rhqasn6oR+a4fWxal80TZSNfLM9hDC50wdvG091cuOM2uh5bqUgXor4MVzzIaBA9isNhTTg7iAgdInNUOuLlF086i6a/py1YsokMr3QSm3U6JvzzSwhZCT5Qz8vYyKRGUXi17li4GiIg+BpMu87bA/iNqayJlixITNRAhIuzjjdclq1ROryoUBjRJI+tNAV6D5GhbcGwWYb9OIOue5P/a+nBaC6VXM6tgJRb8MZVbduKdR4LhztP8j8YxPwORnj1X0gWA8mMays89Tyr0LTHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLTT/xxPA2Ak/1qNXb1qU2GBi+gkhy9KrXouIN5umlc=; b=kyD7Kg22aZdUh3dEVe7A990JmAlmvjN8nS+u3SyvEn96KQtQqRe/8BlVx2AFnbO/d0rxbHgqJzjGWsxPWNWjF7E7c8tIostqlclsquVLGlBJrajxnyFm8UA4/S9CUS/7EUOr/SwAFZKGhCrXGjxrMY7tghLlC/iZYhoKD1i2srsGlIYscIMtH5uZdFQd0akessn4cbhF2zk3valpKlq5Nd7ZRK/3SK1YJV9b78iU1G6F18Vqn2S5uPWjbbqeX0t72VrckCmZ7Gaxqf6ctvKUYeT8jRHlA8NJ+Q2/Z9Wqs7UeFwpOwEp/Vg/r1FeUqCe0Dta5pyi1HVbFhbHn2B+F2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PLTT/xxPA2Ak/1qNXb1qU2GBi+gkhy9KrXouIN5umlc=; b=CHaZxyrTqQqHRSodiVUuecHkgwFCTv5GSXiFBk9d1prSMl6S5hfr5yp5qud/Mk8p+uqtHfzLjUE3gk2Fn+JQ5zZ5u7SKF8oO2tWX1EK0Bgs0ZIN4i6KDdVE2ucvnBa8+VYnYrLnmRCBPLRn/NsGKFAJdTQHBAiDc+PnV5turiNORDlVrGXPQubK8twydM8ihrvOVeEZo4JPIVUsG1/AjT1xNyonh9n6t7jqBFZJr1g5ownlqgxI5fMzzR4MuN7AWPYayqEi0EO1/E+l6O/IYRVGoB0/zHSRvZIhZcJqUGCcKMAfh8X4hR3H3tWrTIDhP6qqvxvRKFAaK0NYgPGs9Yw== Original-Received: from CY1NAM02FT045.eop-nam02.prod.protection.outlook.com (10.152.74.58) by CY1NAM02HT199.eop-nam02.prod.protection.outlook.com (10.152.75.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Thu, 25 Mar 2021 00:47:28 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:7e45::4f) by CY1NAM02FT045.mail.protection.outlook.com (2a01:111:e400:7e45::367) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25 via Frontend Transport; Thu, 25 Mar 2021 00:47:28 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:FF479220850C5B4A151ACBCE02D48B955CD9B3D4AB8009EBAFC1868D8B452149; UpperCasedChecksum:C7BC3425BEA42488A5D59ABB3FCFDD99889F1EC57E23240F641EB8CEB7CEE709; SizeAsReceived:7497; Count:45 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9%7]) with mapi id 15.20.3955.025; Thu, 25 Mar 2021 00:47:28 +0000 In-Reply-To: <87mtustidk.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 24 Mar 2021 22:19:03 +0200") X-TMN: [StzWmWUdBct+gj7067pD7BEAKhL7gOE4dHjLkrucWWyB6VRxPvooZMm1lMzx+qSN] X-ClientProxiedBy: CPYP284CA0023.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:69::10) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87o8f8awkk.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:c046:9359:1570:86e6:a18) by CPYP284CA0023.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:69::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.24 via Frontend Transport; Thu, 25 Mar 2021 00:47:27 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: c824a9f7-7c42-4932-63d1-08d8ef27904f X-MS-TrafficTypeDiagnostic: CY1NAM02HT199: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WscphmNt24ST9yd1s/qjB4mqTHXWHR/P8eAAOQhL/nyk6MpZ4X75bnXsh3pOIPOPImY8U6t+MIcfaXwKpxtu6NvsJq7wF6nqgf0lcsPvV9Qn0gPzT+6ZE4byAKzhOCD8uaWEnwl/ljMUYCgw+ojOC46meW0Vzl7P0uHmkrHP/uaqM0ekudIOLsmXZvkjeJIJhbAtuAkX0qxsnpNJKpHx5s0iOj1iVJgrDLA2D3bYdiMatLRpw/zp6WmEt7+TcXbj3nl/kng64N7xdxjiZO1nAN2yPeDKJE2zJj//BxtxBECcjfmQZS2+1rg5/VPJWYGnQXZrQzzZowOtLMeK0sOa9PpokuLql9igFna2yFThtG7MSPDGHmeHVIHnO8IcsjMFl4347exf3D5oxd3KeXJPuw== X-MS-Exchange-AntiSpam-MessageData: Ppya/UWHKFmMYQ47PK74Ay9FDkquT+MiCoHDxQHd7TTdX289w3MnEN0ezhlOPVTf2MZ377ptVtRvAHXN2LbjNwRfFdpOgZ5pG93Iqs4bu+UH6RiIeKVa+sr52nKkv/4VfDxPm0Hd9iBzeLZJIBQR50gGY4iiYhT4xtO+1WZib4yKCrmhOaF05Azk4G/D5j2bLWNu7iUA4BphfIiW2vc03w== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: c824a9f7-7c42-4932-63d1-08d8ef27904f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2021 00:47:28.8503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: CY1NAM02FT045.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT199 Received-SPF: pass client-ip=40.92.3.101; envelope-from=gabriel376@hotmail.com; helo=NAM02-BL2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266996 Archived-At: > > To keep all tabs of the same group next to each other, > now there is a new option tab-bar-tab-post-change-group-functions > that can be customized to tab-bar-move-tab-to-group that will move > the tab after changing its group closer to other tabs of the same > group. This is really great! Thank you! I did some tests and works fine. I have found one edge case, though. Imagine these tabs, consisting of [hint group name]: [1 g1 A] [2 g1 B] [3 g1 C] [4 g2 D] [5 g2 E] [6 g2 F] If we go to tab 2 and unset the group or set a new group (e.g.: "g3"), the tab will not be moved, which will split the group "g1": [1 g1 A] [2 g3 B] [3 g1 C] [4 g2 D] [5 g2 E] [6 g2 F] I suspect that 'tab-bar-move-tab-to-group' fails to find another tab of the same group to move to a closer position, so it leaves the current tab where it is, without checking if this creates a misalignment.