From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel do Nascimento Ribeiro Newsgroups: gmane.emacs.devel Subject: Re: master 6458e16: New mode outline-cycle-minor-mode with Orgmode-like TAB cycling on headings Date: Wed, 03 Mar 2021 21:31:04 -0300 Message-ID: References: <20210303191236.24697.93201@vcs0.savannah.gnu.org> <20210303191237.2B2D720E1B@vcs0.savannah.gnu.org> <87zgzkug5d.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6826"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 04 01:47:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHc99-0001fZ-Fa for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Mar 2021 01:47:19 +0100 Original-Received: from localhost ([::1]:42432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHc98-0000uS-3Z for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 19:47:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHc8B-0000EY-0T for emacs-devel@gnu.org; Wed, 03 Mar 2021 19:46:19 -0500 Original-Received: from mail-mw2nam10olkn2108.outbound.protection.outlook.com ([40.92.42.108]:63584 helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHc89-0006Mp-5e for emacs-devel@gnu.org; Wed, 03 Mar 2021 19:46:18 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mb+dulzzgDMhzW1a1EH5pq469cjw1N6bcKaYLYAQxjNysPxYhLxu/bu8tPuijIxQmWQ7Vg6SDziCNEBvuFmYiXN16JiSjdupYK+0t+HKvNaKuq3BC4St67UF0UlQhsVpTWc73h46nX+YaqT/+NIvGxX7Gw5pq14QJqXkSMIV4ntld0m6r8HPmqdFL9ITHC1O1nSHY91HTshAU00zYlOT1T12WzsUOvlP5+SK22mqEghtddtadxrnyl/zh4EOuH8qUeS+TMNxpU+pJqEiA9v+F9smWk0T+rnYJgOSI7J5QHLfaNbG+CpmoRszcyXdSBoJsLkhRSkbDB0Wh+3vsOlJFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6D7bMqTium5tuwq6QE9CKKgnEBngQmU8OUWOjBxb9fY=; b=dJM5NFzX+uG08/6jNyAcFpZ0ZOIQrvnk6Aakm2dsBv1LNgC7TAyNiD14Ie1ygrubKEkhxoVxTk5pguJKxpGnvAECyw7Ic+LQcT0WMpqZyd5wRfyc2O17C4XwrKSRDJ9hNVmU+dI4hnZg2TSp9P/fHlJdgR3EBZSvCGcm0acuAp4M52KX68KtiOd11BslAzqcTTAlU1PueAq472hczxl6yX/BItwmKG76d6/z/jzzOiTH+tUSsmQ0H9VNYRU/NKHHLMv8/ZHMRphFof1so0mLcYdzouTJ/wXgU1yuQBPEgJ/7EIfwNhKbbuO6x0F/9vhTIPYUoGc2wqS4Fg2NUQuD9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6D7bMqTium5tuwq6QE9CKKgnEBngQmU8OUWOjBxb9fY=; b=FkiuppV4l6vr/dHm1MGSwAkAf8pCEOiQHEb6irBaCNk3QvO6xe0fBcw056gx6zharxdoc1rUd8oV6REb7abzK0bocpnRmKBMHKXUcuo4VX9cMO9eRuWrZGX6Y3ndIlZbUZiOU4uWjnLe9J2YrlfoRywsyMjstCormVb2O0Z0zBuj+OMXEJ+Y76KOE4RSOmStt2w7lDsHXn7k7BJJ6kHhvno9ukQr14KXLTzF/6kB9iNXd8bGIoFwxZiMEt9we/mYb4Pv2FpAB8hfvltCNLTTl+GsqvCgHfgFwVVws+BlZWwpaQ2vRPakdBIXV+EoYD5XiHjTanuaHL0pyTmVSrzitQ== Original-Received: from BN7NAM10FT012.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::4f) by BN7NAM10HT093.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e8f::109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Thu, 4 Mar 2021 00:31:12 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:7e8f::40) by BN7NAM10FT012.mail.protection.outlook.com (2a01:111:e400:7e8f::114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Thu, 4 Mar 2021 00:31:11 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A61906E4045ABEBB8C187ED4EDCB9AD7FBF6FAF926F642FFEF339CF43480B6A2; UpperCasedChecksum:4BC25E3EECC152DF648860DEEACCE5EE63773574BF0457BD6CCC8154821AC9D5; SizeAsReceived:7645; Count:45 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::592f:9a58:d8cd:d9c9%7]) with mapi id 15.20.3890.030; Thu, 4 Mar 2021 00:31:11 +0000 In-Reply-To: <87zgzkug5d.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 03 Mar 2021 22:38:22 +0200") X-TMN: [o0/Czvq4goZ8x6UVBynTtihjA0mh1o/Z+NP4PRUCnmpuGGmgRCuhvO4SllKqHONe] X-ClientProxiedBy: CP2PR80CA0131.lamprd80.prod.outlook.com (2603:10d6:102:1b::21) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87o8fzlpyv.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:6ed0:7d6:d81d:d025:70c5) by CP2PR80CA0131.lamprd80.prod.outlook.com (2603:10d6:102:1b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Thu, 4 Mar 2021 00:31:08 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 5784af45-72e0-4ff5-b078-08d8dea4ce4d X-MS-TrafficTypeDiagnostic: BN7NAM10HT093: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J4yojasz6xtexqaPgvHfhnxyyNHuAttMsxzTUwHdka2jgtcyD32De9ILLGJ2Y02G5+WvVGAo5OfL+NfUr6AqwMzZ096kvAyuvYwEZZ72+Tv8FzBISC7Tl7zFnv3LSFz+h625mgAx1qV55t/mrE9EKdZvHsUp7/V+BLbd/P3WtWzgNPp5MfChWuvjCxjkzhe69UFxihG0iXwG5ICJJYXNnkVwz+j1HX7ZFUb85f5LJfKQt/Z12UK+FGZpasz1Qrt8NpzHuy1q5KYWNT3PDapkNCc7sMwK8AOSvU/XAYx/9PMzMzsCVlp/Ux62VjNNcE/kkRL+H68kAiSCFplJzMAVOiEyWgN+6yvtDCOMcr0/6CHmpCgTJ5c1FF/+9pOwPM46wY5lvoZ9uPZwVTwsMqGuGw== X-MS-Exchange-AntiSpam-MessageData: cVZvxe95SRGQUj7MFTwGpkvheVin7dH3QtBBykniHncHYUifwgt6NmqOj630ttKIioxZJ9fy3ZbrI7eaEi3tauvqGxssPF+ZW8zvPS2RcRxs+bmGUVNVns6eo0prHtqkiRcYvGd6Lg9C203kVM/OrjzqZAqLPW+OMLZEIcIgVjl6ojcDcXlBzmFJjYTIUCiAla/ojtLNS89eDOy6Z4ta3Q== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5784af45-72e0-4ff5-b078-08d8dea4ce4d X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2021 00:31:11.8539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT012.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT093 Received-SPF: pass client-ip=40.92.42.108; envelope-from=gabriel376@hotmail.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265925 Archived-At: This is a great feature, thank you! I could replace all my custom elisp code that handles outline cycle/highlight on my init.el with the new minor-modes, and everything has been working fine so far. I think that having only the variables is fine, I can't see any special need for the minor-modes. > 4. (advice-add 'xref--insert-xrefs :after > (lambda (&rest _args) > (setq-local outline-regexp "/") > (outline-cycle-minor-mode +1))) > using file names as headings where S-TAB could provide > an overview of all found files The use of outline-minor-mode + cycle on xref buffers is one of my main use cases. However, having to setup the outline-regexp and to add a defadvice seems a dirty hack. Should Emacs provide better defaults for xref and other modes (like Gnus) for an easier integration with outline-minor-mode ? As another suggestion, would be nice to add more keybidings, for example, to navigate between headers. The name 'cycle', however, maybe not be a good choice in case Emacs offers more keybidings for outline-minor-mode.