From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel do Nascimento Ribeiro Newsgroups: gmane.emacs.devel Subject: Consistency for xref-show-{xrefs,definitions}-function Date: Thu, 14 Jan 2021 17:27:27 -0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10906"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 14 21:44:49 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l09U8-0002dp-TS for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Jan 2021 21:44:48 +0100 Original-Received: from localhost ([::1]:38444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l09U7-0005Sf-PL for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Jan 2021 15:44:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l09SI-0003kL-QC for emacs-devel@gnu.org; Thu, 14 Jan 2021 15:42:56 -0500 Original-Received: from mail-oln040092003014.outbound.protection.outlook.com ([40.92.3.14]:1207 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l09S1-0004iV-G4 for emacs-devel@gnu.org; Thu, 14 Jan 2021 15:42:50 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYhoX1q4MMVik6rB8AJ+CvufGOUKtDly62rJ4yDyWSgM+/uGnZmlVibsrtZkJP+pwmB4/9Ll5l7Uw1CgRz2SdcJQwT63uuNiVsAAHORxUhyqSB5UTXJD0FDiJB9ZE8G2lbaD68gUXnGDcRRcNgcXG+AugAH/pNmb4NN83JFWrM+fJe8L9LYVsOYUJlrFTjNaiW1FIGqWAruvqJwCWs7nZ5tWio89d25r40ckjx0i9d4jx8jyPyuSaqf/CbIPaSUtPQ2Agl3Rku+CsMoDZKtCEH8EFysnhfoEX11nZzVWj3rWW5wOlnw/ke6WNtsAcg01bdabPnHhF3jygyYDiSn2Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBnMBgx1q+YuF/QUGebnTxq88i+Hy8aplK8rZhfdhWg=; b=HZI6Y19t2uJUaG0yW2ppCEqMGsbMebmzvLPxUuLLniZung73pSKR8bgEBEf2F+/8VkhBAKffXyCk4vMIJvHenABHe2syShkB5secJAcnp78oO3/fGdP+MGTQyPrQVD+0IVnTx727W2ngDsHGrCUvTrEEyUp1AyhQe31y4XVcTHzJINAM0/m9iOEznPUQH9gBoCxv/NhatohRCmDPNbpxrdEZmpdLs5zkPQKjJqzp/+3AEhC6m0J+gpHZ9ssseouBNYOqmjN3bcFtIKTMA4l680AiyOMmtXaQdtRHMo9FKt/Nu0rL8foXlCTy3du90HT5zkDLaDtdyCKwtFRAy9e9fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBnMBgx1q+YuF/QUGebnTxq88i+Hy8aplK8rZhfdhWg=; b=lN4SAQX226AU22SMC5/zpttIB0GRTWqw6baFQ2O05yfyJHDZaHEo1PBdQ4eaaDQgLSVjdX+uxYx2yNw5YMobXCSBVgYlw5xS7UCwK/lx7YuguyXvZlgLfgrqGa2NcYa5yhl4g51a6XcLsLJm5rhwslmYbyFhXuT2n3EowvP0MasIZ2kIln7gW+Fklum1XsMSDd3YBSVetBFZgIpwZVgfCTk3pkFs/Fo00KCpNhDJTQLpyAhvHttc2KvbLFsw6lKlE6h2FP3vDKr/aioYUVr3gJLqap8vpeOfeFVqRUFU9nqOTgqp4yJGqpH+JGZa36H+T/5Q4BMwieshqRZAgDiLXg== Original-Received: from CY1NAM02FT048.eop-nam02.prod.protection.outlook.com (10.152.74.53) by CY1NAM02HT226.eop-nam02.prod.protection.outlook.com (10.152.74.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Thu, 14 Jan 2021 20:27:34 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:7e45::45) by CY1NAM02FT048.mail.protection.outlook.com (2a01:111:e400:7e45::227) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Thu, 14 Jan 2021 20:27:34 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:CEEB7208E5518670458211D01A2F8025BE73C63171722E48A2A774BCAE14415F; UpperCasedChecksum:457CA5536FFC9C4847399B33C98BE996C6B04799276FBE5234D0D932EFCB9C22; SizeAsReceived:7224; Count:42 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac%7]) with mapi id 15.20.3763.010; Thu, 14 Jan 2021 20:27:34 +0000 X-TMN: [xpKyu1OV6X7MKirK3eKCD9idyJ+Qnj7LKWSwI9vhCQ6dYdWtxhwCo9E1uV5YDLR8] X-ClientProxiedBy: CP2PR80CA0151.lamprd80.prod.outlook.com (2603:10d6:102:2d::17) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87h7nje028.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f3:af8f:a8dd:7cb6:a6b6:5cb8) by CP2PR80CA0151.lamprd80.prod.outlook.com (2603:10d6:102:2d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9 via Frontend Transport; Thu, 14 Jan 2021 20:27:31 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 42 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 43972278-919a-4437-a3dd-08d8b8cad381 X-MS-TrafficTypeDiagnostic: CY1NAM02HT226: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B91ZrFwi9wD+5SD5VQt9Lj1GT5ul+6H3q8rZf5ONK5IL+K+Jqs7Yy8Alnk0U+mWFOsMiHW3fSBkAjocIfUb6HRlznv7wY+fJ58FfuwTumbCS6CE6Dcfk6lU9ejdgHPCjNprMGaWzpYnCJBnyi8Oa4ExLGXngR9l1p1m5CPfOXR71I91xGCvEz8tb3OhhQcl8PE/NwTw2nFTs8Llh1yzjCag6VUzbT75+uwQoZYPyGfUVQv3wjR8bSWzFF7sW0Q9z X-MS-Exchange-AntiSpam-MessageData: 6bU3YjeyD2m46edyNkSowaYBvHxVv0Hdc5vjHn61+LZnktIUkHBtMMBBDJjahqAdHgfchgQWhXARWNjZEG76wlERMeK02lD9LCTMDPJllZsDO1U+ETal1J/Cx2K3tRK1SIwUOXNmCxQD/gnkgA+CGVwo+Xg7cQuqs9zI77do+ckQySvR+yOauLtiFb5UehCaaw+/UvwKgyvEd5fOQhlBZw== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2021 20:27:34.3388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: 43972278-919a-4437-a3dd-08d8b8cad381 X-MS-Exchange-CrossTenant-AuthSource: CY1NAM02FT048.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT226 Received-SPF: pass client-ip=40.92.3.14; envelope-from=gabriel376@hotmail.com; helo=NAM02-BL2-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263056 Archived-At: I noticed that the options 'xref-show-xrefs-function' and 'xref-show-definitions-function' are not symmetrical. The defcustom for 'xref-show-xrefs-function' does not have type choices as 'xref-show-definitions-function' has. Furthermore, it's quite strange to configure it as follow: (setq xref-show-xrefs-function 'xref-show-definitions-completing-read) I suggest to create similar functions for 'xref-show-xrefs-function', which at this moment can be just aliases but can be independent functions in the future, if necessary: - xref-show-xrefs-buffer - xref-show-xrefs-buffer-at-bottom - xref-show-xrefs-completing-read Also, the docstrings of both options could be improved a little bit to give more information about the default choices. I can submit a patch if these suggestions are accepted. Regards, Gabriel