From: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
To: emacs-devel@gnu.org
Subject: Consistency for xref-show-{xrefs,definitions}-function
Date: Thu, 14 Jan 2021 17:27:27 -0300 [thread overview]
Message-ID: <CH2PR01MB5879698CCD7670BFB29E4FE88BA80@CH2PR01MB5879.prod.exchangelabs.com> (raw)
I noticed that the options 'xref-show-xrefs-function' and
'xref-show-definitions-function' are not symmetrical.
The defcustom for 'xref-show-xrefs-function' does not have type choices
as 'xref-show-definitions-function' has. Furthermore, it's quite strange
to configure it as follow:
(setq xref-show-xrefs-function
'xref-show-definitions-completing-read)
I suggest to create similar functions for 'xref-show-xrefs-function',
which at this moment can be just aliases but can be independent
functions in the future, if necessary:
- xref-show-xrefs-buffer
- xref-show-xrefs-buffer-at-bottom
- xref-show-xrefs-completing-read
Also, the docstrings of both options could be improved a little bit to
give more information about the default choices.
I can submit a patch if these suggestions are accepted.
Regards,
Gabriel
next reply other threads:[~2021-01-14 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 20:27 Gabriel do Nascimento Ribeiro [this message]
2021-01-14 21:04 ` Consistency for xref-show-{xrefs,definitions}-function Daniel Martín
2021-01-15 17:20 ` Dmitry Gutov
2021-01-16 18:35 ` Gabriel do Nascimento Ribeiro
2021-01-16 19:24 ` Dmitry Gutov
2021-01-16 20:31 ` Gabriel do Nascimento Ribeiro
2021-01-18 1:28 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR01MB5879698CCD7670BFB29E4FE88BA80@CH2PR01MB5879.prod.exchangelabs.com \
--to=gabriel376@hotmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).