From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel do Nascimento Ribeiro Newsgroups: gmane.emacs.devel Subject: Re: Pushing the mark from a primitive like goto-char Date: Wed, 06 Jan 2021 16:26:45 -0300 Message-ID: References: <9815d21d-b20e-c6d8-aae0-77aa65a4138a@gmx.at> <87sg7pq2bx.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3685"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 06 20:28:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxETa-0000r6-FN for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 20:28:10 +0100 Original-Received: from localhost ([::1]:37642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxETY-0000HR-QQ for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 14:28:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36992) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxESN-0007ik-KB for emacs-devel@gnu.org; Wed, 06 Jan 2021 14:26:55 -0500 Original-Received: from mail-bn8nam12olkn2036.outbound.protection.outlook.com ([40.92.21.36]:61377 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxESK-0001nk-J2 for emacs-devel@gnu.org; Wed, 06 Jan 2021 14:26:55 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kE9WK6E9EZaQCbOe6ZQVKC+1phK/lTeufIlCa6HndONyEqClFakgE+XEtrgm+7oJ+mrayf/srBanvN1FDCk0OOiMDgUdkUIJgI7h4bJD5xZQGnWVTOnG8W9Wk5VJ42GXxRgkTakPs37AWZrIytmHxZE5sFzmEIg3u+IFpe7lYGfhks++66P6TjDHpBqIIMBI5kSE1f2JjPTMN3ij8Usi7eEDcU5Kvd0k1JJIIhcyOnhEkr0eFVSJMKIS+UprOMQIt0H16uyH1reMkrY9qUMYfJsoRPTMr/7B1c51MDa45WGH9RFE+3ryFOPXB95TYP6z+Ej/UJKU0E3xZNtPn6I2fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jffUnOq+YiufSss4+79RkEATHythFLXXQUM1PFLqKUQ=; b=R0lkOaImUTNpkwXblS7KjnKehXsH8mQ+1deGT1oBttE1e/Mg7+vXFq2+GcqMDlmii8RZ2xOWtv9TCAyeftlYoRdKlqcaAKj23tQ8OSvcbBwahDVFucy1yN6Z8C6UWb5KrgvJ17lbI1A2elpYmJPHN1LO+EpztWtYq/6lwpQB3lkEDlf8IUWzsYfeXPkLwvfkHIIISwuj9r+qeXcsXE8ouJWSto7gQP+mM9nYqslihEUF3NL4hng95kn7J4I2NFxwaBdtnmZLx+H6GyLFq0AnI+A0f/h5+cMQY1wy0f/9wPS4VPDkdUrKW6q1EWtC91DPnJ+Q+aAPo+Er2FBCMJ9/xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jffUnOq+YiufSss4+79RkEATHythFLXXQUM1PFLqKUQ=; b=lmwZZ4jQWZG80dXKcl31ZIeQNQCiYhHZFafQkmTx245KhhDwclosXaxNLdFId44VffxhxPXXkJsdk+ARjOaKadw78PhdeNtg5jJjwBMyr5tEZXX0yhqAhZCyWSgnNUNiGvvGqK0ogmiVgErPCilaAEe9tdw65PG2Vg+/bQyjm1BLAmxtDT+CfdZSeKKo5mBLoDm0TPtZi0KAzkixlhdTzNBHI+yvCXWbaQvl47trAmQC1Er2lS+36CvatCCVEzkWMKQfUUm8LmrDWhJhW1psHpUdvlZbxoyxDLV6zIFE1PxnIN2uf5fcapIomERXg9HhUxIPx/DjVLXEdN+voPCjDg== Original-Received: from DM6NAM12FT044.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::4d) by DM6NAM12HT115.eop-nam12.prod.protection.outlook.com (2a01:111:e400:fc64::393) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.5; Wed, 6 Jan 2021 19:26:50 +0000 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com (2a01:111:e400:fc64::47) by DM6NAM12FT044.mail.protection.outlook.com (2a01:111:e400:fc64::204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.4 via Frontend Transport; Wed, 6 Jan 2021 19:26:50 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:B118DE2DE5109E263DA4876B4C3487EB3934F17141D26A1ED5158F8BCCC1B6F8; UpperCasedChecksum:5BA5DBF5016F54E77DC28F8A3DBC9C35A406B7B33E7F5E7823AEF0BA6318B636; SizeAsReceived:9110; Count:46 Original-Received: from CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac]) by CH2PR01MB5879.prod.exchangelabs.com ([fe80::d51d:8cbe:370a:39ac%7]) with mapi id 15.20.3721.024; Wed, 6 Jan 2021 19:26:50 +0000 In-Reply-To: ("Daniel =?utf-8?B?TWFydMODwq1u?= via \"Emacs development discussions."'s message of "Tue, 05 Jan 2021 20:06:28 +0100") X-TMN: [UJsKAFddEVu14lZ5e6rDmgkILTI39L06n+L8DvxP3BTBDUbUnDwn+ggexlcIYK65] X-ClientProxiedBy: CP2PR80CA0185.lamprd80.prod.outlook.com (2603:10d6:102:15::27) To CH2PR01MB5879.prod.exchangelabs.com (2603:10b6:610:3c::12) X-Microsoft-Original-Message-ID: <87h7nthnnu.fsf@hotmail.com> X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from precision5540 (2804:431:c7f2:f8c6:5850:bfc5:3748:ecdf) by CP2PR80CA0185.lamprd80.prod.outlook.com (2603:10d6:102:15::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Wed, 6 Jan 2021 19:26:48 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: f6d94bb0-bbf3-4bc0-a770-08d8b2790443 X-MS-TrafficTypeDiagnostic: DM6NAM12HT115: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E6/X2CKrHzpbAoORBuCGtD42gmheYRk81u9UnNpcOShh2jj2aoFkhy0YZZA5hnBbRpSLAjmUFzCnQ/tLSp89v0IwyqntbI9sELyAkz5qGTQBUbvhbmvmcO2ZeO2LB3ahKkVLkifK5I09A2Az5eltHA/RX9KDhf/6JGUtIDqmeQU8er4rau1szBgznAQj807/W89wExRIqhLrmpHgagGmUF95RFPIA2f0wuPZL5k99NM6qf/3wdw/SzlZ4v8vCeDn X-MS-Exchange-AntiSpam-MessageData: Bso9qXl1zfqPMgHGqpb2et4xM28Lgpcm3uBFQJYCiO/5OQE/iv/8ftcdH8F7aWFtOFz27W4Q5LpuQhPZuud6q2puWpk6MC1C5eHeicy4JEKEidBs7y6IUmoh5Gc3EWZFnA95aBPrdwZCANhF5U56lIcrLUluS7vZDfHc0zKJ0Y5+3fom5MmlTBMIFP7wIDAiRK7nlca1MfSJ8qaTAA8bCA== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2021 19:26:50.4025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-Network-Message-Id: f6d94bb0-bbf3-4bc0-a770-08d8b2790443 X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT044.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM12HT115 Received-SPF: pass client-ip=40.92.21.36; envelope-from=gabriel376@hotmail.com; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262628 Archived-At: "Daniel Mart=C3=83=C2=ADn via \"Emacs development discussions." writes: > martin rudalics writes: > >>>> I'd then try to make it behave like 'M-g g' in this regard. >>> >>> Some interactive versions of low-level primitives have the suffix >>> `...-command' in their names, so a command like 'M-g g' and bound to >>> 'M-g c' could be named 'goto-char-command'. >> >> I was more concerned about not pushing the mark when the region is >> already active so one can use M-g c to extend the region. BTW, is there >> a reason why 'goto-map' is so terribly unpopulated? >> > > This sounds like a good idea: > > - Create a 'goto-char-command' command in ELisp. > > - Move the interactive spec that is in 'goto-char' to this new command > and make it push the mark smartly (e.g. be careful when a region is > active). Then call 'goto-char'. > > - Rebind 'M-g c' to 'goto-char-command'. > > - Announce the new command. > > What do you think? Could it break something? Thanks. Thank you! I guess we missed the :group definition, here is a patch: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D diff --git a/lisp/mb-depth.el b/lisp/mb-depth.el index ea2ea174b5..22315cd93f 100644 --- a/lisp/mb-depth.el +++ b/lisp/mb-depth.el @@ -37,7 +37,8 @@ minibuffer-depth-indicator-function (defface minibuffer-depth-indicator '((t :inherit highlight)) "Face to use for minibuffer depth indicator." - :version "28.1") + :version "28.1" + :group 'basic-faces) ;; An overlay covering the prompt. This is a buffer-local variable in ;; each affected minibuffer. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D =20