From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Implement fast verisons of json-parse functions Date: Mon, 1 Apr 2024 10:48:09 +0200 Message-ID: References: <87h6h2rsgn.fsf@gmail.com> <867chy3vpm.fsf@gnu.org> <87cyrqrqnb.fsf@gmail.com> <865xxi3tsu.fsf@gnu.org> <874jd2rnwj.fsf@gmail.com> <864jd14lqs.fsf@gnu.org> <87edc1rzig.fsf@gmail.com> <865xx4dv0g.fsf@gnu.org> <871q7snffr.fsf@gmail.com> <86plvbdgcx.fsf@gnu.org> <87wmpjmsie.fsf@gmail.com> <86zfufasz6.fsf@gnu.org> <60B7A2FC-93BC-4759-91EE-DEE179009142@gmail.com> <864jcmbe4f.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2062"; mail-complaints-to="usenet@ciao.gmane.io" Cc: geza.herman@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 01 10:49:05 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrDLk-0000Lr-Ta for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Apr 2024 10:49:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrDL0-0003tt-CM; Mon, 01 Apr 2024 04:48:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrDKw-0003tY-Ph for emacs-devel@gnu.org; Mon, 01 Apr 2024 04:48:14 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrDKv-0004Vu-5R; Mon, 01 Apr 2024 04:48:14 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-516a01c8490so1072467e87.1; Mon, 01 Apr 2024 01:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711961290; x=1712566090; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=jHoJ8ODgSE/duynCO+zvrONcDMRtjoH5BEagRa/5BBc=; b=h5qCLuPVVkwD3t52p0x7SQR3AcUAaBaiI34S6QfBjFx9otAw740Jub77C9NFMuC9x5 CqF/j69AXOF9vDgQdjgNWa1WyV7VbJsziVv+Nhep/Mq6GLx86UMCmE8yCbz4fdJani/8 5X7oDx6kM/aud8XHTsBtkwNl42562GvrBraQooCGiTl6TuRdlYWmKl6n5z8600e5kpTo gzsG/vMOxNnQ3a8ySIinqgCZRJBlms3Itulov2YgutawYOLKRH0EI0fQYg2lz9qaWRM3 Li4FAZiaOuAVJ1FDClZp3fAcUGZYZOVYtcUI+mMFSPgX86RC1N9/d1sf3rs9lyHBIriy ddvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711961290; x=1712566090; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jHoJ8ODgSE/duynCO+zvrONcDMRtjoH5BEagRa/5BBc=; b=iTxaksf59WsY7pZ65nJJnjbDOcStfm75/T/bXAiOlXQUyllh56O+QtkLJZq8havFEy 5GzFxcpj8bQTvGY/wZm1qQRl/w7dux48Trx8FTt6gnZ5wbQ8xfxnRwKjfahK6KpEqjML UIoeREYPLqCoTowct5UleLTg8aCEKT8VpBVy/5xBq0pCkrzwYsNuJWVTNSUvMt/1SRY9 bSVNIEViZKfRPxoTg8i24W7Iy+BSaniqkOixToXSLnuOwFrc8J6G0Fg5smG5GtVs+xpA b2XAS3AStmFqR+xTWRvesc22t2/1MZYTky3+Cmpu0D1aX8zgdjAFt7Sx609urEGZhC9A SAdQ== X-Forwarded-Encrypted: i=1; AJvYcCVbFaHuda2W3ZDW5ajefagOijXYevMW613jh3EHEtLBWH1RfDvthawWUJcLEZJpS4DywReHgjzLgM7mkY0mv3/Y/WSY X-Gm-Message-State: AOJu0YxdzHIL5ZAWJ1yFUxIJfH0/xKA+4kqQsG4HN0ntW8U/iR6mg6HG GykbvcXZr4IkbUZleKSUn+/FRiK0HRY3QyOgeVWj2pMP7L1GUpm/gySGCQtQ X-Google-Smtp-Source: AGHT+IF/84LjJjvIr45jghCtDU6DAybroNg682HJQ+ePBURoOwF5e8+5IkU3L6LZjBuHU5B6tfdZPw== X-Received: by 2002:a19:8c17:0:b0:513:dcd2:1267 with SMTP id o23-20020a198c17000000b00513dcd21267mr4026519lfd.23.1711961290011; Mon, 01 Apr 2024 01:48:10 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id y14-20020a19914e000000b00513d51ef023sm1383422lfj.121.2024.04.01.01.48.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2024 01:48:09 -0700 (PDT) In-Reply-To: <864jcmbe4f.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317442 Archived-At: 31 mars 2024 kl. 17.44 skrev Eli Zaretskii : > I'm okay with changing the errors we signal, but let's please document > in NEWS all the changes in this area. Right. The new code is now in master. It made for a parsing speed-up of about 2x, often more. I also fixed the unintuitive `end-of-file` errors from = (json-parse-string "\0"). It had nothing to do with NULs, actually.