From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Call for volunteers: add tree-sitter support to major modes Date: Mon, 10 Oct 2022 10:16:05 -0700 Message-ID: References: <83czb1jrm3.fsf@gnu.org> <84436B1D-3359-487F-B997-A7F56FDEA636@thornhill.no> <83bkqljih5.fsf@gnu.org> <87fsfx6ufb.fsf@thornhill.no> <8335bxjdpf.fsf@gnu.org> <1D07A0F1-A269-410A-9D3C-8A53113FFE2F@thornhill.no> <83sfjxhuvc.fsf@gnu.org> <87bkqk7qb0.fsf@thornhill.no> <8735bw7kwm.fsf@thornhill.no> <158F25C9-A539-4515-8D49-50A7E6252960@gmail.com> <87o7uk5f5i.fsf@thornhill.no> <87edvf8wwl.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23884"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 10 19:27:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohwZH-0005zW-2Q for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 19:27:55 +0200 Original-Received: from localhost ([::1]:45970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohwZF-0004y3-6t for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Oct 2022 13:27:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohwNx-000472-9d for emacs-devel@gnu.org; Mon, 10 Oct 2022 13:16:21 -0400 Original-Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:44593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohwNt-0003GJ-BX; Mon, 10 Oct 2022 13:16:12 -0400 Original-Received: by mail-pf1-x42b.google.com with SMTP id i3so1744981pfc.11; Mon, 10 Oct 2022 10:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y9w3d6MR6LbGcaS9h7usJ9+UmydzWY4BEh/oMBqYIvM=; b=lquKbxmz84v2vnmEuNkz1rwM0KcimdFOdOZZ9FROcwQ553w1GSPV2EoGT2TA4ZHLL/ j97uhYBEDwOLigkU0tgNqlHOoA/7smMetVK2sJ1YzPPb2bw3ha3y7Jdq8yEwyXcwiFiu QuoXws4dM/EE4pc8jJiZ5NieQSsTRuOaEF5DHdfowo6JqAQ86OrlytFNJsXbyCIu7ssy CbClSYaCS/4KoeRXbs1Xob1KkEALhJFr44pFuDPkRDMWl4qrLNoiCqNO9B9OQvURKfm8 F6eVzXMasxlP1Umxm+dIZWHAUFgvvwYqu+xNeLt0b6Sw09vVDVX5UQFBdwV7RH3nys3p JiXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y9w3d6MR6LbGcaS9h7usJ9+UmydzWY4BEh/oMBqYIvM=; b=3OI+JOgORqHxLZthTdTBZLFnajYMLPAYwSP3ZFO9NzW7ZT9G1/KTj3B0Q2xRJPeiRJ IMBEp6s1WTxVkrG4srlGI1RPptGKjR9BB1/fhkVSKOwNhUXuJ7rUqV/Rzm0JzWx8d+VK CdLcN1OT3P4EubyoZmqRlFWesJJ5txXXfmVPKd5Dxw2Ave/3PbYawAmVOCf33Azghm8j DqCQyvJnA22DIVu7cKeTliv6Y/XcZs7LGbP2DLHU80nYgrxFaPLMHfhi+u29ibvlUWrR bK1ppGxSx6WvoB/9lFxmszjC4k9XlIqGBOJlZleUGVk+JmAgbl6Alt/PGQ8mC7mmvscR a3eQ== X-Gm-Message-State: ACrzQf0e81lnnl1Md9IP99iB2X1ZWJPPMiNewwQuNjpw8TMKpHCu5mc4 B/8sR5+bMTN+loSCOWKNd+5IrMYyfGc= X-Google-Smtp-Source: AMsMyM76F7WMyjRitJ5prnSopOE9Y1pj9/6YczKfvnzKTSev7Q7mDwYAOoc0MP1I17mA5jCAwUhJpA== X-Received: by 2002:a63:88c8:0:b0:458:9ddd:e8ea with SMTP id l191-20020a6388c8000000b004589ddde8eamr17223931pgd.622.1665422167509; Mon, 10 Oct 2022 10:16:07 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b5-20020a1709027e0500b001754064ac31sm6887942plm.280.2022.10.10.10.16.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Oct 2022 10:16:07 -0700 (PDT) In-Reply-To: <87edvf8wwl.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=casouri@gmail.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297390 Archived-At: > On Oct 10, 2022, at 9:29 AM, Theodor Thornhill = wrote: >=20 >>> I added some variartion of this. I think also message is better, >>> because user-error makes the logic a little harder. What do you >>> think? >>=20 >> Yeah user-error is mostly the same as a message, since nobody (I >> think) turns on beeping anymore. Though I hope there is a way to warn >> users that=E2=80=99s not missable. Messages (and user-error) could be = covered >> by later messages. Hmm, maybe we can use warnings. >>=20 >> For template string please see that patch that applies on top of your >> patch. It seems to work for me. (Also see screenshot attached, >> brackets have different colors because I forgot to turn off >> rainbow-delimiter-mode when taking the shot). Also some of the lines >> are longer than 70 columns. Could you wrap those lines? >>=20 >=20 > Yeah, it is better, though we still get some bleeding into the parens > etc. Anyway, I think we can tweak this later. >=20 > Applied your changes, see latest revision. >=20 > Thanks, > Theo >=20 > <0001-Add-tree-sitter-functionality-to-js-mode.patch> Thanks! Looks good, I=E2=80=99ll apply it. BTW, you don=E2=80=99t need = to explain what does a function do in the commit message, just what = changed. For new functions, you can just say =E2=80=9CNew function=E2=80=9D= . And you can merge several entries together, like (js--treesit-backward-up-list) (js--treesit-indent-rules) (js--treesit-keywords) (js--treesit-settings): New functions. Yuan=