From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Pegoraro Newsgroups: gmane.emacs.devel Subject: Re: HiDPI support for wave style underlines Date: Sun, 27 Aug 2017 12:26:00 +0800 Message-ID: References: <83wp6r3ed8.fsf@gnu.org> <83shgpe1cp.fsf@gnu.org> <87shgl5cyf.fsf@wavexx.thregr.org> <871so59k54.fsf@wavexx.thregr.org> <83r2w5asby.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1503808017 19050 195.159.176.226 (27 Aug 2017 04:26:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 Aug 2017 04:26:57 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 27 06:26:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlp9l-00049S-Qs for ged-emacs-devel@m.gmane.org; Sun, 27 Aug 2017 06:26:41 +0200 Original-Received: from localhost ([::1]:59520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlp9s-0005D4-I7 for ged-emacs-devel@m.gmane.org; Sun, 27 Aug 2017 00:26:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlp9D-0005Cr-Dx for emacs-devel@gnu.org; Sun, 27 Aug 2017 00:26:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlp9C-000524-9C for emacs-devel@gnu.org; Sun, 27 Aug 2017 00:26:07 -0400 Original-Received: from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a]:35065) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlp9C-00051P-33 for emacs-devel@gnu.org; Sun, 27 Aug 2017 00:26:06 -0400 Original-Received: by mail-it0-x22a.google.com with SMTP id f1so8092930ith.0 for ; Sat, 26 Aug 2017 21:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tutive-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=EBXzgKLOYPvNlWoz3lPi9ktl1jgiR22PFPnc7El2pZI=; b=2MbKkfNhmj1Epo/d1kiHwDDGSLFOHtpWCP7u8MpFHgM2sUjeHDg+HBukgJzfrAMlV3 yHxuoS1jIdiy4tPLWOliAF6Q5U7KcrphxHaNEzwPa9BGOUo/NtLNcAu+cfxhcg81b3z5 PKaE+B48kb+WjQ+OZGR9X7kWCymmrKAQok+FlGxAd5Nl0JesEtjbbFB3zhXlKdvXZFu/ 125WDpNx3iHPZSYD3UogOmDe4h39/QtbmYHibB4Omv4d09d5gY5qWhvnjnEla7DpzPe8 jvd8scoBMqkCiCVC06RIGYgoBneEVbH3rYd3SnSiAFx7V8Vs4EWY5EKUAuNZBff2Ty8V NH+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=EBXzgKLOYPvNlWoz3lPi9ktl1jgiR22PFPnc7El2pZI=; b=O/ggr0lpkMKQDgdw9cmu1R/YxDGY+I6AheUP22AU8C4ImlDxZKZeN06TG+QxqJQXUH 9xdH31cQeVzNnDizOpWzcgssHxVn9oWw/TSnL+77YGDfdAnMFDL/dMPnBuQ3fy4Ynvsa FrcrYq5wj0RaYXHFsXq1u03dDuNGRx/eLYGhSxw9UzvwTzWXzpgn5gLYasI63uGXoqX3 JsXcec5fg517/Cxz+lpIu4vY/OA4XqGs6YpgWDxHqewG6C8rVhZdQuycK/K5KTc4wwib THFD3ntCSC5IkA9UQ2sh3U+uQiLleCGwLs+JN+gAnSG8TQQttxnNsjpuAT3kWYrEunHi VJiA== X-Gm-Message-State: AHYfb5gdO2b06Q990kR2aWvL37pf+zmoVdIvzAzK22+Sf8Xew4wQQsaP rTxPnf3vVnjxgSvXFSEovwRfFnHBwGf2 X-Received: by 10.36.178.27 with SMTP id u27mr609919ite.123.1503807960862; Sat, 26 Aug 2017 21:26:00 -0700 (PDT) Original-Received: by 10.2.126.10 with HTTP; Sat, 26 Aug 2017 21:26:00 -0700 (PDT) In-Reply-To: <83r2w5asby.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217842 Archived-At: It still needs a fair bit of work on my end, the current implementation is pretty naive. Certain fonts are also getting clipping issues on HiDPI displays. I've been pretty short of time this month but will try to get something better going in the next few days! On 21 August 2017 at 22:49, Eli Zaretskii wrote: >> From: Yuri D'Elia >> Date: Mon, 21 Aug 2017 14:32:07 +0200 >> >> On Mon, Aug 21 2017, Yuri D'Elia wrote: >> > I actually get a floating point exception with this since I rebuilt >> > emacs on the 19th. I'm rebuilding emacs now with debug to check where >> > it's located, but I pinpointed it to flyspell so... >> >> Thread 1 "emacs" received signal SIGFPE, Arithmetic exception. >> 0x00000000005181a3 in x_draw_underwave (s=0x7fffffffbe20) at xterm.c:3541 >> 3541 x1 = x0 - (x0 % dx); >> (gdb) where >> #0 0x00000000005181a3 in x_draw_underwave (s=0x7fffffffbe20) at xterm.c:3541 >> #1 0x0000000000518877 in x_draw_glyph_string (s=0x7fffffffbe20) at xterm.c:3685 >> #2 0x00000000004805d4 in draw_glyphs (w=0x148dc30 , x=233, row=0x2eda080, area=TEXT_AREA, start=7, end=26, hl=DRAW_NORMAL_TEXT, overlaps=0) at xdisp.c:26595 >> (gdb) p dx >> $1 = 0 > > Thanks, I tried to correct this with an obvious fix. >