unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Karl Fogel <kfogel@red-bean.com>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: Pierpaolo Bernardi <olopierpa@gmail.com>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: Questioning the new behavior of `open-line'.
Date: Sat, 14 Nov 2015 15:59:29 -0600	[thread overview]
Message-ID: <CAPiWUYq6Mz6B6rOm5GvNx=pz=grVpur2N8A5_oeMpsENEW-VYQ@mail.gmail.com> (raw)
In-Reply-To: <CAAdUY-K=gwd-kYgvL4FFvszJPTExnTWa1wzJ8ZDQa1VXd_CQ5Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On Sat, Nov 14, 2015 at 6:34 AM, Artur Malabarba <bruce.connor.am@gmail.com>
wrote:

> 2015-11-13 6:04 GMT+00:00 Pierpaolo Bernardi <olopierpa@gmail.com>:
> > The old behaviour is: ctrl-o inserts a newline after the point,
> > nothing else is done.
>
> Ok, thanks for clarifying. Still can I ask for an example usage where
> that behaviour is good and the current behaviour is bad.
>
> I'm not trying to be annoying here. It's just that I want to clearly
> list all relevant scenarios when I write the commit message (so that
> future hackers will know about them before changing some behaviour).
>

Even better, consider put the rationale(s) in a comment in `open-line'
itself, rather than in the commit message.  That way someone who is in the
code and thinking of changing it will see the reasoning right where they
are.

[-- Attachment #2: Type: text/html, Size: 1262 bytes --]

  parent reply	other threads:[~2015-11-14 21:59 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 18:08 Questioning the new behavior of `open-line' Karl Fogel
2015-11-11 18:51 ` John Wiegley
2015-11-11 18:58   ` Karl Fogel
2015-11-11 19:07     ` Eli Zaretskii
2015-11-11 19:13       ` John Wiegley
2015-11-11 19:39         ` Karl Fogel
2015-11-11 20:11           ` Eli Zaretskii
2015-11-11 20:17             ` John Wiegley
2015-11-11 20:33               ` Karl Fogel
2015-11-11 20:37               ` Alan Mackenzie
2015-11-11 20:46               ` Eli Zaretskii
2015-11-11 20:58                 ` John Wiegley
2015-11-11 21:08                   ` Karl Fogel
2015-11-11 21:13                     ` John Wiegley
2015-11-12  7:59                       ` Karl Fogel
2015-11-11 21:53                     ` David Kastrup
2015-11-11 21:52               ` David Kastrup
2015-11-12  0:08                 ` Rasmus
2015-11-12  8:06                   ` Karl Fogel
2015-11-12 10:00                     ` Artur Malabarba
2015-11-12 11:08                       ` Rasmus
2015-11-12 11:18                         ` Andreas Schwab
2015-11-12 13:11                         ` Artur Malabarba
2015-11-12 14:16                           ` Rasmus
2015-11-12 14:44                             ` Yuri Khan
2015-11-12 14:52                               ` Rasmus
2015-11-12 14:54                                 ` Yuri Khan
2015-11-12 15:38                                   ` David Kastrup
2015-11-12 16:20                                     ` Karl Fogel
2015-11-12 16:33                                       ` Pierpaolo Bernardi
     [not found]                                         ` <CAAdUY-LVoXm-c+Cv8Gx6h+d40YDoK4rJp1U6Tw+Gc+yCOVee=g@mail.gmail.com>
2015-11-13  1:17                                           ` Artur Malabarba
2015-11-13  6:04                                             ` Pierpaolo Bernardi
2015-11-14 12:34                                               ` Artur Malabarba
2015-11-14 19:39                                                 ` David Kastrup
2015-11-17  0:42                                                   ` Karl Fogel
2015-11-17  0:53                                                     ` Karl Fogel
2015-11-17  3:46                                                     ` John Wiegley
2015-11-17 22:57                                                       ` Richard Stallman
2015-11-17 23:16                                                         ` John Wiegley
2015-11-18 17:25                                                           ` Andreas Röhler
2015-11-17 23:20                                                     ` Artur Malabarba
2015-11-18 20:32                                                       ` Karl Fogel
2015-11-18 21:03                                                         ` Artur Malabarba
2015-11-19 23:34                                                           ` Karl Fogel
2015-11-19 23:57                                                             ` Artur Malabarba
2015-11-14 21:59                                                 ` Karl Fogel [this message]
2015-11-12 14:57                                 ` David Kastrup
2015-11-12 16:09                             ` Artur Malabarba
2015-11-12 15:26                               ` Rasmus
2015-11-11 20:15         ` Eli Zaretskii
2015-11-11 20:28           ` John Wiegley
2015-11-11 20:55             ` Eli Zaretskii
2015-11-11 21:00               ` John Wiegley
2015-11-11 21:16                 ` Eli Zaretskii
2015-11-11 21:17                 ` Alan Mackenzie
2015-11-11 21:30                   ` John Wiegley
2015-11-11 22:40                 ` Artur Malabarba
2015-11-11 19:20       ` Paul Eggert
2015-11-11 19:25         ` John Wiegley
2015-11-11 20:13         ` Eli Zaretskii
2015-11-11 21:50 ` David Kastrup
2015-11-11 22:24 ` Artur Malabarba
2015-11-11 21:31   ` John Wiegley
2015-11-11 21:46     ` Karl Fogel
2015-11-12  7:38 ` Andreas Röhler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPiWUYq6Mz6B6rOm5GvNx=pz=grVpur2N8A5_oeMpsENEW-VYQ@mail.gmail.com' \
    --to=kfogel@red-bean.com \
    --cc=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=olopierpa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).