unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jorge Alberto Garcia <jorge.garcia.gonzalez@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Paul Eggert <eggert@cs.ucla.edu>,
	Yuri Khan <yuri.v.khan@gmail.com>, John Wiegley <johnw@gnu.org>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] add emacsclient support to open with file:linum syntax
Date: Wed, 30 Mar 2016 10:42:32 -0600	[thread overview]
Message-ID: <CAPfrtUdgm_owirqkdDD-TcAT2EoW1EUAQhEqQsaAj1TD5TndiA@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY1Z5icqiC=rYnDECL+ynLJEn6Pxj8iJBvGp9Qy7d1FDkA@mail.gmail.com>

On Wed, Mar 30, 2016 at 8:21 AM, Kaushal Modi <kaushal.modi@gmail.com> wrote:
>> On 03/29/2016 03:35 PM, Kaushal Modi wrote:
>> I myself, use an awk script to rearrange the arguments to work with the
>> current +LINE FILE format accepted by emacsclient ( Ref:
>> https://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00541.html ).
>> So the existing emacsclient implementation already works for you.
>>
>> They are not workarounds, because grep output cannot be used unchanged.
>> Even with the proposed option syntax, users would need to employ a script
>> such as yours to pick out the part of the grep output that they need, and
>> use that information to formulate arguments for emacsclient.
>> The longstanding +LINE option syntax is compatible with other popular free
>> editors such as 'vim' and 'nano', and there is some value in encouraging its
>> usage rather than reinventing the wheel.
>>
>>
>> Having this patch installed will prevent the need for such workarounds
>
>
>
> Jorge,
>
> Based on the counter arguments provided by Paul, I now tend to agree to what
> he says.
>
> 1. The current method (+LINE FILE and using awk to arrange stuff) has been
> working well for me for quite few years.
> 2. It makes sense to have users stick to one convention (+LINE FILE) instead
> of having users now split between "+LINE FILE" and "FILE:LINE".
>
> I do not use copy/paste manually but instead make a shell alias using that
> awk snippet do things. So with either "+LINE FILE" or "FILE:LINE", I will
> need that awk script.
>
> That said, I appreciate the effort you put in in creating this patch and
> this reply, by no means, is intended to discourage you from your future work
> (especially in C).

Thanks Modi,
Folks

I agree with Paul, mx-grep is a better way but is not always possible
to use it, but
use case are different, here you already have a location specified.

Emacs users are very diverse, MX-grep/bash not always is present on
the same system
is a shame but not always is possible/confortable to have a workflow
running within emacs.

I will not push anymore for this patch but please consider this
argument before rejection.
-Jorge



  reply	other threads:[~2016-03-30 16:42 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 22:35 [PATCH] add emacsclient support to open with file:linum syntax Jorge Alberto Garcia
2016-01-08  7:42 ` Yuri Khan
2016-01-08  8:08   ` Jorge Alberto Garcia
2016-01-08  8:59     ` Yuri Khan
2016-01-08 14:11       ` Jorge Alberto Garcia
2016-01-08  9:03   ` Eli Zaretskii
2016-01-08 14:13     ` Jorge Alberto Garcia
2016-01-08 15:39       ` Eli Zaretskii
2016-01-08 15:54         ` Kaushal Modi
2016-01-08 16:13           ` Jorge Alberto Garcia
2016-01-08 16:38             ` Kaushal Modi
2016-01-08 16:44               ` Jorge Alberto Garcia
2016-01-08 16:54                 ` Kaushal Modi
2016-01-08 17:52                   ` Jorge Alberto Garcia
2016-01-08 19:06                     ` Eli Zaretskii
2016-01-08 19:05                   ` Eli Zaretskii
2016-01-12 21:04                     ` John Wiegley
2016-01-12 21:26                       ` Jorge Alberto Garcia
2016-01-13  0:10                         ` John Wiegley
2016-01-13  0:46                           ` Jorge Alberto Garcia
2016-03-29 16:22                             ` Kaushal Modi
2016-03-29 17:30                               ` Jorge Alberto Garcia
2016-03-29 21:27                                 ` Paul Eggert
2016-03-29 22:35                                   ` Kaushal Modi
2016-03-29 23:08                                     ` Paul Eggert
2016-03-29 23:29                                       ` Jorge Alberto Garcia
2016-03-30  0:37                                         ` Paul Eggert
2016-03-30 14:21                                           ` Kaushal Modi
2016-03-30 16:42                                             ` Jorge Alberto Garcia [this message]
2016-03-31 12:31                                             ` Stefan Monnier
2016-03-31 14:24                                               ` Jorge Alberto Garcia
2016-01-08 19:19                   ` David Caldwell
2016-01-08 19:43                     ` Eli Zaretskii
2016-01-08 19:52                       ` David Caldwell
2016-01-08 20:33                         ` Jorge Alberto Garcia
2016-01-09 22:51                           ` Jorge Alberto Garcia
2016-01-10  8:22                             ` Yuri Khan
2016-01-10  8:37                               ` Jorge Alberto Garcia
2016-01-12 16:24                                 ` Jorge Alberto Garcia
2016-01-08 16:10         ` Jorge Alberto Garcia
  -- strict thread matches above, loose matches on Subject: below --
2017-02-09  9:58 Toon Claes
2017-02-09 13:22 ` Stefan Monnier
2017-02-14 13:57   ` Toon Claes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPfrtUdgm_owirqkdDD-TcAT2EoW1EUAQhEqQsaAj1TD5TndiA@mail.gmail.com \
    --to=jorge.garcia.gonzalez@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=johnw@gnu.org \
    --cc=kaushal.modi@gmail.com \
    --cc=yuri.v.khan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).