From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jorge Alberto Garcia Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add emacsclient support to open with file:linum syntax Date: Fri, 8 Jan 2016 10:10:33 -0600 Message-ID: References: <838u40qw8j.fsf@gnu.org> <837fjkozax.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1452269497 27588 80.91.229.3 (8 Jan 2016 16:11:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Jan 2016 16:11:37 +0000 (UTC) Cc: Emacs developers , Yuri Khan To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 08 17:11:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aHZdX-0006sa-JG for ged-emacs-devel@m.gmane.org; Fri, 08 Jan 2016 17:11:35 +0100 Original-Received: from localhost ([::1]:37075 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHZdT-0001KE-Kz for ged-emacs-devel@m.gmane.org; Fri, 08 Jan 2016 11:11:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHZdD-0001J6-TZ for emacs-devel@gnu.org; Fri, 08 Jan 2016 11:11:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHZdD-0004FE-28 for emacs-devel@gnu.org; Fri, 08 Jan 2016 11:11:15 -0500 Original-Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:35316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHZdB-0004Ez-Nn; Fri, 08 Jan 2016 11:11:13 -0500 Original-Received: by mail-oi0-x231.google.com with SMTP id l9so309417504oia.2; Fri, 08 Jan 2016 08:11:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=GY4SWJH0l32ItrnV/o4OAvw7W79AginBp95XTU+4LdM=; b=fxWiP9FAiFyaN+56/13wwvCrEWIBLLkMfDuykRuUjtRakyZsX8mk6uIKpkhCuOpnX+ Ns4urh2W5T3Xqmfa/f3Z7j8765iwuZUymiceJRB7lCm1vxim/dayR/aLZ4SRljOeWcP0 s0TvlsKU7tELie8oauzBONSR3ar6qiqJRs51QbJUnS0qBe38eLP1NKOMWERcMrbH3fcu T5gjioZNEkyx0wvJUkc8u214MPF/RnTHt78PVE4up7WKt+43IyP4phCiARAzXTSNhyQ4 hQy1+MO5UsHXNJdMTstrtovMHTUE9cPLukjLnA9+vYjyawiH3dbM5JJwPgxvmNkaOYd3 CNxQ== X-Received: by 10.202.73.69 with SMTP id w66mr77093707oia.85.1452269473275; Fri, 08 Jan 2016 08:11:13 -0800 (PST) Original-Received: by 10.202.92.213 with HTTP; Fri, 8 Jan 2016 08:10:33 -0800 (PST) In-Reply-To: <837fjkozax.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197835 Archived-At: On Fri, Jan 8, 2016 at 9:39 AM, Eli Zaretskii wrote: >> From: Jorge Alberto Garcia >> Date: Fri, 8 Jan 2016 08:13:58 -0600 >> Cc: Yuri Khan , Emacs developers >> >> > I think such a feature, if deemed useful, should be activated by a new >> > command-line option. Otherwise, I don't see how can emacsclient be >> > sure the bunch of digits at the end of a file name is a line number. >> >> Hey Eli, thanks for your feedback, >> would you be against using a new env var to enable it ? > > Yes. I think changing behavior depending on environment variables is > only appropriate for debugging options, not for mainstream. Got it, so what about keep using '+' to indicate a line position if a number is not followed then look for it in the filepath. This way it uses the same flag, keeps compatibility and enables this feature only when required.