unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuri Khan <yurivkhan@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Flymake, compilation-mode lighters very noisy
Date: Wed, 21 Nov 2018 18:35:54 +0700	[thread overview]
Message-ID: <CAP_d_8VuzG04F7jwAUqssTSRxfZjFEcn5XTL3T=kWW0nWzZz6w@mail.gmail.com> (raw)
In-Reply-To: <CALDnm53Ah-SdSqtW8Q+NGQ4Ss0AAt3eFGPzEMwtYbjihsF-FTA@mail.gmail.com>

On Wed, Nov 21, 2018 at 5:39 PM João Távora <joaotavora@gmail.com> wrote:
>
> This is too long for me to read right now, sorry.

Please take your time. No pressure.

> The simple variable flymake-always-show-indicators-min-severity-level would fix the problem you reported yesterday, and it would be trivial to implement, but you seem to be suggesting much more.

I am suggesting a massive logic:presentation split-up, so that not
only my problem would be fixed but also similar problems for different
categories of other users, and because such a split-up is generally a
good thing.


> By the way, I only asked you to propose a break up of that function because you talked about copying it to your init and tweaking it. I assumed those tweaks would not be random... :)

Okay, if we are talking about my tweaks only, then I would want to
have a configuration where a red or yellow anything on my mode line
means an actionable alert. That is, only display color if there is
something I *can* and *should* fix immediately.

* First, I would suppress zero counters of all severities. This would
make it possible for me to work on projects that currently have no
errors or warnings and where the policy is to keep errors and warnings
at zero.

* I could get involved in a project that has warnings, and where I
cannot fix them all at the source. Then I would first attempt to see
if I can customize the checker rules to silence those categories of
errors or warnings. If that proved infeasible, then I would have to
live with a non-zero error or warning counter; in that case I would
want to tweak the indicator so that the counters were displayed in a
normal face, not in red and yellow.

…And here I looked at where it gets the faces from and saw I could
just (put 'flymake-error 'mode-line-face nil). Thank you, immediate
problem solved, sorry for the panic :)


> Propose those changes in a patch or a scratch branch! Or, alternatively, propose only the new customization variable/interfaces you would like to see added, along with docstrings, and we can deal with the implementation later after we settle on the user interface.

As someone who has not assigned copyright to FSF, I think I can
currently only propose ideas, and modest amounts of code.



  parent reply	other threads:[~2018-11-21 11:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-19 10:36 Flymake, compilation-mode lighters very noisy Yuri Khan
2018-11-20 20:16 ` João Távora
2018-11-21  9:54   ` Yuri Khan
2018-11-21 10:38     ` João Távora
2018-11-21 10:42       ` João Távora
2018-11-21 11:35       ` Yuri Khan [this message]
2018-11-21 11:58         ` João Távora
2018-11-21 12:22           ` Yuri Khan
2019-01-05 12:13             ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP_d_8VuzG04F7jwAUqssTSRxfZjFEcn5XTL3T=kWW0nWzZz6w@mail.gmail.com' \
    --to=yurivkhan@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).