From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Yuri Khan Newsgroups: gmane.emacs.devel Subject: Re: Code reviews Date: Tue, 8 Mar 2016 18:09:41 +0600 Message-ID: References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87vb4zb0i4.fsf@gnu.org> <837fheuu6a.fsf@gnu.org> <877fheb1rh.fsf@wanadoo.es> <87ziua9mwq.fsf@wanadoo.es> <83h9git36k.fsf@gnu.org> <87vb4y9ep9.fsf@wanadoo.es> <83a8mat2aa.fsf@gnu.org> <87r3fm9du0.fsf@wanadoo.es> <878u1tuzgn.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1457439030 11344 80.91.229.3 (8 Mar 2016 12:10:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 12:10:30 +0000 (UTC) Cc: Stefan Monnier , Emacs developers To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 13:10:25 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adGT2-0006Ue-Ic for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 13:10:24 +0100 Original-Received: from localhost ([::1]:33994 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adGT1-0001df-Q3 for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 07:10:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adGSh-0001Zl-Vf for emacs-devel@gnu.org; Tue, 08 Mar 2016 07:10:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adGSh-0004oD-2w for emacs-devel@gnu.org; Tue, 08 Mar 2016 07:10:03 -0500 Original-Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:34161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adGSg-0004n7-SK for emacs-devel@gnu.org; Tue, 08 Mar 2016 07:10:03 -0500 Original-Received: by mail-lb0-x22c.google.com with SMTP id xr8so15323836lbb.1 for ; Tue, 08 Mar 2016 04:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lIXMHY9Gra2bCmCjkXMFYfgxuCJ0hVAMfXeGi8snkL0=; b=Jj9iPALYxSLYzva7ycjg5cARmkD/fAc3MZxwCxRWEZr68BCNX112gZ4DhY+CwxLttZ hmDNcUmnB/7zaR4SjZYIjf1Cm8J+e0OA0ouE8KyyB5+VPmrUyOZrjlgv9V0O7LtK3w9t I5GfyyRSP8S5kUIRSSW/n8hwWWHaFLxH3fPJQif7wE7fF82W5eEO4uzB09MHCb9j/kny YB1REzLQc4g305/vcnzf5xGyYXTgRo45bc/3T7ublpSkYed9gJTNBtD3478ZYx4BkZZJ 93q0VnrJaENOvTxsus+1rqLItK9zyDDRfh1wXE6fpWAjdg2iyV9OGkFw5F38aaiTi779 NDyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lIXMHY9Gra2bCmCjkXMFYfgxuCJ0hVAMfXeGi8snkL0=; b=Zb6OOibV4y7PqSXTEb3YXMP36/mtA1ZU9IfBAHib0z8JmrmOfWcBQuO/nNWE9S83Tb gf4JrZcd1FMON4CAwGxUnSHVhVvnb0QVPMUmp+JPGbH913Z6dIi4GgEDyIFJUdDe62/Z 12s5u4h82HY6Ok4UU9bqNFwvxQc2nXEY616pafSB4DeLhwwJz7FJDpO/gd8TCLnUUrwo kJVm/8RplXjXJP7TfO9tfcyjUkqUqBxcALeT71EUTVv0heNOHpCz3fh0gYtWG5W9Kk0q oKbJzHhuWy8zugEQZC8RWw/b7yRogcjyrOTu7wVsHgEXPKXdNdDYXuxnHIP1pfh4phUj LsJg== X-Gm-Message-State: AD7BkJKFLjpWppkVsQJ9xSnNBx1c/lMJuJ+YGQI+b02lZTVKICVZy7wC9NdvDnAF/q9/xfzqD4Lty2J1jXgOPQ== X-Received: by 10.112.157.234 with SMTP id wp10mr3311301lbb.56.1457439001601; Tue, 08 Mar 2016 04:10:01 -0800 (PST) Original-Received: by 10.112.254.164 with HTTP; Tue, 8 Mar 2016 04:09:41 -0800 (PST) In-Reply-To: <878u1tuzgn.fsf@russet.org.uk> X-Google-Sender-Auth: gCNLzpILRCXvw7QloyG9SJcV5sk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201138 Archived-At: On Tue, Mar 8, 2016 at 2:48 PM, Phillip Lord wrote: > I think that this would require some considerable co-ordination. If I > push a broken commit to devel branch, and then you fix this commit > through rebase, my copy of the branch (and everyone elses) is now > broken. I'm pretty sure that this kind of fix up can only happen on a > feature branch in a sane way. Fixups by rebase work if everybody agrees to never pull+merge and always does a pull+rebase instead.