From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Yuri Khan Newsgroups: gmane.emacs.devel Subject: Re: emacs-diffs emails can get long subject if log starts with "*" Date: Sun, 23 Nov 2014 11:44:25 +0700 Message-ID: References: <87389azvuk.fsf@igel.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1416717889 20538 80.91.229.3 (23 Nov 2014 04:44:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 23 Nov 2014 04:44:49 +0000 (UTC) Cc: Andreas Schwab , Emacs developers To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 23 05:44:43 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XsP2Q-0003QZ-4X for ged-emacs-devel@m.gmane.org; Sun, 23 Nov 2014 05:44:42 +0100 Original-Received: from localhost ([::1]:47652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsP2P-0004Ux-QB for ged-emacs-devel@m.gmane.org; Sat, 22 Nov 2014 23:44:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsP2C-0004Uh-RJ for emacs-devel@gnu.org; Sat, 22 Nov 2014 23:44:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XsP2B-0000AD-Oo for emacs-devel@gnu.org; Sat, 22 Nov 2014 23:44:28 -0500 Original-Received: from mail-ie0-x231.google.com ([2607:f8b0:4001:c03::231]:41400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XsP2A-00009u-9q; Sat, 22 Nov 2014 23:44:26 -0500 Original-Received: by mail-ie0-f177.google.com with SMTP id rd18so7164836iec.36 for ; Sat, 22 Nov 2014 20:44:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=Yqlc7Fb336gZmq5x8FO6O0Pz6CASgneqti9UGWDlnX4=; b=YJklKrU2GmbRrkGaROZwAs6486e531Az7P7SvBlu+W07zPOxntlrtXHgpv0nTbYvEh N6z5alwTnNro5Z4/p4kh+OLAvdRyC3Q0E20dDalmjGnXHUA/21EAy0Q5rRbsmup7lXIF 2XF1ORRVmwaGVHWc3dpXh2y8txIpjC1deVLZkWiLg7xF0t8WZa6sfyPgLNGmJebrpz9W 5LkVbtL6fslp3eygQBveTcDWhv6q2OgkRXypm2stQJNeQ90noUVZoENx+1684ZPaH6Ob CU5ni9eNHvc1jS8RIpq+Afbc6tOwLauDNDh6qxkIj+qKsRfV0WYSs+Lvy+0MT7UPw1WP d1Qg== X-Received: by 10.107.152.135 with SMTP id a129mr12229872ioe.39.1416717865591; Sat, 22 Nov 2014 20:44:25 -0800 (PST) Original-Received: by 10.107.48.82 with HTTP; Sat, 22 Nov 2014 20:44:25 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: zEfSecmcrpjMXQOxoWOAgSDMbfI X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178058 Archived-At: On Sun, Nov 23, 2014 at 5:06 AM, Glenn Morris wrote: >> This has nothing to do with the asterisk. The first paragraph of the >> log message is taken to be the summary. You get the same behaviour with >> git format-patch or git log --oneline. > > Seems dumb to me for a thing that sends out mails not to include a check > on subject length, so I'll probably attempt to patch that in. Please don=E2=80=99t. Git was designed around the patch emailing workflow. One commit is one email message. The commit message summary is the subject. The rest of the commit message is the message body. The actual diffs are either attached or included inline. The subject line=E2=80=99s role is to draw reader interest in a mailing lis= t, and to serve as an anchor for subsequent searches via the list of messages. Similarly, the commit message summary=E2=80=99s role is to draw reviewer interest, and to serve as an anchor for searches via git log and gitk. Many graphical MUAs and Git repository browsers handle long subjects and summaries just fine. Instead of arbitrarily chopping the subject line, we should all be writing commits with concise and meaningful summaries.