From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Marcin Pajkowski Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Eglot: auto-import completion item Date: Tue, 22 Nov 2022 21:26:54 +0100 Message-ID: References: <83a64pewpw.fsf@gnu.org> <87o7t09zsv.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000d02d5005ee14fe2a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4029"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 22 21:27:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxZrv-0000si-An for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Nov 2022 21:27:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxZrL-0004tD-1B; Tue, 22 Nov 2022 15:27:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxZrJ-0004sa-0i for emacs-devel@gnu.org; Tue, 22 Nov 2022 15:27:09 -0500 Original-Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxZrH-0006Dl-7s; Tue, 22 Nov 2022 15:27:08 -0500 Original-Received: by mail-pl1-x62e.google.com with SMTP id io19so14746329plb.8; Tue, 22 Nov 2022 12:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2OxYBKE3u0pE0Tn0E4ponI/E+vn8XXy4tw+DQ54INsY=; b=W9tGYnBLpaf2FLZL/mZpf5RaaYUfYmqYXd6EFGkdO++Y7Iu686r30nsy7ip9SfYdVm qUugmd3FSuJny+eyG7C4mx79Ki9kq0G8xAKAnUV4R0r5QhcctwfEhEMYOwUWpzDeEvdk 6yxfwmFR2mxbVA6QwPG5ptMCyCAZ/8t7kP+bOhJFUTKVVLOe23gjbnzWfkyboxxJuRp7 WhpSgYJ90hLqKcp9vRASuIfkU/ED/srF9AVJeiXdarVGGLiF0VBfirFzLmP0KDRifqqQ 8uPRmGzSK7Xb+40h2YY3AMRzkwuznS5I587nGkixz7Re+5/s5aTBNaMM4QasNSTEpC8z Ntyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2OxYBKE3u0pE0Tn0E4ponI/E+vn8XXy4tw+DQ54INsY=; b=baCNMEkZ0eDNmesUF66tU6nVHB9gFtEJA9aEo8lQQXLc9NIWYM4rNYfWzFFN0LjouI lBsMAWZ2XWwQ0RZbuu94vf+EbFUW9vAQ441mlKNthGUh28evMzJaAmpc1ag77XXBziZz /rBGa5TiXYXZxcG9B5AAi6ZG1vWQnfLQXpCAO1D23xqwY2/b9nO6v+ASn0xq9rHncPsc g15uIKOpFQycvsa+NKssil3EWRCGZw3+4RmiTnOmDJ+6+R/t11U3TeP5Z2MpDBrH9hJG L6HmNNfckLkKiL4g9reA4jcSPBA3ZKRosTrgm5v0mpuGFwv6Wq/oWKxOpeZVlK0nZCRI 5bVw== X-Gm-Message-State: ANoB5plK6yDN9z7mnoP39+XXxREBcnu0o4SPXGyPNAGkBm//cf8GvE8B d4dVOuFOUNzbAFgpZUd0+dPIANs/L/OA0pJUQTr2Xts0 X-Google-Smtp-Source: AA0mqf4OZxt3CPtycHDLTlKQSRGEhzOVUoXuOty25CBFnRwmbE+XFPja8q0A91kZmgqcuF8Y5unqWuzpP4sPhDBFpi8= X-Received: by 2002:a17:902:b409:b0:188:eebf:2361 with SMTP id x9-20020a170902b40900b00188eebf2361mr18760526plr.125.1669148825345; Tue, 22 Nov 2022 12:27:05 -0800 (PST) In-Reply-To: <87o7t09zsv.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=marcin.pajkowski@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300350 Archived-At: --000000000000d02d5005ee14fe2a Content-Type: multipart/alternative; boundary="000000000000d02d4a05ee14fe28" --000000000000d02d4a05ee14fe28 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jo=C3=A3o, Thanks for reviewing my patch! I added bug reference, fixed typo and sent copy of this patch to the bug tracker. Marcin pon., 21 lis 2022 o 14:55 Jo=C3=A3o T=C3=A1vora napi= sa=C5=82(a): > Marcin Pajkowski writes: > > Hi Marcin, > > the patch looks good to install, but please send it to the bug tracker > where the discussion started instead: I don't have the bug # handy. > Minor comments below my sig. > > Jo=C3=A3o > > > Subject: [PATCH] Eglot: Advertise completion.resolveSupport capabilitie= s > > > > Some servers avoid reporting completion items that require > > "additionalTextEdits" capability. Actually eglot-completion-at-point > > function supports such feature so it can be adverised to LSP server. > ^^^^^^^^^ > typo! > > Also missing a line bug#xxxxx here. > > > * lisp/progmodes/eglot.el (eglot-client-capabilities) > > Here's, you're supposed to add a ':' and then briefly state what you did > to the definition. > > Like this: > > * lisp/progmodes/eglot.el > (eglot-client-capabilities): Advertise :resolveSupport. > > > > --- > > lisp/progmodes/eglot.el | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > > index 9555d21b00..4193ee0106 100644 > > --- a/lisp/progmodes/eglot.el > > +++ b/lisp/progmodes/eglot.el > > @@ -737,6 +737,7 @@ eglot-client-capabilities > > t > > :json-false) > > :deprecatedSupport t > > + :resolveSupport (:properties > ["documentation" "details" "additionalTextEdits"]) > > Can you break this line so that it fits in under 80 columns? > > > :tagSupport (:valueSet [1])) > > :contextSupport t) > > :hover (list :dynamicRegistration :json-fals= e > > > --000000000000d02d4a05ee14fe28 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Jo=C3=A3o,

Thanks for rev= iewing my patch!

I added bug reference, fixed typo= and sent copy of this patch to the bug tracker.

M= arcin

pon., 21 lis 2022 o 14:55=C2=A0Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.co= m> napisa=C5=82(a):
Marcin Pajkowski <marcin.pajkowski@gmail.com> writes:

Hi Marcin,

the patch looks good to install, but please send it to the bug tracker
where the discussion started instead: I don't have the bug # handy.
Minor comments below my sig.

Jo=C3=A3o

> Subject: [PATCH] Eglot: Advertise completion.resolveSupport capabiliti= es
>
> Some servers avoid reporting completion items that require
> "additionalTextEdits" capability. Actually eglot-completion-= at-point
> function supports such feature so it can be adverised to LSP server. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ^^^^^^^^^
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 typo!

Also missing a line bug#xxxxx here.

> * lisp/progmodes/eglot.el (eglot-client-capabilities)

Here's, you're supposed to add a ':' and then briefly state= what you did
to the definition.

Like this:

* lisp/progmodes/eglot.el
=C2=A0 (eglot-client-capabilities): Advertise :resolveSupport.


> ---
>=C2=A0 lisp/progmodes/eglot.el | 1 +
>=C2=A0 1 file changed, 1 insertion(+)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 9555d21b00..4193ee0106 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -737,6 +737,7 @@ eglot-client-capabilities
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0t
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0:json-false)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :depr= ecatedSupport t
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :resolveSup= port (:properties ["documentation" "details" "addi= tionalTextEdits"])

Can you break this line so that it fits in under 80 columns?

>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :tagS= upport (:valueSet [1]))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 :contextSupp= ort t)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0:hover=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (list :dynamicRegistration :json-fal= se


--000000000000d02d4a05ee14fe28-- --000000000000d02d5005ee14fe2a Content-Type: text/x-patch; charset="US-ASCII"; name="Eglot-Advertise-completion.resolveSupport-capabilities.patch" Content-Disposition: attachment; filename="Eglot-Advertise-completion.resolveSupport-capabilities.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_laso3gc40 RnJvbSBiMjkwZmFjZTI3OTJiMjU0YWQ5NTY3ZDAwNzIwNWU3MTVkYTQ4MjgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJjaW4gUGFqa293c2tpIDxtYXJjaW4ucGFqa293c2tpQGdt YWlsLmNvbT4KRGF0ZTogU3VuLCAyMCBOb3YgMjAyMiAyMDowMzo1NyArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIEVnbG90OiBBZHZlcnRpc2UgY29tcGxldGlvbi5yZXNvbHZlU3VwcG9ydCBjYXBhYmls aXRpZXMKClNvbWUgc2VydmVycyBhdm9pZCByZXBvcnRpbmcgY29tcGxldGlvbiBpdGVtcyB0aGF0 IHJlcXVpcmUKImFkZGl0aW9uYWxUZXh0RWRpdHMiIGNhcGFiaWxpdHkuIEFjdHVhbGx5IGVnbG90 LWNvbXBsZXRpb24tYXQtcG9pbnQKZnVuY3Rpb24gc3VwcG9ydHMgc3VjaCBmZWF0dXJlIHNvIGl0 IGNhbiBiZSBhZHZlcnRpc2VkIHRvIExTUCBzZXJ2ZXIuCgoqIGxpc3AvcHJvZ21vZGVzL2VnbG90 LmVsCiAgKGVnbG90LWNsaWVudC1jYXBhYmlsaXRpZXMpOiBBZHZlcnRpc2UgcmVzb2x2ZVN1cHBv cnQuICAoYnVnIzU5NDY1KQotLS0KIGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIHwgNCArKysrCiAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9k ZXMvZWdsb3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAppbmRleCBiYmQ5MDJjMWM3Li5m YWIzYjFjYWMwIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy9lZ2xvdC5lbApAQCAtNzM3LDcgKzczNywxMCBAQCBlZ2xvdC1jbGllbnQtY2Fw YWJpbGl0aWVzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6anNvbi1mYWxzZSkKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOmRlcHJlY2F0ZWRTdXBwb3J0IHQK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOnJlc29sdmVTdXBwb3J0ICg6 cHJvcGVydGllcworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIFsiZG9jdW1lbnRhdGlvbiIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgImRldGFpbHMiCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJhZGRpdGlvbmFsVGV4dEVkaXRz Il0pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDp0YWdTdXBwb3J0ICg6 dmFsdWVTZXQgWzFdKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDpjb250 ZXh0U3VwcG9ydCB0KQogICAgICAgICAgICAgIDpob3ZlciAgICAgICAgICAgICAgKGxpc3QgOmR5 bmFtaWNSZWdpc3RyYXRpb24gOmpzb24tZmFsc2UKLS0KMi4zOC4xCg== --000000000000d02d5005ee14fe2a--