Hi João,

Thanks for reviewing my patch!

I added bug reference, fixed typo and sent copy of this patch to the bug
tracker.

Marcin

pon., 21 lis 2022 o 14:55 João Távora <joaotavora@gmail.com> napisał(a):

> Marcin Pajkowski <marcin.pajkowski@gmail.com> writes:
>
> Hi Marcin,
>
> the patch looks good to install, but please send it to the bug tracker
> where the discussion started instead: I don't have the bug # handy.
> Minor comments below my sig.
>
> João
>
> > Subject: [PATCH] Eglot: Advertise completion.resolveSupport capabilities
> >
> > Some servers avoid reporting completion items that require
> > "additionalTextEdits" capability. Actually eglot-completion-at-point
> > function supports such feature so it can be adverised to LSP server.
>                                               ^^^^^^^^^
>                                               typo!
>
> Also missing a line bug#xxxxx here.
>
> > * lisp/progmodes/eglot.el (eglot-client-capabilities)
>
> Here's, you're supposed to add a ':' and then briefly state what you did
> to the definition.
>
> Like this:
>
> * lisp/progmodes/eglot.el
>   (eglot-client-capabilities): Advertise :resolveSupport.
>
>
> > ---
> >  lisp/progmodes/eglot.el | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 9555d21b00..4193ee0106 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -737,6 +737,7 @@ eglot-client-capabilities
> >                                             t
> >                                           :json-false)
> >                                        :deprecatedSupport t
> > +                                      :resolveSupport (:properties
> ["documentation" "details" "additionalTextEdits"])
>
> Can you break this line so that it fits in under 80 columns?
>
> >                                        :tagSupport (:valueSet [1]))
> >                                      :contextSupport t)
> >               :hover              (list :dynamicRegistration :json-false
>
>
>