From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: Add support for base64url variant Date: Tue, 11 Jun 2019 21:14:11 +0100 Message-ID: References: <87pnobiglo.fsf@killashandra.ballybran.fr> <83r28p57jp.fsf@gnu.org> <87zhnd55eq.fsf@killashandra.ballybran.fr> <83mujd54qv.fsf@gnu.org> <87lfyr4p49.fsf@killashandra.ballybran.fr> <834l50pk1p.fsf@gnu.org> <874l4wt1dn.fsf@killashandra.ballybran.fr> <83sgsg7yln.fsf@gnu.org> <87blz4nelr.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002c1b4c058b11f28f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="117676"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs Development To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 11 22:16:07 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hanBe-000UVA-ER for ged-emacs-devel@m.gmane.org; Tue, 11 Jun 2019 22:16:06 +0200 Original-Received: from localhost ([::1]:55258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hanBd-0005ON-94 for ged-emacs-devel@m.gmane.org; Tue, 11 Jun 2019 16:16:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44927) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hanAL-0005MR-Lz for emacs-devel@gnu.org; Tue, 11 Jun 2019 16:14:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hanAK-0004sv-MU for emacs-devel@gnu.org; Tue, 11 Jun 2019 16:14:45 -0400 Original-Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:39483) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hanAE-0004qK-OY; Tue, 11 Jun 2019 16:14:39 -0400 Original-Received: by mail-oi1-x22d.google.com with SMTP id m202so9962756oig.6; Tue, 11 Jun 2019 13:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n34gjjFSC8O3LgliYjGI3NnxhQ4i1Sa14G8Dq2yPoGc=; b=ePHtJoGYUyUyiDLTwqJyDIgmcvBY+77tslav7LKIxhjkIo76pPpmTvUUiU7IPB9AzZ R3OMawz/4j8KXTGxPuY+wxyT5vfRoLGK2dkz87KlE2lVS4TAsFmWqGmcPdWvoBYEbNhG vkgbl/k97KOmckCHYUj1uil04h5XihckWB3GdwZClwIqjO5gM8Nxb14HqW4N4hzzdOnS e929SaRtGo5O+M8wT7yDWdBTWnKXzGzw8vwelbE+j1jCQABS6bC6cweepnyrW8i6Bslh SzsSRywZWAQCBNH5Z7Ja/pMguVKr6aspBieVHU2WA4P7FKW4AxotrWLe0spxofEG2Ukm fC7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n34gjjFSC8O3LgliYjGI3NnxhQ4i1Sa14G8Dq2yPoGc=; b=obOLGWfpW4amxFHIv1xtUgJnG81YNexll1GFCJgX0/k+kjl6ZAqy/C1RLfyb9j5tIf AKv2s73UAGOn1a5ctTnkhjWlWq0V/+N4lMRpBhfkhFOhvEZWq4eW3KxepSJ5yWs5GGfV z7GRd0gW4pEXjGymiIbx2zpjxUb3FqHr/OxRm7PlCWU5Wm0kZvdEGrAHm0nkxIBXnS86 HHcYkn0b91/2z88pe2pu1tnYd7uGRl6bZxRfpKQ7QKRqc+xCHMKzDEBbbWUzOCHPlQZb W6SC2qZ5Jc80hc7+PvDaZZzaa0+QSFucQSfr7IInoD6j3XMrKbpWKK8zKVURzJu+Nrew Sg6A== X-Gm-Message-State: APjAAAWyvnRkzP2ttjwXm0OqV+/m4ZT+JAc1dlJOZAMDnTX6NGcjGALd NpXG/ktDbm+/gRkVgowiqAWfftsTMPc4ouraItzPmdF3obE= X-Google-Smtp-Source: APXvYqyirqBTKGy9cVfjCTM3K7amtG0v7mYfUUyqhr7BbninLcuNYQ4V9SMB/W6a1YyAb+5qxg5YtZ+TbFIX7WPl8VI= X-Received: by 2002:aca:ea57:: with SMTP id i84mr17424984oih.117.1560284077233; Tue, 11 Jun 2019 13:14:37 -0700 (PDT) In-Reply-To: <87blz4nelr.fsf@Rainer.invalid> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237443 Archived-At: --0000000000002c1b4c058b11f28f Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: Please note that the doc strings and the manual text included a few typos, and also used the passive tense too much. See the follow-up changes I pushed after your changeset. In the future, I suggest to use the Emacs spell-checking capabilities to spell-check the text in the manual and also the comments/strings in the C/Lisp sources. Two more typos (if/of, inserts/insert): diff --git a/doc/lispref/text.texi b/doc/lispref/text.texi index 55f5269849..2e7c497f57 100644 --- a/doc/lispref/text.texi +++ b/doc/lispref/text.texi @@ -4560,8 +4560,8 @@ Base 64 @deffn Command base64url-encode-region beg end &optional no-pad This function is like @code{base64-encode-region}, but it implements -the URL variant if base 64 encoding, per RFC 4648, and it doesn't -inserts newline characters into the encoded text, so the output is +the URL variant of base 64 encoding, per RFC 4648, and it doesn't +insert newline characters into the encoded text, so the output is just one long line. If the optional argument @var{no-pad} is non-@code{nil} then this --0000000000002c1b4c058b11f28f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii writes:

=C2=A0 =C2=A0 Please note tha= t the doc strings and the manual text included a few
=C2=A0 =C2=A0 typos= , and also used the passive tense too much.=C2=A0 See the follow-up
=C2= =A0 =C2=A0 changes I pushed after your changeset.=C2=A0 In the future, I su= ggest to
=C2=A0 =C2=A0 use the Emacs spell-checking capabilities to spel= l-check the text in
=C2=A0 =C2=A0 the manual and also the comments/strin= gs in the C/Lisp sources.

Two more typos (if/of, inserts/insert):
diff --git a/doc/lispref/text.texi b/doc/lispref/text.texi
index 55= f5269849..2e7c497f57 100644
--- a/doc/lispref/text.texi
+++ b/doc/lis= pref/text.texi
@@ -4560,8 +4560,8 @@ Base 64
=C2=A0
=C2=A0@deffn C= ommand base64url-encode-region beg end &optional no-pad
=C2=A0This f= unction is like @code{base64-encode-region}, but it implements
-the URL = variant if base 64 encoding, per RFC 4648, and it doesn't
-inserts n= ewline characters into the encoded text, so the output is
+the URL varia= nt of base 64 encoding, per RFC 4648, and it doesn't
+insert newline= characters into the encoded text, so the output is
=C2=A0just one long = line.
=C2=A0
=C2=A0If the optional argument @var{no-pad} is non-= @code{nil} then this

--0000000000002c1b4c058b11f28f--