bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Claudio Bley]

Hi.

Trying to compile lisp/emacs-lisp/lisp-mode.el using MinGW GCC on
Windows 7 results in:

Compiling emacs-lisp/lisp-mode.el

In toplevel form:
emacs-lisp/lisp-mode.el:453:1:Error: Invalid read syntax: "?"

453    (defconst lisp--prettify-symbols-alist
454      '(("lambda"  . ?λ)))

Obviously because emacs reads the file with cp1152 by default instead
of UTF-8.

Furthermore, this error is not considered fatal and causes "make
bootstrap" to fail at a later stage:

*** No rule to make target `lisp/emacs-lisp/lisp-mode.elc' needed by `DOC'.

Shouldn't the compile rules exit early when byte compilation fails?

-- 
Claudio

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Juanma Barranquero]

On Tue, Jun 11, 2013 at 11:14 AM, Claudio Bley <claudio.bley@gmail.com> wrote:

> Trying to compile lisp/emacs-lisp/lisp-mode.el using MinGW GCC on
> Windows 7 results in:
>
> Compiling emacs-lisp/lisp-mode.el
>
> In toplevel form:
> emacs-lisp/lisp-mode.el:453:1:Error: Invalid read syntax: "?"

I cannot reproduce this on Window 7 with the latest trunk:

C:\...\trunk> bin\emacs.exe -batch -Q -f batch-byte-compile
lisp\emacs-lisp\lisp-mode.el
Wrote c:/Devel/emacs/repo/trunk/lisp/emacs-lisp/lisp-mode.elc

Perhaps you could try bootstrapping.

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Claudio Bley]

At Tue, 11 Jun 2013 12:09:05 +0200,
Juanma Barranquero wrote:
> 
> On Tue, Jun 11, 2013 at 11:14 AM, Claudio Bley <claudio.bley@gmail.com> wrote:
> 
> > Trying to compile lisp/emacs-lisp/lisp-mode.el using MinGW GCC on
> > Windows 7 results in:
> >
> > Compiling emacs-lisp/lisp-mode.el
> >
> > In toplevel form:
> > emacs-lisp/lisp-mode.el:453:1:Error: Invalid read syntax: "?"
> 
> I cannot reproduce this on Window 7 with the latest trunk:
> 
> C:\...\trunk> bin\emacs.exe -batch -Q -f batch-byte-compile
> lisp\emacs-lisp\lisp-mode.el
> Wrote c:/Devel/emacs/repo/trunk/lisp/emacs-lisp/lisp-mode.elc
> 
> Perhaps you could try bootstrapping.

As a matter of fact, I always do

make clean ; make boostrap

(it never really worked out just using "make")

I re-tested it anyway with the same result.

But, when setting LANG to en_US.utf-8 in the build environment it
works.

Perhaps you have something similar set in your environment?
-- 
Claudio

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Juanma Barranquero]

On Tue, Jun 11, 2013 at 1:40 PM, Claudio Bley <claudio.bley@gmail.com> wrote:

> But, when setting LANG to en_US.utf-8 in the build environment it
> works.
>
> Perhaps you have something similar set in your environment?

I have LANG=C

Are you using the nt/configure.bat build or the new MSYS one?

    J

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Claudio Bley]

At Tue, 11 Jun 2013 13:58:38 +0200,
Juanma Barranquero wrote:
> 
> On Tue, Jun 11, 2013 at 1:40 PM, Claudio Bley <claudio.bley@gmail.com> wrote:
> 
> > But, when setting LANG to en_US.utf-8 in the build environment it
> > works.
> >
> > Perhaps you have something similar set in your environment?
> 
> I have LANG=C

Astonishingly, this works too. Try unsetting it to trigger the error.

> Are you using the nt/configure.bat build or the new MSYS one?

I'm using the old configure.bat approach.

-- 
Claudio

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Stefan Monnier]

> 453    (defconst lisp--prettify-symbols-alist
> 454      '(("lambda"  . ?λ)))

> Obviously because emacs reads the file with cp1152 by default instead
> of UTF-8.

I think I just fixed it on the trunk.

> *** No rule to make target `lisp/emacs-lisp/lisp-mode.elc' needed by `DOC'.
> Shouldn't the compile rules exit early when byte compilation fails?

Yes (modulo "make -k" obviously).


        Stefan

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Claudio Bley]

At Tue, 11 Jun 2013 08:52:30 -0400,
Stefan Monnier wrote:
> 
> > 453    (defconst lisp--prettify-symbols-alist
> > 454      '(("lambda"  . ?λ)))
> 
> > Obviously because emacs reads the file with cp1152 by default instead
> > of UTF-8.
> 
> I think I just fixed it on the trunk.

Thanks, works for me.

> > *** No rule to make target `lisp/emacs-lisp/lisp-mode.elc' needed by `DOC'.
> > Shouldn't the compile rules exit early when byte compilation fails?
> 
> Yes (modulo "make -k" obviously).

OK, how about

---------------- 8< --------------- 8< --------------------------
diff --git a/lisp/makefile.w32-in b/lisp/makefile.w32-in
index f4bbaf3..6c1a49c 100644
--- a/lisp/makefile.w32-in
+++ b/lisp/makefile.w32-in
@@ -298,12 +298,12 @@ TAGS-LISP-SH: $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lisptagsfi
 
 TAGS-CMD: $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lisptagsfiles4)
 	- $(DEL) TAGS
-	for %%d in (. $(WINS_UPDATES)) do $(ETAGS) -a $(lisp)/%%d/*.el
+	for %%d in (. $(WINS_UPDATES)) do ( $(ETAGS) -a $(lisp)/%%d/*.el || exit 1 )
 
 TAGS-LISP-CMD: $(lisptagsfiles1) $(lisptagsfiles2) $(lisptagsfiles3) $(lisptagsfiles4)
 	- $(DEL) $(DEST)/TAGS-LISP
 	for %%d in (. $(WINS_UPDATES)) do \
-	  $(ETAGS) -a -o $(DEST)/TAGS-LISP $(lisp)/%%d/*.el
+	  ( $(ETAGS) -a -o $(DEST)/TAGS-LISP $(lisp)/%%d/*.el || exit 1 )
 
 .SUFFIXES: .elc .el
 
@@ -328,29 +328,29 @@ compile: $(lisp)/subdirs.el compile0-$(SHELLTYPE) compile1-$(SHELLTYPE) compile2
 compile0-CMD: autoloads
 #	-for %%f in ($(lisp) $(WINS)) do for %%g in (%%f\*.elc) do @attrib -r %%g
 	for %%f in ($(COMPILE_FIRST)) do \
-	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f
+	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f || exit 1
 
 compile1-CMD: autoloads compile0-CMD
 	for %%f in (. $(WINS_BASIC1)) do for %%g in (%%f/*.el) do \
-	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g
+	  ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile2-CMD: autoloads compile0-CMD
 	for %%f in ($(WINS_BASIC2)) do for %%g in (%%f/*.el) do \
-	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g
+	  ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile3-CMD: autoloads compile0-CMD
 	for %%f in ($(WINS_BASIC3)) do for %%g in (%%f/*.el) do \
-	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g
+	  ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile4-CMD: autoloads compile0-CMD
 	for %%f in ($(WINS_BASIC4) $(WINS_CEDET) term obsolete) do for %%g in (%%f/*.el) do \
-	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g
+	  ( $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done %%f/%%g || exit 1 )
 
 compile0-SH: autoloads
 #	for elc in $(lisp)/*.elc $(lisp)/*/*.elc; do attrib -r $$elc; done
 	for el in $(COMPILE_FIRST); do \
 	  echo Compiling $$el; \
-	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el; \
+	  $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el || exit 1; \
 	done
 
 compile1-SH: autoloads compile0-SH
@@ -359,7 +359,7 @@ compile1-SH: autoloads compile0-SH
 	    if test -f $$el; \
 	    then \
 	      echo Compiling $$el; \
-	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el; \
+	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el || exit 1; \
 	    fi \
 	  done; \
 	done
@@ -370,7 +370,7 @@ compile2-SH: autoloads compile0-SH
 	    if test -f $$el; \
 	    then \
 	      echo Compiling $$el; \
-	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el; \
+	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el || exit 1; \
 	    fi \
 	  done; \
 	done
@@ -381,7 +381,7 @@ compile3-SH: autoloads compile0-SH
 	    if test -f $$el; \
 	    then \
 	      echo Compiling $$el; \
-	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el; \
+	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el || exit 1; \
 	    fi \
 	  done; \
 	done
@@ -392,7 +392,7 @@ compile4-SH: autoloads compile0-SH
 	    if test -f $$el; \
 	    then \
 	      echo Compiling $$el; \
-	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el; \
+	      $(emacs) -l loaddefs $(BYTE_COMPILE_FLAGS) -f batch-byte-compile-if-not-done $$el || exit 1; \
 	    fi \
 	  done; \
 	done
@@ -405,8 +405,8 @@ compile-always: $(lisp)/subdirs.el compile-always-$(SHELLTYPE) doit
 
 compile-always-CMD:
 #	-for %%f in ($(lisp) $(WINS)) do for %%g in (%%f\*.elc) do @attrib -r %%g
-	for %%f in ($(COMPILE_FIRST)) do $(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f
-	for %%f in (. $(WINS)) do for %%g in (%%f/*.el) do $(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f/%%g
+	for %%f in ($(COMPILE_FIRST)) do ( $(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f || exit 1 )
+	for %%f in (. $(WINS)) do for %%g in (%%f/*.el) do ( $(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f/%%g || exit 1 )
 
 compile-always-SH:
 #	for elc in $(lisp)/*.elc $(lisp)/*/*.elc; do attrib -r $$elc; done
@@ -424,7 +424,7 @@ compile-always-SH:
 compile-calc: compile-calc-$(SHELLTYPE)
 
 compile-calc-CMD:
-	for %%f in ($(lisp)/calc/*.el) do $(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f
+	for %%f in ($(lisp)/calc/*.el) do ( $(emacs) $(BYTE_COMPILE_FLAGS) -f batch-byte-compile %%f || exit 1 )
 
 compile-calc-SH:
 	for el in $(lisp)/calc/*.el; do \
@@ -593,15 +593,15 @@ install:
 # since cp does not preserve time stamps
 install-lisp-SH:
 	cp -f *.el "$(INSTALL_DIR)/lisp"
-	for dir in $(WINS); do [ -d "$(INSTALL_DIR)/lisp/$$dir" ] || mkdir "$(INSTALL_DIR)/lisp/$$dir"; done
-	for dir in $(WINS); do cp -f $$dir/*.el "$(INSTALL_DIR)/lisp/$$dir"; done
-	for dir in . $(WINS); do cp $$dir/*.elc "$(INSTALL_DIR)/lisp/$$dir"; done
+	for dir in $(WINS); do [ -d "$(INSTALL_DIR)/lisp/$$dir" ] || mkdir "$(INSTALL_DIR)/lisp/$$dir" || exit 1; done
+	for dir in $(WINS); do cp -f $$dir/*.el "$(INSTALL_DIR)/lisp/$$dir" || exit 1; done
+	for dir in . $(WINS); do cp $$dir/*.elc "$(INSTALL_DIR)/lisp/$$dir" || exit 1; done
 
 install-lisp-CMD:
 	cp -f *.el "$(INSTALL_DIR)/lisp"
-	for %%f in ($(WINS)) do if not exist "$(INSTALL_DIR)/lisp/%%f" mkdir "$(INSTALL_DIR)/lisp/%%f"
-	for %%f in ($(WINS)) do cp -f %%f/*.el "$(INSTALL_DIR)/lisp/%%f"
-	for %%f in (. $(WINS)) do cp -f %%f/*.elc "$(INSTALL_DIR)/lisp/%%f"
+	for %%f in ($(WINS)) do if not exist "$(INSTALL_DIR)/lisp/%%f" ( mkdir "$(INSTALL_DIR)/lisp/%%f" || exit 1 )
+	for %%f in ($(WINS)) do ( cp -f %%f/*.el "$(INSTALL_DIR)/lisp/%%f" || exit 1 )
+	for %%f in (. $(WINS)) do ( cp -f %%f/*.elc "$(INSTALL_DIR)/lisp/%%f" || exit 1 )
 
 # WARNING: Do NOT split the part inside $(ARGQUOTE)s into multiple lines as
 #          this can break with GNU Make 3.81 and later if sh.exe is used.
---------------- 8< --------------- 8< --------------------------

But, sure enough, compilation then fails with

Compiling textmodes/rst.el

In toplevel form:
textmodes/rst.el:320:1:Error: Variable binding depth exceeds max-specpdl-size
mingw32-make[1]: *** [compile3-SH] Error 1
mingw32-make[1]: Leaving directory `C:/Users/Claudio/src/emacs/lisp'
mingw32-make: *** [bootstrap-gmake] Error 2

Is this expected? Should I increase max-specpdl-size somehow?

-- 
Claudio

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Claudio Bley]

At Wed, 12 Jun 2013 09:14:16 +0200,
Claudio Bley wrote:
> 
> But, sure enough, compilation then fails with
> 
> Compiling textmodes/rst.el
> 
> In toplevel form:
> textmodes/rst.el:320:1:Error: Variable binding depth exceeds max-specpdl-size
> mingw32-make[1]: *** [compile3-SH] Error 1
> mingw32-make[1]: Leaving directory `C:/Users/Claudio/src/emacs/lisp'
> mingw32-make: *** [bootstrap-gmake] Error 2
> 
> Is this expected? Should I increase max-specpdl-size somehow?

Setting max-specpdl-size to 2600 lets the compilation finish
successfully. (I haven't determined the exact minimum, 2500 was not
sufficient)

-- 
Claudio

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Eli Zaretskii]

> From: claudio.bley@gmail.com (Claudio Bley)
> Date: Wed, 12 Jun 2013 09:14:16 +0200
> 
> > > *** No rule to make target `lisp/emacs-lisp/lisp-mode.elc' needed by `DOC'.
> > > Shouldn't the compile rules exit early when byte compilation fails?
> > 
> > Yes (modulo "make -k" obviously).
> 
> OK, how about
> 
> ---------------- 8< --------------- 8< --------------------------
> diff --git a/lisp/makefile.w32-in b/lisp/makefile.w32-in
> index f4bbaf3..6c1a49c 100644
> --- a/lisp/makefile.w32-in
> +++ b/lisp/makefile.w32-in

Thanks.  However, the makefile.w32-in files, configure.bat, and the
related files are deprecated; you are encouraged to switch to the
Posix build system described in nt/INSTALL.MSYS.  For that reason, I'd
prefer not to invest any effort in maintaining, let alone improving,
the deprecated scripts, unless you or someone else who wants to use
them will take full responsibility for maintaining them, reviewing
patches, solving problems, etc.  (I think this would be a waste of
resources even in that case, but I won't fight people who have enough
motivation to do that.)

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Claudio Bley]

At Wed, 12 Jun 2013 19:40:24 +0300,
Eli Zaretskii wrote:
> 
> > From: claudio.bley@gmail.com (Claudio Bley)
> > Date: Wed, 12 Jun 2013 09:14:16 +0200
> > 
> > > > *** No rule to make target `lisp/emacs-lisp/lisp-mode.elc' needed by `DOC'.
> > > > Shouldn't the compile rules exit early when byte compilation fails?
> > > 
> > > Yes (modulo "make -k" obviously).
> > 
> > OK, how about
> > 
> > ---------------- 8< --------------- 8< --------------------------
> > diff --git a/lisp/makefile.w32-in b/lisp/makefile.w32-in
> > index f4bbaf3..6c1a49c 100644
> > --- a/lisp/makefile.w32-in
> > +++ b/lisp/makefile.w32-in
> 
> Thanks.  However, the makefile.w32-in files, configure.bat, and the
> related files are deprecated; you are encouraged to switch to the
> Posix build system described in nt/INSTALL.MSYS.

Does this mean you changed your mind? ;-)

,----
| I won't touch MSYS with a 3-mile stick.
`----

http://lists.gnu.org/archive/html/emacs-devel/2011-01/msg00666.html

> For that reason, I'd prefer not to invest any effort in maintaining,
> let alone improving, the deprecated scripts

Fair enough. It's just that I'm lazy... As long as it is there (and
works for me) I probably stick with configure.bat et al. Well, maybe
I'll check out the MSYS build (which likely will have its own
problems) anyway. What's more, autoconf and friends is crawlingly slow
on w32...

-- 
Claudio

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Eli Zaretskii]

> From: claudio.bley@gmail.com (Claudio Bley)
> Date: Thu, 13 Jun 2013 08:21:21 +0200
> 
> > Thanks.  However, the makefile.w32-in files, configure.bat, and the
> > related files are deprecated; you are encouraged to switch to the
> > Posix build system described in nt/INSTALL.MSYS.
> 
> Does this mean you changed your mind? ;-)

Obviously.  One is entitled to that once in a few years, don't you
think?

> I'll check out the MSYS build (which likely will have its own
> problems) anyway.

The bonus is that problems with the MSYS build can be understood by
more than just one or two persons here.

> What's more, autoconf and friends is crawlingly slow on w32...

Due to GNUmakefile there, you won't be running the configure script
except when really needed.

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Stefan Monnier]

> problems) anyway. What's more, autoconf and friends is crawlingly slow
> on w32...

But to make up for it, the resulting makefiles:
- support running compilation processes in parallel.
- compile most Elisp files with a compiled (rather than interpreted)
  byte-compiler.
so the overall compilation time can be significantly shorter, especially if
your machine is multiprocessor.


        Stefan

Re: bzr commit 112856 (Symbol prettify in prog-mode; added to perl-mode, cfengine3-mode, and emacs-lisp-mode) breaks compilation on w32

[Richard Copley]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

On 13 June 2013 15:25, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > problems) anyway. What's more, autoconf and friends is crawlingly slow
> > on w32...
>
> But to make up for it, the resulting makefiles:
> - support running compilation processes in parallel.
> - compile most Elisp files with a compiled (rather than interpreted)
>   byte-compiler.
> so the overall compilation time can be significantly shorter, especially if
> your machine is multiprocessor.
>
Yes, that's absolutely true, even if you take into account the time for
`configure' and `make install'. It's awesome. Many thanks to Eli and
everyone.

[-- Attachment #2: Type: text/html, Size: 1065 bytes --]