From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: Improve reporting of I/O, access errors for Emacs Date: Wed, 18 Sep 2019 10:50:22 +0100 Message-ID: References: <83d0g51jdp.fsf@gnu.org> <83a7b91f6l.fsf@gnu.org> <8336h01wa7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000095d0110592d0c5d0" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="83233"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , Emacs Development To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 18 11:52:31 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAWdS-000LWI-OQ for ged-emacs-devel@m.gmane.org; Wed, 18 Sep 2019 11:52:30 +0200 Original-Received: from localhost ([::1]:56672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAWdQ-0008UI-Bf for ged-emacs-devel@m.gmane.org; Wed, 18 Sep 2019 05:52:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58895) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAWbt-0008Qe-Lq for Emacs-devel@gnu.org; Wed, 18 Sep 2019 05:50:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAWbs-00051Y-KS for Emacs-devel@gnu.org; Wed, 18 Sep 2019 05:50:53 -0400 Original-Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]:42376) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAWbr-00050O-7D; Wed, 18 Sep 2019 05:50:51 -0400 Original-Received: by mail-oi1-x235.google.com with SMTP id i185so5412266oif.9; Wed, 18 Sep 2019 02:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1m5G3Q1Of0RbnyhAaJxoYhqUin9Nookm9CC1FBWuV5Q=; b=uLJS7aGG2J/Tf7RuCp7NHFqq7HtAxzOjeNFyOgZN8xfSESQFMBci49SpQz8ADaeeWI sp7MxPh9YlmXXBiM9isjkUgHSngmIlEMBKe8ivggaDcpWiQORjPAaJxdhTTFczm7hxDa lpM3UDloXpYQVOh/sCo9hSK9I7q4xLbdooQ+q75XMvCpuRKwT8AndTrYxaFZtfsF679n 124L3ipbbcvWnvHxEXjJuFOHgjNhUbUmSrdVxN9O/Qe5qzkWs/EjSbHbyaAZuIzAzWkZ PcCQHGa+wuD7uhHal0CNiHuqfAVysw/gcXBWNC+IH7HB+ns74oV/wAmo254A76l16/r7 k2qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1m5G3Q1Of0RbnyhAaJxoYhqUin9Nookm9CC1FBWuV5Q=; b=ELDrYxZF2EeA5fK+/EYvhNT9NKp3lH3rQWSdFvaTO0fJzU5vMEjn9n8uTGeo79yV4A lvrsxWvZig6AzNaNSFwaxHsPIxmAsLryL0smFC1xemKKPCtL5hmTen6Y/sEqAbgtJZ+B mOPKFkefNUE+u/9WI9pBXHbht+tZPJzVHnM1rAswMvc1ixEJYGpct21yB+0WE+f7ssqB N7w31T+VACA9vVc6I2rxUyWyNcRoh1DtN5XtwM0GD2Pb3QnJm4kcK90KTQMi0XekyH8T q9P1BRb2ZtjvxbJm9pcqscZHDSaRsFAsCMnpPER8h8cLaNtFFf0wJRXv3szAb2K0dzVj 43OQ== X-Gm-Message-State: APjAAAXGjnQ3Cofnj7MXZp4Q0KGq/z8J1VIn0vgd680GFCc2++3wnnMk sLhBoZlP7BcWahi3jr8UXFGxB7EXnisOi6OK1rI= X-Google-Smtp-Source: APXvYqyL6r+vvSR3VIPsFvOZjbJjEJtXOA/EbB+6itmRbjCio59VrWOfydA5oNKIh/JlqAfrqIx5ruCFiU+rHPc13tI= X-Received: by 2002:aca:dbd7:: with SMTP id s206mr1614008oig.79.1568800249334; Wed, 18 Sep 2019 02:50:49 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240127 Archived-At: --00000000000095d0110592d0c5d0 Content-Type: text/plain; charset="UTF-8" On Wed, 18 Sep 2019 at 03:26, Paul Eggert wrote: > On 9/13/19 12:37 AM, Eli Zaretskii wrote: > > My point was that in the > > code of the primitive itself, we have all the information to decide > > whether or not to signal an error; but on lower levels, we don't have > > enough context to make such decisions, so we should only return an > > error indication from those lower levels. > > OK, thanks for clarifying. I reworked the patch along the lines that you > suggested, and installed it into master. > The Windows build is broken again. It seems likely one of the recent commits affecting file error codes is the culprit. The build fails here: rm -f bootstrap-emacs.pdmp ./temacs --batch -l loadup --temacs=pbootstrap emacs: Testing file: Permission denied, c:/projects/emacs/share/emacs/27.0.50/etc/NEWS make[1]: *** [Makefile:817: bootstrap-emacs.pdmp] Error 1 make[1]: Leaving directory '/c/projects/emacs/src' --00000000000095d0110592d0c5d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, 18 Sep 2019 at 03:26, Paul Eggert <eggert@cs.ucla.edu> wrote:
On 9/13/19 12:37 AM, Eli Zaretskii wr= ote:
> My point was that in the
> code of the primitive itself, we have all the information to decide > whether or not to signal an error; but on lower levels, we don't h= ave
> enough context to make such decisions, so we should only return an
> error indication from those lower levels.

OK, thanks for clarifying. I reworked the patch along the lines that you suggested, and installed it into master.

The= Windows build is broken again. It seems likely one of the recent commits a= ffecting file error codes is the culprit. The build fails here:
rm -f bootstrap-emacs.pdmp
./temacs --batch =C2=A0-l loadup = --temacs=3Dpbootstrap
emacs: Testing file: Permission denied, c:/project= s/emacs/share/emacs/27.0.50/etc/NEWS
make[1]: *** [Makefile:817: bootstr= ap-emacs.pdmp] Error 1
make[1]: Leaving directory '/c/projects/emacs= /src'

--00000000000095d0110592d0c5d0--