From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Tue, 4 Jul 2017 17:35:16 +0100 Message-ID: References: <83y3s9pm2a.fsf@gnu.org> <83zicmntaq.fsf@gnu.org> <83van9o6l8.fsf@gnu.org> <83mv8knuhi.fsf@gnu.org> <83fuecnr4p.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1499186210 30237 195.159.176.226 (4 Jul 2017 16:36:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 16:36:50 +0000 (UTC) Cc: Eli Zaretskii , james@jojojames.com, Emacs developers To: Filipe Silva Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 04 18:36:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSQoY-0007KR-BN for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 18:36:38 +0200 Original-Received: from localhost ([::1]:42265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSQod-0000z4-PO for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 12:36:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSQnn-0000y9-8T for emacs-devel@gnu.org; Tue, 04 Jul 2017 12:35:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSQnm-0004xZ-9T for emacs-devel@gnu.org; Tue, 04 Jul 2017 12:35:51 -0400 Original-Received: from mail-ua0-x236.google.com ([2607:f8b0:400c:c08::236]:35988) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSQnk-0004wE-OP; Tue, 04 Jul 2017 12:35:48 -0400 Original-Received: by mail-ua0-x236.google.com with SMTP id g40so129613400uaa.3; Tue, 04 Jul 2017 09:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oIsZ7VAOUX7xq6b8hU+gcU9wcwQpuw+/ApzYrdTkrAs=; b=oQ8OXJRIuT5Qt03KjMt+ixegr7RXBTwrbV4aaKR+fmKV/UrhgWtY7D7+mSkIv1Y7B9 YkMKnTwa1tN9jiD0uRLHQfI8Ks5sxGLa7HFgEY8TVY4a82GbiQfYtdoR4sFKXxWjyifi K+Esfka4WVtf27KmeZm3i9SAYwqfqMe0fbtuB9P5ZGTvDpPlMpoIBpH+6S/eR3w3aIi+ tuRg/XKuz8jdrH+1t7KoB6B/ZAPG/BwKrpec/fNSotOQKAq9GvuRpitDhSMUWhpjtddp P0LprYHlK2b5D4urUEPp/YiH/3ORrnGHdnSp2DY2Yr4Oukq+KNqlN2sajclBXQmdlr7G Staw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oIsZ7VAOUX7xq6b8hU+gcU9wcwQpuw+/ApzYrdTkrAs=; b=KIG7QPjFMV7j1DqX1WMsCoCd1D+ABk4l4MnzJ9DncryIc7301X8SuFQfzJXbOwemos uYgIqqknWKtyvDQ0KEg+DZ8bCzh7GcwwkHc2y/RgOjRjdf+TZbhzIhBuFgPhKNtQCl6s 59zqkVyE5J9s458EKQ5hcbCKNuibVPDMCVMt6wc35A0l+cwYWf9FBphMX8rnoMm8BeaT D9Rl2Glq6dPIjGibJKszWPJstMgVhiAwq9xSguxl+ruurNb3zjCbI/4eDjAyTT5gzOw7 LUum50daZL+1cUR494o1hDPVLpVsFIL2h/s/10r/TYaPuVVEu/qM0Z+D73ULcnmc0NaU LzdA== X-Gm-Message-State: AKS2vOz1iAHIUPTK+pEWrpETGhiOn0I5nRy0W2LlP42A/4oN0VCLm48h bVZciWrA/bcqSfxNNaJvenlEQGHdAw== X-Received: by 10.176.2.22 with SMTP id 22mr25006904uas.0.1499186146652; Tue, 04 Jul 2017 09:35:46 -0700 (PDT) Original-Received: by 10.176.78.1 with HTTP; Tue, 4 Jul 2017 09:35:16 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c08::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216161 Archived-At: On 3 July 2017 at 16:24, Eli Zaretskii wrote: > Maybe with C-n/C-p people will expect what you expected in the case of > line numbers (but I'd like to hear more opinions before I'm convinced > to change the code to do that) In my opinion it is important for the column position resulting from C-n and C-p to be simple and predictable. I often rely on those commands in keyboard macros. A simple example: C-d 0 C-b C-n C-d 1 C-b C-n C-d 2 C-p C-p This is supposed to change the character at point to 0 and the characters in the corresponding column in the next two lines to 1 and 2. I think that's a common use case and it won't work if display-line-numbers is on ... Or will it? I'm afraid I got quite confused trying to test this. I think I found a different bug. Recipe: Open xdisp.c and go to line 30, column 30. Type "C-d C-n C-d C-n C-d C-n C-d C-n" The first C-n goes to column 30 on line 31 as expected. The 2nd C-n goes to column 29 on line 31 (expected column 30). The 3rd C-n goes to column 28 on line 31 (expected 30 (or 29?)). The 4th C-n goes to column 27 on line 31. Not sure if this is the same on master. On 4 July 2017 at 17:22, Filipe Silva wrote: > hehe thaks Eli. Are you sure you pushed your commit? > > On Jul 4, 2017 12:44 PM, "Eli Zaretskii" wrote: >> >> > From: Filipe Silva >> > Date: Tue, 4 Jul 2017 11:50:23 -0300 >> > Cc: James Nguyen , Emacs developers >> > >> > >> > In my testing, I found that when point is on line 1, everything is fine. >> > As you go down line by line, the >> > line-number-current-face skips ahead by one so by the time point is on >> > line 10, line-number-current-line face >> > is really acting on a number 9 lines below what should be the current >> > line. >> >> Ha-ha, what a stupid bug! Thanks, now fixed.