From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Richard Copley Newsgroups: gmane.emacs.devel Subject: Re: CSS contrast (#30295) (was Re: Heads-up: Emacs 26.1 RC1) Date: Tue, 20 Mar 2018 19:02:27 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000040f0a0567dcb9ba" X-Trace: blaine.gmane.org 1521572475 3164 195.159.176.226 (20 Mar 2018 19:01:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Mar 2018 19:01:15 +0000 (UTC) Cc: John Wiegley , Tom Tromey , Emacs Development To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 20 20:01:11 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eyMVS-0000jw-Ku for ged-emacs-devel@m.gmane.org; Tue, 20 Mar 2018 20:01:10 +0100 Original-Received: from localhost ([::1]:51393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyMXV-0005pw-U9 for ged-emacs-devel@m.gmane.org; Tue, 20 Mar 2018 15:03:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyMXK-0005oA-LH for emacs-devel@gnu.org; Tue, 20 Mar 2018 15:03:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyMXJ-00067o-Ln for emacs-devel@gnu.org; Tue, 20 Mar 2018 15:03:06 -0400 Original-Received: from mail-ot0-x235.google.com ([2607:f8b0:4003:c0f::235]:36689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyMXD-00065P-BK; Tue, 20 Mar 2018 15:02:59 -0400 Original-Received: by mail-ot0-x235.google.com with SMTP id 108-v6so2952378otv.3; Tue, 20 Mar 2018 12:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=IC33OadBJkrGu2CaaX7IFVDnbrkU8WER5OKkqsPF/K0=; b=eqvsofcBwWdDE7c3k9xso8VFgChE977EPAwSlxxNqTyVtf2vwTnV2VOstih0XT/16p Y57q2DE0sUdaFp0wHRpa/sDsJTzdNUpeYEDvG9mLUn3ctGFfvqh/jXVirV3VjXkyokKB 7VPuXty4uKnKHyhh7P0M4tECRhBZscwn60GzV5PExUF40nIuRplXhETfyGln/a5OP6Ng DQG8AftdHsR4sCCCHengVoJ3FNpLWLMukkWpehAuGRPYBNLliWnydfZALjc/XWiF/MWk VmWQCfeA2bha/9N8fdffhB0ZjWHEJcyOa5W88ReIsm6htF+f/r5YhWGOsts6i3Px6U55 MLIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=IC33OadBJkrGu2CaaX7IFVDnbrkU8WER5OKkqsPF/K0=; b=cRGcF8GLuhE2awojK5aP42Gl1zwFlVjksXBQD0ZOKyG7MjT+IGv939XVpsNSRpXwbt TPaMS+viVUsyuNDWYIkuuuHGde8OaSdBuutMfAIjbww2Anuj8pnc8RvgQCVbLTpLZWYU 5U5WX6rLnS399+bQ35x/zHTzIEyKL44eYpmTSLdkqqtO9a6f5u87fEXFbejJn0KOA59+ pBmvcHKIQl5y45my7FPiGFB0jYgzrOUDE/hoFNuSZBi3wPK0l6wLfqREovj5g3M/Kdyl qbPLMk8FfInRNhOLkQSDTQRv7nXMVsft2TOS790sewZilaLZgsaS1C9tTpdIGetMVv9J rScg== X-Gm-Message-State: AElRT7G4hpNZ/zMUHeRvn9oIELvGbUJO+yu3H9FsMy3k+eB7jgEgcHWm JjHxoJFiLrdOBViu5kZjXkFdWiUZelWLDanA/OC35A== X-Google-Smtp-Source: AIpwx49tyeRLrQeM/TiwNznSml2kgnkL71Nvx+RVRohRsGRMbyib3rAX59fHZcsA7a1HoSvUJqy2h3EIng3xdanHjec= X-Received: by 2002:a9d:4544:: with SMTP id p4-v6mr2425438oti.337.1521572578068; Tue, 20 Mar 2018 12:02:58 -0700 (PDT) Original-Received: by 2002:a9d:4c87:0:0:0:0:0 with HTTP; Tue, 20 Mar 2018 12:02:27 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c0f::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223860 Archived-At: --000000000000040f0a0567dcb9ba Content-Type: text/plain; charset="UTF-8" On 20 March 2018 at 07:08, Eli Zaretskii wrote: > > From: Richard Copley > > Date: Mon, 19 Mar 2018 21:33:12 +0000 > > Cc: John Wiegley , Emacs Development , > Tom Tromey > > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30295#11 > > > > Please try this in CSS mode: > > > > div: { > > #87e087 > > } > > > > I hope you'll agree it's bad > > Actually, doesn't look too bad here. > > > It's also easy and safe to fix. > > I don't see any proposed patches in the bug report. What did I miss? > VVVVVVVVVVV > > As ever I'm reluctant to provide a patch (though I do have one and I'll > certainly be using it), because I haven't > > assigned copyright, but I did make concrete suggestions for a fix. > > If someone can present a patch, I promise to review it. > > Thanks. > I can implement both suggestions (only one would be needed); they will be one- or two-line changes which hopefully qualify as "tiny" for contribution policy purposes. Years ago I had a few lines of code accepted into the build system: commit 6c0a9ed1b100c4dfbac327e6405396f1586267eb Author: Richard Copley Date: Fri Jun 7 11:08:29 2013 +0300 Fix bug #14513 with --enable-locallisppath not working on MS-Windows. Back then you (Eli) told me my limit was "all but exhausted" IIRC, but that code has been improved or superseded and only a vestige of it remains in Emacs. Would that be OK? Sincerely, apologies for the hassle. --000000000000040f0a0567dcb9ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On 20 March 2018 at 07:08, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Richard Copl= ey <rcopley@gmail.com>
> Date: Mon, 19 Mar 2018 21:33:12 +0000
> Cc: John Wiegley <johnw@gnu.org>, Emacs Development <emacs-d= evel@gnu.org>, Tom Tromey <tom@= tromey.com>
>
> https://debbugs.gnu.org/cgi/bugrep= ort.cgi?bug=3D30295#11
>
> Please try this in CSS mode:
>
> div: {
>=C2=A0 =C2=A0#87e087
> }
>
> I hope you'll agree it's bad

Actually, doesn't look too bad here.
<= /span>


=C2=A0
> It's also easy and safe to fix.

I don't see any proposed patches in the bug report.=C2=A0 What d= id I miss?

VVVVVVVVVVV
=C2=A0
> As ever I'm reluctant to provide a patch (though I do have one and= I'll certainly be using it), because I haven't
> assigned copyright, but I did make concrete suggestions for a fix.

If someone can present a patch, I promise to review it.

Thanks.

I can implement both suggestions (only one wou= ld be needed); they will
be one- or two-line changes which hopefully qua= lify as "tiny" for
contribution policy purposes.

Years = ago I had a few lines of code accepted into the build system:

commit= 6c0a9ed1b100c4dfbac327e6405396f1586267eb
Author: Richard Copley <rcopley@gmail.com>
Date:=C2=A0= =C2=A0 Fri Jun 7 11:08:29 2013 +0300
Fix bug #14513 with --enable-locall= isppath not working on MS-Windows.

Back then you (Eli) told me my li= mit was "all but exhausted" IIRC, but
that code has been impro= ved or superseded and only a vestige of it
remains in Emacs.

Would that be OK?
Sincerely, apologies for the hassle.

--000000000000040f0a0567dcb9ba--