unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Takafumi Arakaki <aka.tkf@gmail.com>
To: emacs-devel@gnu.org
Subject: [PATCH] Fix bug #11469; treat port number when expanding URL
Date: Thu, 20 Dec 2012 21:16:00 +0100	[thread overview]
Message-ID: <CAPM+gBQWFhZ4-RJeENYpyGn-Vix_HgkLKr+Ri0P+0c18cMDfOA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi,

This is a patch to fix #12374
24.1.50; Incorrect redirect in url-retrieve when URL contains port number
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12374

Best,
Takafumi

[-- Attachment #2: 0001-Fix-bug-12374-treat-port-number-when-expanding-URL.patch --]
[-- Type: application/octet-stream, Size: 1074 bytes --]

From c0ca5cba23342591aae279fe91e8809ebfe128a6 Mon Sep 17 00:00:00 2001
From: Takafumi Arakaki <aka.tkf@gmail.com>
Date: Thu, 20 Dec 2012 21:02:48 +0100
Subject: [PATCH] Fix bug #12374; treat port number when expanding URL

Previously "(url-port defobj)" was not used as "(url-port urlobj)"
returns non-nil always.
---
 lisp/url/url-expand.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lisp/url/url-expand.el b/lisp/url/url-expand.el
index 4bf13f4..8a6dc2b 100644
--- a/lisp/url/url-expand.el
+++ b/lisp/url/url-expand.el
@@ -112,7 +112,7 @@ path components followed by `..' are removed, along with the `..' itself."
       ;; Well, they told us the scheme, let's just go with it.
       nil
     (setf (url-type urlobj) (or (url-type urlobj) (url-type defobj)))
-    (setf (url-port urlobj) (or (url-port urlobj)
+    (setf (url-port urlobj) (or (url-portspec urlobj)
                                 (and (string= (url-type urlobj)
                                               (url-type defobj))
 				     (url-port defobj))))
-- 
1.7.5.4


             reply	other threads:[~2012-12-20 20:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 20:16 Takafumi Arakaki [this message]
2012-12-21 17:20 ` [PATCH] Fix bug #11469; treat port number when expanding URL Takafumi Arakaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPM+gBQWFhZ4-RJeENYpyGn-Vix_HgkLKr+Ri0P+0c18cMDfOA@mail.gmail.com \
    --to=aka.tkf@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).