From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sebastian Wiesner Newsgroups: gmane.emacs.devel Subject: checkdoc-current-buffer prints to stdout?! Date: Sat, 6 Jun 2015 12:21:04 +0200 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b86ccfc1be53e0517d6c4a1 X-Trace: ger.gmane.org 1433586081 10959 80.91.229.3 (6 Jun 2015 10:21:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Jun 2015 10:21:21 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 06 12:21:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z1BE3-0005pC-LR for ged-emacs-devel@m.gmane.org; Sat, 06 Jun 2015 12:21:15 +0200 Original-Received: from localhost ([::1]:51221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1BE2-0001N5-QD for ged-emacs-devel@m.gmane.org; Sat, 06 Jun 2015 06:21:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1BDy-0001N0-J8 for emacs-devel@gnu.org; Sat, 06 Jun 2015 06:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1BDt-0005AJ-J8 for emacs-devel@gnu.org; Sat, 06 Jun 2015 06:21:10 -0400 Original-Received: from mail-wi0-f174.google.com ([209.85.212.174]:38442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1BDt-0005A4-DB for emacs-devel@gnu.org; Sat, 06 Jun 2015 06:21:05 -0400 Original-Received: by wibdq8 with SMTP id dq8so40655998wib.1 for ; Sat, 06 Jun 2015 03:21:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=Fbxb/RL+/Uo+1ZZC25aKtHpO/Sdgp91Mk3HRdZrAMpU=; b=Of8kb/GTJkwxTGhWAg1QEhGZRelwwOfa6Yixd9/v8/OoduJrZsnQEZh5ev+ygcGNEm MiKx4j0Ta6uRR+mzvWegqTHiEXhCwB8laLhTkXZ/w+YHcG/svEFdhOWSvEqpPgQGfAPP Rh/6WA2X6lm9pH1V+m8cyYEZWt2TETyVbs6qYCVeEEoKUoa+f4Nqth5khabq29JMomtE /4gx8SWJYoKpNGBzy6FZQylZi+sVuy38CLIIrVmZaBISqWjTMJQGY+VPAarv5bZd/WmA q0YFkg8efYHR4DDeoocCwu5FTPVaFjEuBJUVumbw3vezYpm8oiuJGO8kzyKTh2cd93YE pIxQ== X-Gm-Message-State: ALoCoQlnAqDALTfhC5OMUW+OWO5glRXnRuelngJoEvaXawpkRvAL8NEuK90odAxvDgmWcKNWoky8 X-Received: by 10.194.62.132 with SMTP id y4mr14356201wjr.91.1433586064149; Sat, 06 Jun 2015 03:21:04 -0700 (PDT) Original-Received: by 10.27.86.215 with HTTP; Sat, 6 Jun 2015 03:21:04 -0700 (PDT) X-Originating-IP: [2001:a60:1641:4201:c07a:fa75:72ba:c409] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.212.174 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187064 Archived-At: --047d7b86ccfc1be53e0517d6c4a1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, while debugging unit test failures in Flycheck, I accidentally discovered checkdoc-current-buffer apparently prints messages to standard output in Emacs 25.1 in noninteractive mode. Would you please revert this change? I can understand the motivation for this =E2=80=9Cfeature=E2=80=9D, but it'= s generally a bad idea for an interactive function to print text to standard output depending on an opaque global environment. It also makes backwards compatibility harder than it needs to be: As things stand I have no choice but to check the Emacs version to print Checkdoc Errors in a consistent way across Emacs major versions, and that is somewhat ugly. The purpose of this feature would also be served by a different entry point=E2=80=94we have `ert-run-tests-interactively` and `ert-run-tests-batc= h`, too. If that is impossible please at least expose an option to turn this feature off. On a related topic, I'd have fixed this issue much faster, had this change been mentioned in the NEWS. Would you please be more strict about updating NEWS for breaking changes such as this? Sincerely, Sebastian Wiesner --047d7b86ccfc1be53e0517d6c4a1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello,

while debugging unit test failur= es in Flycheck, I accidentally discovered checkdoc-current-buffer apparentl= y prints messages to standard output in Emacs 25.1 in noninteractive mode.<= /div>

Would you please revert this change? =C2=A0
<= div>
I can understand the motivation for this =E2=80=9Cfeatur= e=E2=80=9D, but it's generally a bad idea for an interactive function t= o print text to standard output depending on an opaque global environment.= =C2=A0 It also makes backwards compatibility harder than it needs to be: = =C2=A0As things stand I have no choice but to check the Emacs version to pr= int Checkdoc Errors in a consistent way across Emacs major versions, and th= at is somewhat ugly.

The purpose of this feature w= ould also be served by a different entry point=E2=80=94we have `ert-run-tes= ts-interactively` and `ert-run-tests-batch`, too.=C2=A0 If that is impossib= le please at least expose an option to turn this feature off.
On a related topic, I'd have fixed this issue much faster, = had this change been mentioned in the NEWS.=C2=A0 Would you please be more = strict about updating NEWS for breaking changes such as this?
Sincerely,
Sebastian Wiesner

--047d7b86ccfc1be53e0517d6c4a1--