From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew De Angelis Newsgroups: gmane.emacs.devel Subject: Re: New Package: sticky-shell Date: Wed, 14 Dec 2022 00:23:56 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000001c3ef005efc2f292" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28201"; mail-complaints-to="usenet@ciao.gmane.io" To: Andrew De Angelis , emacs-devel@gnu.org, bugs@gnu.support, monnier@iro.umontreal.ca Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 14 12:51:14 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5QI5-00072f-0F for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Dec 2022 12:51:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5QHV-0000Fg-RL; Wed, 14 Dec 2022 06:50:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5KFZ-0002aD-CA for emacs-devel@gnu.org; Wed, 14 Dec 2022 00:24:13 -0500 Original-Received: from mail-vs1-xe29.google.com ([2607:f8b0:4864:20::e29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5KFX-0006zT-AU for emacs-devel@gnu.org; Wed, 14 Dec 2022 00:24:13 -0500 Original-Received: by mail-vs1-xe29.google.com with SMTP id a66so8308558vsa.6 for ; Tue, 13 Dec 2022 21:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=HcryHRLP6nl3CtkZAqX7qB5MvnXo9f1tsDD+NiLppb0=; b=PFPSuPxpHc4Q63tLcvawPaIDTbmG6GvB3rt19g8PxhGdN0z8w0RvhEhXbXosQWjrjE ln393LA6rk2U+X1WqifE9rr6IMmakPsEVnBpqENCD0KBPmP8iHPyoLrawP4OXS3o3VfY j/unZ2T5OCLietmblm2UC/D38Lk4gimDN5VU/bErd6Uv/HzMT5pa7tY3wBFb9rRvEhSr 2I3SK0KDCk0oKrXcY+DnGrzPjfvPV4Y6P9TuBDzQtWYILt9KEdoDLGOfHAyQC/11XYLu qe0NkAVP08IS9FrzDida2Po+3RdSBrvwhUatvQQNzmTkLluuS2PRHxKJXxvrIV7+3lJU Vpnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HcryHRLP6nl3CtkZAqX7qB5MvnXo9f1tsDD+NiLppb0=; b=ZiQZgTs5roi9cBYOU4ZThTafN362UbZlMHD4pfQvSgjzkbAjDf0w7c/qQy80t77K0j 3FW7XSD77ZznP4dc+5ePbcCQsZoV+lj4aty4wjtj+YyvQ9VNC9M8PNgVZA2+IX+aOAsH 2YcbEPy8mnXf+MBBR6l5lt/JEaOHq8HxsKYF96R6QHI09RGJYBGu0SLyGM5FBIzQses2 t/vbnrXn/BsKPVpYUxGz5AognLejvcv3J9m4iRCL8HmePYsZLi8Z1YHtnm1801RI1dDz QLu9Q7yzIb5KvgYzR1wTDOPCnqHhj/KlSmG5ARrEjy/jhnnMUUCXll7XiAAxa1j6a7aE WzYg== X-Gm-Message-State: ANoB5pnmczinQ/ZBx2Dkx/GvXXbkF8mbAyVCZ/sDaxjP2mxskJMZzzb1 iKh5i87bzWj2N9MEOQyRno05XvPzgz8CpxbTKYU= X-Google-Smtp-Source: AA0mqf5caazSylxGUSF60VOxm6ScjlmmrqL/7DPzUk7qlwwKyHxMcZyhmBvABr9dPeDwJnuc043WrQ5S6/YtoY3oz28= X-Received: by 2002:a67:6f06:0:b0:3a7:9bf9:bcc5 with SMTP id k6-20020a676f06000000b003a79bf9bcc5mr44189353vsc.34.1670995448182; Tue, 13 Dec 2022 21:24:08 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::e29; envelope-from=bobodeangelis@gmail.com; helo=mail-vs1-xe29.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 14 Dec 2022 06:50:30 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301380 Archived-At: --0000000000001c3ef005efc2f292 Content-Type: text/plain; charset="UTF-8" @Stefan Monnier > Step 1 (same as for GNU ELPA): get the copyright paperwork in order. > I don't see your name in the FSF's copyright assigners list, so > either it's still in process or you haven't started yet. > Let me know if you need help with that. I have not started this. This would be my first contribution to free software, so I'm not very familiar with the process. Would greatly appreciate it if you could give me a rundown of what to do or just point me to the right documentation. About `sticky-shell-prompt-modifiers`, I welcome any feedback on this current approach. My idea was to try to make it simpler for the end user, since: (add-to-list 'sticky-shell-prompt-modifiers '(propertize 'face 'minibuffer-prompt)) would be less verbose then: (advice-add 'sticky-shell-modified-prompt :filter-return (lambda (arg) (propertize arg 'face 'minibuffer-prompt))) Even though they accomplish the same thing. But I'm having second thoughts, as I see how the latter is probably more familiar to Emas users. And I'm also worried about the issue of the macro getting expanded every time we refresh the header line: I was thinking a possible solution would be to create a different macro that defines the function `sticky-shell-modified-prompt', using the user's custom modifying functions, only once when the mode is activated. Honestly, especially if we 're planning on including this as part of `shell.el`, I think the way to go might just be to remove the `sticky-shell-prompt-modifiers` mechanism. If users want to propertize the header or customize it in any way, they can use the `advice-add` function they should already be somewhat used to. @Jean Louis I'm sorry but I am unable to reproduce your issue. Is anyone else experiencing problems with sticky-shell? On Tue, Dec 13, 2022 at 2:20 PM Jean Louis wrote: > * Andrew De Angelis [2022-12-13 14:48]: > > @Jean Louis, about > > > > > I have tested it, it does not work reliably. > > > > > Thanks for flagging this. What version of Emacs are you running, and do > you > > have any special shell configuration? > > I built Emacs from master last week, did "emacs -q" and sticky-shell > works > > as expected. > > I use development version, it did not work well, I have explained what. > > > -- > Jean > > Take action in Free Software Foundation campaigns: > https://www.fsf.org/campaigns > > In support of Richard M. Stallman > https://stallmansupport.org/ > --0000000000001c3ef005efc2f292 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Step 1 (same as for GNU ELPA): get the copyright paperwo= rk in order.
=C2=A0 =C2=A0 =C2=A0 =C2=A0I don't see your name in the FSF's copyr= ight assigners list, so
=C2=A0 =C2=A0 =C2=A0 =C2=A0either it's still in process or you haven= 9;t started yet.
=C2=A0 =C2=A0 =C2=A0 =C2=A0Let me know if you need help with that.
I have not started this. This=20 would be my first contribution to free software, so I'm not very=20 familiar with the process. Would greatly appreciate it if you could give me a rundown of what to do or just point me to the right=20 documentation.

About=20 `sticky-shell-prompt-modifiers`, I welcome any feedback on this current=20 approach. My idea was to try to make it simpler for the end user, since:

(add-to-list 'sticky-shell-prompt-modifiers '= ;(propertize 'face 'minibuffer-prompt))

wo= uld be less verbose then:
(advice-add 'sticky-shell-modified-= prompt :filter-return (lambda (arg) (propertize arg 'face 'minibuff= er-prompt)))

Even though they accomplish the same thing. But I'm having second thoughts,= =20 as I see how the latter is probably more familiar to Emas users.
= And I'm also worried about the issue of the macro getting expanded every= =20 time we refresh the header line: I was thinking a possible solution=20 would be to create a different macro that defines the function=20 `sticky-shell-modified-prompt', using the user's custom modifying f= unctions, only once when the mode is activated.
=C2=A0
<= div>Honestly, especially if we 're planning on including this as part of `shell.el`,= I think the way to go might just be to remove the=20 `sticky-shell-prompt-modifiers` mechanism. If users want to propertize=20 the header or customize it in any way, they can use the `advice-add`=20 function they should already be somewhat used to.

I'm sorry but I = am unable to reproduce your issue. Is anyone else experiencing problems wit= h sticky-shell?

On Tue, Dec 13, 2022 at 2:20 PM Jean Louis &l= t;bugs@gnu.support> wrote:
* Andrew De Angelis <bobodeangelis@gmail.com> [2022-12-13 14:48]:=
> @Jean Louis, about
>
> > I have tested it, it does not work reliably.
> >
> Thanks for flagging this. What version of Emacs are you running, and d= o you
> have any special shell configuration?
> I built Emacs from master last week, did "emacs -q" and stic= ky-shell works
> as expected.

I use development version, it did not work well, I have explained what.


--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/
--0000000000001c3ef005efc2f292--