unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/exwm 26ebc32 2/3: Fix a compilation warning
       [not found] ` <E1Zd7bn-0002ck-5x@vcs.savannah.gnu.org>
@ 2015-09-19  3:57   ` Stefan Monnier
  2015-09-19  4:25     ` Chris Feng
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2015-09-19  3:57 UTC (permalink / raw)
  To: Chris Feng; +Cc: emacs-devel

> +;;;###autoload
>  (defvar exwm-floating-border-width 1 "Border width of the floating window.")

Autoloading variables is usually a bad idea.
Silencing a compiler warning is definitely not a good reason to do that.

Why not add (defvar exwm-floating-border-width) to the file where the
compiler complains?


        Stefan



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [elpa] externals/exwm 26ebc32 2/3: Fix a compilation warning
  2015-09-19  3:57   ` [elpa] externals/exwm 26ebc32 2/3: Fix a compilation warning Stefan Monnier
@ 2015-09-19  4:25     ` Chris Feng
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Feng @ 2015-09-19  4:25 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

> Why not add (defvar exwm-floating-border-width) to the file where the
> compiler complains?

Thanks for the tip! I'll fix that.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-19  4:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20150919021034.10018.87498@vcs.savannah.gnu.org>
     [not found] ` <E1Zd7bn-0002ck-5x@vcs.savannah.gnu.org>
2015-09-19  3:57   ` [elpa] externals/exwm 26ebc32 2/3: Fix a compilation warning Stefan Monnier
2015-09-19  4:25     ` Chris Feng

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).