unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chris Feng <chris.w.feng@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/xelb ad879fb: Backport cl-defgeneric to Emacs 24
Date: Wed, 23 Sep 2015 21:56:19 +0800	[thread overview]
Message-ID: <CAP4=87EJRS1X4FvzTFp1RShWZqBYEL_ShaAeD_1qZDfL1t789A@mail.gmail.com> (raw)
In-Reply-To: <jwvsi65464l.fsf-monnier+emacsdiffs@gnu.org>

>> * Due to a bug of EIEIO in Emacs 24, I cannot define classes with more
>> than 101 slots. Would it be possible to fix it in the next release of
>> Emacs 24 (by simply setting a fallback length of the obarray in
>> `eieio-defclass')?
>
> Not sure what you're referring to.

I meant in the following snippet (from eieio-defclass in eieio-core.el
of emacs-24 branch) `vl' would be nil if the class has more than 101
slots, and the subsequent `make-vector` would fail:

(let* ((cnt 0)
       (pubsyms (eieio--class-public-a newc))
       (prots (eieio--class-protection newc))
       (l (length pubsyms))
       (vl (let ((primes '( 3 5 7 11 13 17 19 23 29 31 37 41 43 47
                              53 59 61 67 71 73 79 83 89 97 101 )))
             (while (and primes (< (car primes) l))
               (setq primes (cdr primes)))
             (car primes)))
       (oa (make-vector vl 0))
       (newsym))

>> * And finally a minor issue: README.org was picked as the long
>> description of this package. I personally consider org-mode files as
>> well as reStructuredText or other markup files, when not properly
>> rendered, are not easily readable. In fact I made this file mainly for
>> the GitHub project page and thought GNU ELPA would pick the
>> 'Commentary:' section. Of course I can rename it to something not
>> mentioned in archive-contents.el to work around this problem.
>
> If you use README.md, it will be ignored (quoting
> elpa.git/admin/archive-contents.el:
>
>       (let ((rm (archive--get-section
>                  "Commentary" '("README" "README.rst"
>                                 ;; Most README.md files seem to be currently
>                                 ;; worse than the Commentary: section :-(
>                                 ;; "README.md"
>                                 "README.org")
>                  srcdir mainsrcfile)))

Yes, I mentioned this solution. But I guess the exclusion of README.md
is merely a temporary measure?



  reply	other threads:[~2015-09-23 13:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150920005618.18308.62122@vcs.savannah.gnu.org>
     [not found] ` <E1ZdSvS-0004ly-Ut@vcs.savannah.gnu.org>
2015-09-20 15:25   ` [elpa] externals/xelb ad879fb: Backport cl-defgeneric to Emacs 24 Stefan Monnier
2015-09-21  5:11     ` Chris Feng
2015-09-23  1:08       ` Chris Feng
2015-09-23 13:36         ` Stefan Monnier
2015-09-23 13:56           ` Chris Feng [this message]
2015-09-23 15:59             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP4=87EJRS1X4FvzTFp1RShWZqBYEL_ShaAeD_1qZDfL1t789A@mail.gmail.com' \
    --to=chris.w.feng@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).