compile 28.2 with checkinstall

compile 28.2 with checkinstall

[Laurent Arnoud]

[-- Attachment #1.1: Type: text/plain, Size: 189 bytes --]

Hi,

I've had the same issue when trying to compile emacs and install it with
the checkinstall tool that creates a quick Debian package.

Its my first patch to emacs hope it helps,
Laurent

[-- Attachment #1.2: Type: text/html, Size: 288 bytes --]

[-- Attachment #2: 0001-Use-abs_srcdir-for-install-from-other-pwd.patch --]
[-- Type: text/x-patch, Size: 929 bytes --]

From 97cee991496e399e609f4f7631f36e75d68b36fd Mon Sep 17 00:00:00 2001
From: Laurent Arnoud <laurent.arnoud@platform.sh>
Date: Wed, 7 Dec 2022 10:55:28 +0100
Subject: [PATCH] Use abs_srcdir for install from other pwd

when using checkinstall to package emacs it fail because
of the relative path of publicsuffix.txt

More info at

https://emacs.stackexchange.com/questions/52926/installing-emacs-26-3
---
 Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git Makefile.in Makefile.in
index 93609a4e16..6a93f52d72 100644
--- Makefile.in
+++ Makefile.in
@@ -749,7 +749,7 @@ install-arch-indep:
 	  for f in `find . -name "*.elc" -print | sed 's/.elc$$/.el/'`; do \
 	    ${GZIP_PROG} -9n "$$f"; \
 	  done; \
-	  ${GZIP_PROG} -9n "../etc/publicsuffix.txt"; \
+	  ${GZIP_PROG} -9n "${abs_srcdir}/etc/publicsuffix.txt"; \
 	}
 	-chmod -R a+r "$(DESTDIR)${datadir}/emacs/${version}" ${COPYDESTS}
 
-- 
2.30.2

Re: compile 28.2 with checkinstall

[Eli Zaretskii]

> From: Laurent Arnoud <laurent.arnoud@platform.sh>
> Date: Wed, 7 Dec 2022 11:00:30 +0100
> 
> I've had the same issue when trying to compile emacs and install it with the checkinstall tool that creates a
> quick Debian package.
> 
> Its my first patch to emacs hope it helps,
> Laurent
> 
> From 97cee991496e399e609f4f7631f36e75d68b36fd Mon Sep 17 00:00:00 2001
> From: Laurent Arnoud <laurent.arnoud@platform.sh>
> Date: Wed, 7 Dec 2022 10:55:28 +0100
> Subject: [PATCH] Use abs_srcdir for install from other pwd
> 
> when using checkinstall to package emacs it fail because
> of the relative path of publicsuffix.txt
> 
> More info at
> 
> https://emacs.stackexchange.com/questions/52926/installing-emacs-26-3

Can you explain why you must use abs_srcdir here, and what is special
about checkinstall that the absolute directory name must be used with
it?

Thanks.

Re: compile 28.2 with checkinstall

[Laurent Arnoud]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On Wed, Dec 7, 2022 at 6:41 PM Eli Zaretskii <eliz@gnu.org> wrote:

> Can you explain why you must use abs_srcdir here, and what is special
> about checkinstall that the absolute directory name must be used with
> it?
>

I had the same error as in the stackexchange

```

 Compressing *.el etc. ...
 gzip: ../etc/publicsuffix.txt: No such file or directory
 make: *** [Makefile:571: install-arch-indep] Error 1

 ****  Installation failed. Aborting package creation.

```

When I tried to debug, I found that the `pwd` is on `
/usr/local/share/emacs/28.2/lisp` at this step with checkinstall.
I thought it must be another cd that is not reverted (cd -) but did not
find it, using abs_srcdir here did not look bad either.

Thanks

[-- Attachment #2: Type: text/html, Size: 1151 bytes --]

Re: compile 28.2 with checkinstall

[Eli Zaretskii]

> From: Laurent Arnoud <laurent.arnoud@platform.sh>
> Date: Thu, 8 Dec 2022 15:59:02 +0100
> Cc: emacs-devel@gnu.org
> 
>  Compressing *.el etc. ...
>  gzip: ../etc/publicsuffix.txt: No such file or directory
>  make: *** [Makefile:571: install-arch-indep] Error 1
> 
>  ****  Installation failed. Aborting package creation.
> ``` 
> 
> When I tried to debug, I found that the `pwd` is on `/usr/local/share/emacs/28.2/lisp` at this step
> with checkinstall.

Thanks.  But we have other installation commands that use just
$(srcdir) (which is a relative directory, AFAICT), and they do work
with checkinstall, so I wonder how is this one different.

Re: compile 28.2 with checkinstall

[Laurent Arnoud]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

On Thu, Dec 8, 2022 at 4:41 PM Eli Zaretskii <eliz@gnu.org> wrote:

> Thanks.  But we have other installation commands that use just
> $(srcdir) (which is a relative directory, AFAICT), and they do work
> with checkinstall, so I wonder how is this one different.
>

Not sure either, but using $(srcdir) does not fix the issue because
of the `pwd` when running checkinstall.

[-- Attachment #2: Type: text/html, Size: 690 bytes --]

Re: compile 28.2 with checkinstall

[Eli Zaretskii]

> From: Laurent Arnoud <laurent.arnoud@platform.sh>
> Date: Tue, 13 Dec 2022 14:37:21 +0100
> Cc: emacs-devel@gnu.org
> 
> On Thu, Dec 8, 2022 at 4:41 PM Eli Zaretskii <eliz@gnu.org> wrote:
> 
>  Thanks.  But we have other installation commands that use just
>  $(srcdir) (which is a relative directory, AFAICT), and they do work
>  with checkinstall, so I wonder how is this one different.
> 
> Not sure either, but using $(srcdir) does not fix the issue because
> of the `pwd` when running checkinstall.

Where's that `pwd` call?  In our Makefile or in checkinstall?