unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philipp Stephani <phst@google.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
	Philipp Stephani <p.stephani2@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: scratch/sigchld-fd 8f0ce42 1/2: Fix deadlock when receiving SIGCHLD during 'pselect'.
Date: Tue, 19 Jan 2021 21:58:26 +0100	[thread overview]
Message-ID: <CAP-RRPvDKTWHp92yBM+SpVAc=F1+JRGdkro6EYjUx0EMnr7gWA@mail.gmail.com> (raw)
In-Reply-To: <871regr6x5.fsf@igel.home>

Am Di., 19. Jan. 2021 um 21:46 Uhr schrieb Andreas Schwab
<schwab@linux-m68k.org>:
>
> On Jan 19 2021, Eli Zaretskii wrote:
>
> > I'd be happier if we had some direct evidence to these effects.  I'd
> > also be surprised to hear that pselect doesn't return with EINTR when
> > SIGCHLD comes in.  It is more likely that SIGCHLD is delivered before
> > we call pselect, but if that is the case, we should be able to
> > reliably detect that, I think.
>
> If you want reliable detection of SIGCHLD, you need to block the signal
> around pselect and let pselect unblock it, atomically.

Right. It looks like we're not doing that because we want to support
systems that don't have pselect (and it's gnulib emulation can't be
race-free).



  reply	other threads:[~2021-01-19 20:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210116184947.2105.45267@vcs0.savannah.gnu.org>
     [not found] ` <20210116184949.3C17C211A5@vcs0.savannah.gnu.org>
2021-01-19 15:10   ` scratch/sigchld-fd 8f0ce42 1/2: Fix deadlock when receiving SIGCHLD during 'pselect' Eli Zaretskii
2021-01-19 18:21     ` Philipp Stephani
2021-01-19 19:14       ` Eli Zaretskii
2021-01-19 20:22         ` Philipp Stephani
2021-01-20 15:05           ` Eli Zaretskii
2021-01-23 17:36             ` Philipp Stephani
2021-01-23 18:23               ` Eli Zaretskii
2021-01-23 18:30                 ` Philipp Stephani
2021-01-19 20:46         ` Andreas Schwab
2021-01-19 20:58           ` Philipp Stephani [this message]
2021-01-20 18:07             ` Andreas Schwab
2021-01-20  3:37           ` Eli Zaretskii
2021-01-20  8:37             ` Andreas Schwab
2021-01-20  8:52               ` Eli Zaretskii
2021-01-20  9:18                 ` Andreas Schwab
2021-01-20 10:14                   ` Eli Zaretskii
2021-01-20 10:17                     ` Andreas Schwab
2021-01-20 15:30                       ` Eli Zaretskii
2021-01-20 15:48                         ` Andreas Schwab
2021-01-20 16:40                           ` Eli Zaretskii
2021-01-20 16:44                             ` Andreas Schwab
2021-01-20 17:03                               ` Eli Zaretskii
2021-01-20 17:30                                 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-RRPvDKTWHp92yBM+SpVAc=F1+JRGdkro6EYjUx0EMnr7gWA@mail.gmail.com' \
    --to=phst@google.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).