From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: =?UTF-8?Q?Re=3A_master_b467bb5_4=2F4=3A_Minimize_=E2=80=98equal=E2=80=99_calls_i?= =?UTF-8?Q?n_=28delete_x_vector=29?= Date: Sat, 15 Aug 2020 20:21:48 +0000 Message-ID: References: <20200815181956.27401.76683@vcs0.savannah.gnu.org> <20200815181959.E7DC3209AC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1485"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 15 22:22:58 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k72hd-0000Ju-UM for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 22:22:57 +0200 Original-Received: from localhost ([::1]:33472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k72hd-0006GN-1U for ged-emacs-devel@m.gmane-mx.org; Sat, 15 Aug 2020 16:22:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k72h8-0005qB-Tm for emacs-devel@gnu.org; Sat, 15 Aug 2020 16:22:26 -0400 Original-Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]:37970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k72h7-0005Zf-EE for emacs-devel@gnu.org; Sat, 15 Aug 2020 16:22:26 -0400 Original-Received: by mail-oo1-xc2b.google.com with SMTP id z11so2643218oon.5 for ; Sat, 15 Aug 2020 13:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0GL7/ocwckVW/EowcxmBGnnyJRMt+3ahwtiehhcWTAA=; b=bwkjFgKae93eykB6xYzUVen/nN4hA7pC5hziKXSgKKuHv2yFcqxGh0T4Z+5hq3888c wkeSK+7cm81sagFh3xkPUulsuoaORPQJSyuXbx4Nv65+EUcogFHYDMwRxkDQgdgzhUw5 kBj9gN7otG+/XwAo6mjPYd5Le+3/ObZSs7zJ7uTQe1wdrMag3zVL2ktK9kzL5ZH3D1O0 uCpzmT+4WIYN/2M2QKrRHq6CgS2mTgayX3pYMMZ/AxElSr49UcjVlshrxm3ab2Gmx3np 7C7XqR85qK6YQ4g5zjN8VsDoCzeKujUam36cW6VQZ/QEuvAbYs71+a2EV4hf9+JOnC6m ouKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0GL7/ocwckVW/EowcxmBGnnyJRMt+3ahwtiehhcWTAA=; b=bLRLiGnhHRHqhfD1QV17Cn9NR6RiRvtugEZCaFp6j7CI0pUguc1qLpFariAThQ3k/s mEQu2lzp3p9LMDJLU6VEx4jEw4akmgCbhzpkXDNQxdEM8SrJRokp5efRJ/gxGEFXdZTp BP9SMuUzvsOx9WlFSkBOaiDEkL+YCO21CdzPa99Ll8yvAwKXb5fui9b3QpYtlP9kgqbw bw1ZUc9jOEO3DbhBnwbHlvEmQaEpjI76htYUMEz83dHHrqTvsovllsIuJ05IZ9/YJI20 vJGtgZcVkCuniebLR4VwBkJbHSSqk+jhUoMKQs76hudhZVs8u+Bvt0IMxRs1+7twyVu8 faBw== X-Gm-Message-State: AOAM530792n0OyIchzqGjRiDZW7jqlGW8CTzJuSAOyct3m2QFty/lNtW BUzCjGrpMcK0w/xMjByPyXf6BhQed9J2eLIhsGw= X-Google-Smtp-Source: ABdhPJyK2m5TDHIikR8WDH0oKpFQE+Om6Zu/zCqvIod388WNgRqU/zAIj5h7FaPT00lZDBMnxZaTzfIBUl4xBXbmDv8= X-Received: by 2002:a4a:e70a:: with SMTP id y10mr6094536oou.44.1597522944147; Sat, 15 Aug 2020 13:22:24 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::c2b; envelope-from=pipcet@gmail.com; helo=mail-oo1-xc2b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253825 Archived-At: On Sat, Aug 15, 2020 at 7:42 PM Paul Eggert wrote: > On 8/15/20 12:22 PM, Pip Cet wrote: > > > I'd prefer the attached: this is probably not worth worrying > > too much about, so go with something straightforward? > > Thanks for the quick review and patch. I came up with something a bit simpler > and installed the attached. Looks correct, but establishes a rather questionable precedent of putting Lisp_Objects in SAFE_ALLOCA'd space. That's okay in this specific case, for a number of reasons, but it's bound to be copied by someone in circumstances where it's not :-) > It does bug me a bit that GCC generates bad code for 'NILP (Fequal (...))' here. > I've been meaning to add a bool function equal (...) that would simplify the C > source a bit and presumably let GCC do better, but that can wait. What's GCC doing, for you? I see that it doesn't eliminate the potentially dead store to kept[n] here, but other than that the code looks okay to me.