From: Pip Cet <pipcet@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: master b467bb5 4/4: Minimize ‘equal’ calls in (delete x vector)
Date: Sat, 15 Aug 2020 20:21:48 +0000 [thread overview]
Message-ID: <CAOqdjBfw4OE+3za4s0jhxkVoRz9P5DNMoPzvTdGqNONmBksTkg@mail.gmail.com> (raw)
In-Reply-To: <ba1e7497-21a7-5826-af1b-71a9e4666fa2@cs.ucla.edu>
On Sat, Aug 15, 2020 at 7:42 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
> On 8/15/20 12:22 PM, Pip Cet wrote:
>
> > I'd prefer the attached: this is probably not worth worrying
> > too much about, so go with something straightforward?
>
> Thanks for the quick review and patch. I came up with something a bit simpler
> and installed the attached.
Looks correct, but establishes a rather questionable precedent of
putting Lisp_Objects in SAFE_ALLOCA'd space. That's okay in this
specific case, for a number of reasons, but it's bound to be copied by
someone in circumstances where it's not :-)
> It does bug me a bit that GCC generates bad code for 'NILP (Fequal (...))' here.
> I've been meaning to add a bool function equal (...) that would simplify the C
> source a bit and presumably let GCC do better, but that can wait.
What's GCC doing, for you? I see that it doesn't eliminate the
potentially dead store to kept[n] here, but other than that the code
looks okay to me.
next prev parent reply other threads:[~2020-08-15 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200815181956.27401.76683@vcs0.savannah.gnu.org>
[not found] ` <20200815181959.E7DC3209AC@vcs0.savannah.gnu.org>
2020-08-15 19:00 ` master b467bb5 4/4: Minimize ‘equal’ calls in (delete x vector) Pip Cet
2020-08-15 19:22 ` Pip Cet
2020-08-15 19:42 ` Paul Eggert
2020-08-15 20:21 ` Pip Cet [this message]
2020-08-16 0:49 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOqdjBfw4OE+3za4s0jhxkVoRz9P5DNMoPzvTdGqNONmBksTkg@mail.gmail.com \
--to=pipcet@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).