From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: Assertion violation in pdumper.c Date: Mon, 17 Aug 2020 16:28:21 +0000 Message-ID: References: <83r1s5gybp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 17 18:29:45 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k7i13-0001CO-S0 for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Aug 2020 18:29:45 +0200 Original-Received: from localhost ([::1]:55296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7i12-0005RY-Ss for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Aug 2020 12:29:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7i0L-0004E3-66 for emacs-devel@gnu.org; Mon, 17 Aug 2020 12:29:01 -0400 Original-Received: from mail-oo1-xc44.google.com ([2607:f8b0:4864:20::c44]:43513) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k7i0J-0006L2-Nk; Mon, 17 Aug 2020 12:29:00 -0400 Original-Received: by mail-oo1-xc44.google.com with SMTP id z10so3519210ooi.10; Mon, 17 Aug 2020 09:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MbMPdoS+PngyI4D2FuQpXCHkN7S9Yi7n4RBwuNKiCZM=; b=mAhzJO2Enwt3mizuKlVpYuLtvgnfQXl1qiTrgUNy1HtrWqZPK8HGKX+qIKzRQs7iAA SX/BdHo44bIMHQGbU9/CPiEph80QMHj86OQWg1UgGCFMhoXrGwjhvW7JIjKBig5z0rT9 s6ilfznxPsAlli23ojRhJ6RNSP1jDMa6K7E9h6eXOSnONBZsblJHMI241tVy0hzc7r+t VgkZuzwOnuBrHx82+FjS+q88DpQs9YjBiC5ZZt8RMnt8SsDTLnRHJXmcFvKMR3q5blk/ OUADbTqbyHFOz2aC7K9b3IURAtwmJCHDX57wmeGaNowgW8J5bGBmcZjl2fa1eIrAhIq4 xyjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MbMPdoS+PngyI4D2FuQpXCHkN7S9Yi7n4RBwuNKiCZM=; b=FoWjBSRWhFuuOE42HQgdDj2FaJRx1EneJTlXg/d5KcJnf2g8i4hN1o9DKGqZ2awk6r fCIa/D6KztGXvs/KnyJH1/9WqCiG+lbdlw4E0wsP9dOqDix5LxqhNSkBJgyrER7AVsAt D8/TvzL+EF5AsSIJhs1bzqRXa7wUFy50V9e5JEG0tghmgY9kngN+lIrK3XfLo+3qBzTX sQgAOWJ0vazU3kVDBDtkqxxYpMoyW8eupxbbdyi5XPm1ZMnKdmMzjbOWHB4aqkpusPH7 c9ZlthW0fxL3JRRkLfZDCNBOb5NmDgE3GrQPTTe4mwqVHP9gxQP2F8TdydQIVn3IQF6C upRg== X-Gm-Message-State: AOAM531PdmL7NJXUOjEQSRitjE+3xCOfLtNhoqxwhsAAcdSQDtOmhIO1 izCpeyEPkLEjhNFxlxaKZrJaDHbYYDfqArqDznGsLAz7ZV8= X-Google-Smtp-Source: ABdhPJyokMgxgm1pJQYFVn2XuZe9/rb2KO0akZxPYjY6SCAqRZCxVDTwsayHi/HATUShjh2UIKeNawQA02UyAf7zsrU= X-Received: by 2002:a4a:be0c:: with SMTP id l12mr11594527oop.22.1597681737442; Mon, 17 Aug 2020 09:28:57 -0700 (PDT) In-Reply-To: <83r1s5gybp.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::c44; envelope-from=pipcet@gmail.com; helo=mail-oo1-xc44.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253896 Archived-At: On Mon, Aug 17, 2020 at 2:08 PM Eli Zaretskii wrote: > Since the recent changes in pdumper.c, Emacs started hitting an > assertion violation and aborting during the build on one of my > systems, see the backtrace below. I need the following to work around > the abort: > > diff --git a/src/pdumper.c b/src/pdumper.c > index 2d1b19283c..217ffa6783 100644 > --- a/src/pdumper.c > +++ b/src/pdumper.c > @@ -4999,7 +4999,7 @@ pdumper_find_object_type_impl (const void *obj) > if (offset % DUMP_ALIGNMENT != 0) > return PDUMPER_NO_OBJECT; > ptrdiff_t bitno = offset / DUMP_ALIGNMENT; > - if (offset < dump_private.header.cold_start > + if (offset < dump_private.header.discardable_start > && !dump_bitset_bit_set_p (&dump_private.last_mark_bits, bitno)) > return PDUMPER_NO_OBJECT; > const struct dump_reloc *reloc = That looks like the correct fix to me. I'd mistakenly thought cold objects preceded discardable ones. > My hypothesis is that we are trying to call dump_bitset_bit_set_p on a > pointer that shouldn't be tested like that, because the number of > words we reserve for a bitset is only enough for objects stored before > discardable_start. I agree.